Title: keygen: add generate_signing_keypair() programmatic API alongside adcp-keygen CLI · Issue #217 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: keygen: add generate_signing_keypair() programmatic API alongside adcp-keygen CLI · Issue #217 · adcontextprotocol/adcp-client-python
X Title: keygen: add generate_signing_keypair() programmatic API alongside adcp-keygen CLI · Issue #217 · adcontextprotocol/adcp-client-python
Description: Observation Round-8 webhooks-9421 DX agent (PR #205) reported: "`adcp-keygen` shipped to `.venv/bin/` isn't on PATH when invoking `.venv/bin/python` directly (typical CI / subprocess context). First `subprocess.run(["adcp-keygen", ...])`...
Open Graph Description: Observation Round-8 webhooks-9421 DX agent (PR #205) reported: "`adcp-keygen` shipped to `.venv/bin/` isn't on PATH when invoking `.venv/bin/python` directly (typical CI / subprocess context). Firs...
X Description: Observation Round-8 webhooks-9421 DX agent (PR #205) reported: "`adcp-keygen` shipped to `.venv/bin/` isn't on PATH when invoking `.venv/bin/python` directly (typical CI / subprocess conte...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/217
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"keygen: add generate_signing_keypair() programmatic API alongside adcp-keygen CLI","articleBody":"## Observation\n\nRound-8 webhooks-9421 DX agent (PR #205) reported:\n\n> \"\\`adcp-keygen\\` shipped to \\`.venv/bin/\\` isn't on PATH when invoking \\`.venv/bin/python\\` directly (typical CI / subprocess context). First \\`subprocess.run([\\\"adcp-keygen\\\", ...])\\` raised \\`FileNotFoundError\\`. Worked around with \\`Path(sys.executable).parent / \\\"adcp-keygen\\\"\\`. Suggest either documenting this idiom in the keygen module or shipping \\`generate_signing_keypair()\\` as a programmatic API returning \\`(pem_bytes, public_jwk)\\` so callers don't need to shell out.\"\n\n## Proposal\n\nAdd a programmatic entry point to `src/adcp/signing/keygen.py`:\n\n```python\ndef generate_signing_keypair(\n *,\n alg: Literal[\"ed25519\", \"es256\"] = \"ed25519\",\n kid: str | None = None,\n purpose: Literal[\"request-signing\", \"webhook-signing\"] = \"request-signing\",\n passphrase: bytes | None = None,\n) -> tuple[bytes, dict[str, Any]]:\n \"\"\"Generate a signing keypair. Returns (pem_bytes, public_jwk).\n\n Programmatic companion to the ``adcp-keygen`` CLI — call this from\n tests, provisioning scripts, or any non-shell context where spawning\n a subprocess is wrong.\n\n Returns:\n (pem_bytes, public_jwk) tuple. ``pem_bytes`` is the PKCS#8\n private key (optionally encrypted if ``passphrase`` is set).\n ``public_jwk`` is the public half, ready to publish at your\n agent's ``jwks_uri``.\n \"\"\"\n```\n\nRe-export from `adcp.signing` + top-level `adcp`. Rewrite the CLI's `main()` to call this helper + handle file-writing + stdout printing separately. Zero duplication between CLI and programmatic paths.\n\n## Acceptance\n\n- Unit test: `generate_signing_keypair()` returns a PEM that loads via `load_pem_private_key` and a JWK that `WebhookSender.from_jwk` accepts.\n- Unit test: `purpose=\"webhook-signing\"` produces a JWK with `adcp_use: \"webhook-signing\"`.\n- CLI tests still pass — CLI `main()` now just wraps the helper.\n- Doc example in `src/adcp/signing/__init__.py` showing programmatic + CLI equivalence.\n\n## Priority\n\n4.1 DX polish. Current CLI works; this eliminates subprocess-path ergonomic tax for test harnesses and provisioning code.\n\nRelated: adcontextprotocol/adcp-client-python#205 (round-8 validation)","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-20T04:40:13Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/217"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f3cf8092-6d03-151e-8f8c-a94829d52d93 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 836C:240CD1:AD1714:DDEBC8:6B00F67E |
| html-safe-nonce | a220eb258da03397cc4e2d0e0990c32bfb1ba804a24a833c4a3174e0ed7dc6d9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzZDOjI0MENEMTpBRDE3MTQ6RERFQkM4OjZCMDBGNjdFIiwidmlzaXRvcl9pZCI6IjU0NDY1NDE2ODU5MDk2ODE3OTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b9a699d2246c3a5ebeee049329790b1e6af2369b3b3695d13b99296380cc792f |
| hovercard-subject-tag | issue:4293119728 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/217/issue_layout |
| twitter:image | https://opengraph.githubassets.com/a638c0a91bf92b38200e2b3da1fbe36c55cbc2b91d7066623425f12707aab654/adcontextprotocol/adcp-client-python/issues/217 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a638c0a91bf92b38200e2b3da1fbe36c55cbc2b91d7066623425f12707aab654/adcontextprotocol/adcp-client-python/issues/217 |
| og:image:alt | Observation Round-8 webhooks-9421 DX agent (PR #205) reported: "`adcp-keygen` shipped to `.venv/bin/` isn't on PATH when invoking `.venv/bin/python` directly (typical CI / subprocess context). Firs... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width