Title: skill(signals): inline sync_accounts/sync_governance stubs (remove last cross-reference to seller example) · Issue #216 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: skill(signals): inline sync_accounts/sync_governance stubs (remove last cross-reference to seller example) · Issue #216 · adcontextprotocol/adcp-client-python
X Title: skill(signals): inline sync_accounts/sync_governance stubs (remove last cross-reference to seller example) · Issue #216 · adcontextprotocol/adcp-client-python
Description: Observation Round-8 signals validator (PR #205) reported: "Almost no friction. Had to glance at `seller_agent.py` to confirm `governance_agents` shape inside `sync_governance` (url + categories). Skill says 'see examples' but an inline s...
Open Graph Description: Observation Round-8 signals validator (PR #205) reported: "Almost no friction. Had to glance at `seller_agent.py` to confirm `governance_agents` shape inside `sync_governance` (url + categories). S...
X Description: Observation Round-8 signals validator (PR #205) reported: "Almost no friction. Had to glance at `seller_agent.py` to confirm `governance_agents` shape inside `sync_governance` (url + categorie...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/216
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"skill(signals): inline sync_accounts/sync_governance stubs (remove last cross-reference to seller example)","articleBody":"## Observation\n\nRound-8 signals validator (PR #205) reported:\n\n> \"Almost no friction. Had to glance at \\`seller_agent.py\\` to confirm \\`governance_agents\\` shape inside \\`sync_governance\\` (url + categories). Skill says 'see examples' but an inline stub would remove the jump. Biggest remaining ask: inline the minimal \\`sync_accounts\\`/\\`sync_governance\\` bodies (~15 lines total) directly in SKILL.md. That's the last cross-reference in an otherwise self-contained skill.\"\n\nRound 7 added a \"Governance tracks (optional)\" section to `skills/build-signals-agent/SKILL.md` with cross-references to `examples/seller_agent.py` for full shape. Round 8 confirmed the section unblocks `signal_marketplace/governance_denied` — time went from 12 min + 3 attempts to 4 min + 1 attempt — but a fresh user still has to jump to the seller example to copy `sync_governance` shape.\n\n## Fix\n\nInline the minimal `sync_accounts` + `sync_governance` bodies directly in `skills/build-signals-agent/SKILL.md`'s Governance section. Copy from `examples/seller_agent.py` (or the seller skill's own example) — keep both under 25 lines combined. Drop the \"see `examples/seller_agent.py`\" cross-reference once inlined.\n\n## Priority\n\n4.1 cheap win. Signals skill is ~4 minutes to PASS post-R7 fixes; this makes it fully self-contained.\n\nRelated: adcontextprotocol/adcp-client-python#205 (round-8 validation)","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-20T04:40:00Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/216"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:5fbfcd08-ba8b-2cb6-a3ee-f8fa1bfb0e21 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8640:361639:CFFE6E:1164D37:6B010083 |
| html-safe-nonce | acb0b030b9fa4cd3b538894634993cad4c6532d4ca4039075dfdc8d40cc73bae |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjQwOjM2MTYzOTpDRkZFNkU6MTE2NEQzNzo2QjAxMDA4MyIsInZpc2l0b3JfaWQiOiI4NzU5NDg2MDg5MDAzNjY0NjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 44270fbba591cb552d351e0714f0ef842415be50b880b4bbb75e0ffc3a4dffbd |
| hovercard-subject-tag | issue:4293118956 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/216/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b52a561e98040f65a0da3d5e3b7431bd978586282c1fe261bb619ffd496862c5/adcontextprotocol/adcp-client-python/issues/216 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b52a561e98040f65a0da3d5e3b7431bd978586282c1fe261bb619ffd496862c5/adcontextprotocol/adcp-client-python/issues/216 |
| og:image:alt | Observation Round-8 signals validator (PR #205) reported: "Almost no friction. Had to glance at `seller_agent.py` to confirm `governance_agents` shape inside `sync_governance` (url + categories). S... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width