Title: mcp: inline $defs in generated inputSchema for simpler clients · Issue #208 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: mcp: inline $defs in generated inputSchema for simpler clients · Issue #208 · adcontextprotocol/adcp-client-python
X Title: mcp: inline $defs in generated inputSchema for simpler clients · Issue #208 · adcontextprotocol/adcp-client-python
Description: Context As of PR #205, all 57 MCP tools auto-generate their inputSchema from Pydantic request models via _generate_pydantic_schemas() at src/adcp/server/mcp_tools.py:915. Pydantic emits $defs + $ref for nested models, which is valid JSON...
Open Graph Description: Context As of PR #205, all 57 MCP tools auto-generate their inputSchema from Pydantic request models via _generate_pydantic_schemas() at src/adcp/server/mcp_tools.py:915. Pydantic emits $defs + $re...
X Description: Context As of PR #205, all 57 MCP tools auto-generate their inputSchema from Pydantic request models via _generate_pydantic_schemas() at src/adcp/server/mcp_tools.py:915. Pydantic emits $defs + $re...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/208
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"mcp: inline $defs in generated inputSchema for simpler clients","articleBody":"**Context**\n\nAs of PR #205, all 57 MCP tools auto-generate their `inputSchema` from Pydantic request models via `_generate_pydantic_schemas()` at `src/adcp/server/mcp_tools.py:915`. Pydantic emits `$defs` + `$ref` for nested models, which is valid JSON Schema but trips up some MCP clients that don't resolve `$ref`.\n\n**What to do**\n\nAdd an inlining pass after `_generate_pydantic_schemas()` that resolves every `$ref` into its `$defs` body and drops the `$defs` block. Preserve descriptions and required-field lists. Gate behind a flag if we want to keep the `$defs` form available for clients that do resolve refs.\n\n**Acceptance**\n\n- All 57 tools' `inputSchema` survive the transform with no lost semantics\n- A new `tests/test_mcp_schema_drift.py` test asserts no `$ref` strings appear in any generated schema\n- MCP Inspector + the `@adcp/client` storyboard runner both still accept the output\n\n**Priority**\n\n4.1 follow-up. Current state is spec-valid; this is strictly DX for clients that take the inline path.\n\nSurfaced from: https://github.com/adcontextprotocol/adcp-client-python/pull/205","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-20T02:20:44Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/208"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:989b86b8-0aef-a685-5a36-ead770e2f4b6 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E3F6:16EED3:ABF7D0:DBC399:6B00F698 |
| html-safe-nonce | cf8803cede78c33eaafab72e71d7eb2f61d1d17cb50ae66d06c5f8e8711b6626 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0Y2OjE2RUVEMzpBQkY3RDA6REJDMzk5OjZCMDBGNjk4IiwidmlzaXRvcl9pZCI6IjU2Nzc1Mjk5NjYzMDA5NTIyMTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 6f7069cc6f82afe0c9d12fd5d5a27dc5c48ab29436b60837093e437ca9dd7f48 |
| hovercard-subject-tag | issue:4292720603 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/208/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c4abd9cd37b8b8a8d2821988be48b1ca921409cbbd9aa4af31fc6f700e6fc6b3/adcontextprotocol/adcp-client-python/issues/208 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c4abd9cd37b8b8a8d2821988be48b1ca921409cbbd9aa4af31fc6f700e6fc6b3/adcontextprotocol/adcp-client-python/issues/208 |
| og:image:alt | Context As of PR #205, all 57 MCP tools auto-generate their inputSchema from Pydantic request models via _generate_pydantic_schemas() at src/adcp/server/mcp_tools.py:915. Pydantic emits $defs + $re... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width