René's URL Explorer Experiment


Title: mcp: inline $defs in generated inputSchema for simpler clients · Issue #208 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: mcp: inline $defs in generated inputSchema for simpler clients · Issue #208 · adcontextprotocol/adcp-client-python

X Title: mcp: inline $defs in generated inputSchema for simpler clients · Issue #208 · adcontextprotocol/adcp-client-python

Description: Context As of PR #205, all 57 MCP tools auto-generate their inputSchema from Pydantic request models via _generate_pydantic_schemas() at src/adcp/server/mcp_tools.py:915. Pydantic emits $defs + $ref for nested models, which is valid JSON...

Open Graph Description: Context As of PR #205, all 57 MCP tools auto-generate their inputSchema from Pydantic request models via _generate_pydantic_schemas() at src/adcp/server/mcp_tools.py:915. Pydantic emits $defs + $re...

X Description: Context As of PR #205, all 57 MCP tools auto-generate their inputSchema from Pydantic request models via _generate_pydantic_schemas() at src/adcp/server/mcp_tools.py:915. Pydantic emits $defs + $re...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/208

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"mcp: inline $defs in generated inputSchema for simpler clients","articleBody":"**Context**\n\nAs of PR #205, all 57 MCP tools auto-generate their `inputSchema` from Pydantic request models via `_generate_pydantic_schemas()` at `src/adcp/server/mcp_tools.py:915`. Pydantic emits `$defs` + `$ref` for nested models, which is valid JSON Schema but trips up some MCP clients that don't resolve `$ref`.\n\n**What to do**\n\nAdd an inlining pass after `_generate_pydantic_schemas()` that resolves every `$ref` into its `$defs` body and drops the `$defs` block. Preserve descriptions and required-field lists. Gate behind a flag if we want to keep the `$defs` form available for clients that do resolve refs.\n\n**Acceptance**\n\n- All 57 tools' `inputSchema` survive the transform with no lost semantics\n- A new `tests/test_mcp_schema_drift.py` test asserts no `$ref` strings appear in any generated schema\n- MCP Inspector + the `@adcp/client` storyboard runner both still accept the output\n\n**Priority**\n\n4.1 follow-up. Current state is spec-valid; this is strictly DX for clients that take the inline path.\n\nSurfaced from: https://github.com/adcontextprotocol/adcp-client-python/pull/205","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-20T02:20:44Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/208"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:989b86b8-0aef-a685-5a36-ead770e2f4b6
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE3F6:16EED3:ABF7D0:DBC399:6B00F698
html-safe-noncecf8803cede78c33eaafab72e71d7eb2f61d1d17cb50ae66d06c5f8e8711b6626
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0Y2OjE2RUVEMzpBQkY3RDA6REJDMzk5OjZCMDBGNjk4IiwidmlzaXRvcl9pZCI6IjU2Nzc1Mjk5NjYzMDA5NTIyMTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6f7069cc6f82afe0c9d12fd5d5a27dc5c48ab29436b60837093e437ca9dd7f48
hovercard-subject-tagissue:4292720603
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/208/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c4abd9cd37b8b8a8d2821988be48b1ca921409cbbd9aa4af31fc6f700e6fc6b3/adcontextprotocol/adcp-client-python/issues/208
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c4abd9cd37b8b8a8d2821988be48b1ca921409cbbd9aa4af31fc6f700e6fc6b3/adcontextprotocol/adcp-client-python/issues/208
og:image:altContext As of PR #205, all 57 MCP tools auto-generate their inputSchema from Pydantic request models via _generate_pydantic_schemas() at src/adcp/server/mcp_tools.py:915. Pydantic emits $defs + $re...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/208#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F208
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F208
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/208
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/208
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/208
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/208
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/208
#177https://github.com/adcontextprotocol/adcp-client-python/pull/177
#244https://github.com/adcontextprotocol/adcp-client-python/pull/244
mcp: inline $defs in generated inputSchema for simpler clientshttps://github.com/adcontextprotocol/adcp-client-python/issues/208#top
#177https://github.com/adcontextprotocol/adcp-client-python/pull/177
#244https://github.com/adcontextprotocol/adcp-client-python/pull/244
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/208#issue-4292720603
#205https://github.com/adcontextprotocol/adcp-client-python/pull/205
#205https://github.com/adcontextprotocol/adcp-client-python/pull/205
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#244https://github.com/adcontextprotocol/adcp-client-python/pull/244
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/208#event-24691031426
bokelleyhttps://github.com/bokelley
on Apr 20, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/208#event-24691031429
Merge pull request #244 from adcontextprotocol/bokelley/mcp-schema-in…https://github.com/adcontextprotocol/adcp-client-python/commit/ffa58e594130d400e3f300edead1ea04cb0361ca
#244https://github.com/adcontextprotocol/adcp-client-python/pull/244
https://docs.github.com/articles/closing-issues-via-commit-messages
ffa58e5https://github.com/adcontextprotocol/adcp-client-python/commit/ffa58e594130d400e3f300edead1ea04cb0361ca
KonstantinMirinhttps://github.com/KonstantinMirin
on May 13, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/208#event-25486654635
feat(mcp): inline \$defs in generated inputSchema (closes adcontextpr…https://github.com/KonstantinMirin/adcp-client-python/commit/8eaeb4d085d7fd3f5268a818d11e339eda950b26
adcontextpr…https://github.com/adcontextprotocol/adcp-client-python/issues/208
https://docs.github.com/articles/closing-issues-via-commit-messages
8eaeb4dhttps://github.com/KonstantinMirin/adcp-client-python/commit/8eaeb4d085d7fd3f5268a818d11e339eda950b26
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/208
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/208
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.