Title: MCP schema materialization removes nested properties named description · Issue #1900 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: MCP schema materialization removes nested properties named description · Issue #1900 · adcontextprotocol/adcp-client-python
X Title: MCP schema materialization removes nested properties named description · Issue #1900 · adcontextprotocol/adcp-client-python
Description: In adcp Python 9.6.1, MCP schema materialization drops a nested property whose name is description, and leaves its object closed with additionalProperties: false. A valid response then fails MCP client validation. Repro from adcp.validat...
Open Graph Description: In adcp Python 9.6.1, MCP schema materialization drops a nested property whose name is description, and leaves its object closed with additionalProperties: false. A valid response then fails MCP cl...
X Description: In adcp Python 9.6.1, MCP schema materialization drops a nested property whose name is description, and leaves its object closed with additionalProperties: false. A valid response then fails MCP cl...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/1900
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"MCP schema materialization removes nested properties named description","articleBody":"In adcp Python 9.6.1, MCP schema materialization drops a nested property whose name is `description`, and leaves its object closed with `additionalProperties: false`. A valid response then fails MCP client validation.\n\n## Repro\n\n```python\nfrom adcp.validation import get_mcp_schema # import path as in 9.6.1\n\nschema = get_mcp_schema(\"list_products\", \"sync\", version=\"3.2\")\nprops = schema[\"$defs\"][\"external:core/canonical-product.json\"][\"properties\"]\nassert \"description\" in props # fails\n```\n\nThe bundled `_schemas/3.2/core/canonical-product.json` has `properties.description: {type: string}`.\n\nEnd to end: a seller's `list_products` response with `products[0].description` fails MCP client output validation with `Additional properties are not allowed ('description' was unexpected)`. `adcp.validation.validate_response(..., version=\"3.2\")` accepts the same response.\n\n## Expected\n\nAnnotation stripping keeps a property literally named `description`, with its schema, in every nested `properties` map, and the object stays closed.\n\n## Cause\n\nIn `adcp/validation/schema_loader.py`, lines 1191–1230, `_strip_schema_annotations` treats the keys of a nested `properties` map as annotation keywords when `preserve_direct_properties=False`, so `description` is removed. Materialization calls it before the compact transform, so both the compact and the defs schema modes are affected.\n\n## Impact\n\nAny MCP-served tool whose output objects carry a `description` property and are closed has the same problem. We hit it implementing `list_products` for the compact lifecycle, and are working around it locally for that one tool.\n","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-11-13T17:48:20Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/1900"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:db8a6384-a30f-39bd-151b-c2e07985eb83 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 90A6:2E3FEE:603E49:7BA02B:6B00DD9E |
| html-safe-nonce | eec73f77e9187a97f57665155e402408df27d08750a3038781fc0356a89c62d0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEE2OjJFM0ZFRTo2MDNFNDk6N0JBMDJCOjZCMDBERDlFIiwidmlzaXRvcl9pZCI6IjMyNzg3NDc0MjEwMzQ3MzI5NTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0f15c78f18c3a2ef0664212bcca648d3c90bb9da3b2989b3d1236e98c661185a |
| hovercard-subject-tag | issue:6376881770 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/1900/issue_layout |
| twitter:image | https://opengraph.githubassets.com/8c9f27d2ca56fcb0c2ffd23c94f0f2a0aa16c36e1e300deb3bd4566ae82250e9/adcontextprotocol/adcp-client-python/issues/1900 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8c9f27d2ca56fcb0c2ffd23c94f0f2a0aa16c36e1e300deb3bd4566ae82250e9/adcontextprotocol/adcp-client-python/issues/1900 |
| og:image:alt | In adcp Python 9.6.1, MCP schema materialization drops a nested property whose name is description, and leaves its object closed with additionalProperties: false. A valid response then fails MCP cl... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width