Title: Signing: rename _canonical.py etc. to match sibling-package convention · Issue #189 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: Signing: rename _canonical.py etc. to match sibling-package convention · Issue #189 · adcontextprotocol/adcp-client-python
X Title: Signing: rename _canonical.py etc. to match sibling-package convention · Issue #189 · adcontextprotocol/adcp-client-python
Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.
Open Graph Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.
X Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Signing: rename _canonical.py etc. to match sibling-package convention","articleBody":"Follow-up from the expert review of #183.\n\n## Problem\n\nThe signing module uses underscore-prefixed module names (\\`_canonical.py\\`, \\`_crypto.py\\`, \\`_digest.py\\`, \\`_errors.py\\`, \\`_jwks.py\\`, \\`_middleware.py\\`, \\`_replay.py\\`, \\`_revocation.py\\`, \\`_signer.py\\`, \\`_verifier.py\\`). This doesn't match the rest of the repo's convention:\n\n- \\`adcp/server/\\` uses \\`test_controller.py\\`, \\`responses.py\\`, etc. — plain names.\n- \\`adcp/protocols/\\` uses \\`base.py\\`, \\`a2a.py\\`, \\`mcp.py\\` — plain names.\n- \\`adcp/utils/\\` same.\n- \\`adcp/testing/\\` same.\n\nThe only precedent for \\`_\\`-prefixed modules in the repo is \\`adcp/types/\\`, and that's explicitly documented in CLAUDE.md as a layering policy for *auto-generated* schema types — not a general 'internal module' convention.\n\nTests also import from \\`adcp.signing._canonical\\`, \\`adcp.signing._crypto\\`, \\`adcp.signing._replay\\` directly — if a test needs it, the module arguably isn't private.\n\n## Fix\n\nRename:\n- \\`_canonical.py\\` → \\`canonical.py\\`\n- \\`_crypto.py\\` → \\`crypto.py\\`\n- \\`_digest.py\\` → \\`digest.py\\`\n- \\`_errors.py\\` → \\`errors.py\\`\n- \\`_jwks.py\\` → \\`jwks.py\\`\n- \\`_middleware.py\\` → \\`middleware.py\\`\n- \\`_replay.py\\` → \\`replay.py\\`\n- \\`_revocation.py\\` → \\`revocation.py\\`\n- \\`_signer.py\\` → \\`signer.py\\`\n- \\`_verifier.py\\` → \\`verifier.py\\`\n\nUpdate imports across src and tests. Keep the \\`__init__.py\\` re-export layer.\n\n## Why this wasn't done in #183\n\nThe rename touches ~30 import statements across 12 source files and 7 test files. Bundled with the security/correctness fixes from the expert review it would've made the PR much harder to review. Doing it as a standalone PR lets the diff speak for itself.","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-18T21:47:32Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/189"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/issues/:id(.:format) |
| route-controller | issues |
| route-action | show |
| fetch-nonce | v2:a25657d5-2eca-fb7f-bcf1-da5b4e6690a2 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DDF0:96DDF:CFB37E:1082549:6B00FEB8 |
| html-safe-nonce | 5d1df96c1f9edac120ed22c8c809222d938f875ce883120b36518a5e7649b178 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREYwOjk2RERGOkNGQjM3RToxMDgyNTQ5OjZCMDBGRUI4IiwidmlzaXRvcl9pZCI6IjMzMzcyNzIxODMwMDgzMjk0MDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | cf289b03236bfa8acf6cf4e780169f23714c60df54c7607b5e7a3ab7239e7fe8 |
| hovercard-subject-tag | repository:1090305973 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/adcontextprotocol/adcp-client-python/issues/189 |
| twitter:image | https://opengraph.githubassets.com/ad855be62f09a05c0db141a47c0256e3d9cc590ab5a26754e07365c6cd487083/adcontextprotocol/adcp-client-python |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ad855be62f09a05c0db141a47c0256e3d9cc590ab5a26754e07365c6cd487083/adcontextprotocol/adcp-client-python |
| og:image:alt | A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width