René's URL Explorer Experiment


Title: Signing: rename _canonical.py etc. to match sibling-package convention · Issue #189 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: Signing: rename _canonical.py etc. to match sibling-package convention · Issue #189 · adcontextprotocol/adcp-client-python

X Title: Signing: rename _canonical.py etc. to match sibling-package convention · Issue #189 · adcontextprotocol/adcp-client-python

Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

Open Graph Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

X Description: A python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Signing: rename _canonical.py etc. to match sibling-package convention","articleBody":"Follow-up from the expert review of #183.\n\n## Problem\n\nThe signing module uses underscore-prefixed module names (\\`_canonical.py\\`, \\`_crypto.py\\`, \\`_digest.py\\`, \\`_errors.py\\`, \\`_jwks.py\\`, \\`_middleware.py\\`, \\`_replay.py\\`, \\`_revocation.py\\`, \\`_signer.py\\`, \\`_verifier.py\\`). This doesn't match the rest of the repo's convention:\n\n- \\`adcp/server/\\` uses \\`test_controller.py\\`, \\`responses.py\\`, etc. — plain names.\n- \\`adcp/protocols/\\` uses \\`base.py\\`, \\`a2a.py\\`, \\`mcp.py\\` — plain names.\n- \\`adcp/utils/\\` same.\n- \\`adcp/testing/\\` same.\n\nThe only precedent for \\`_\\`-prefixed modules in the repo is \\`adcp/types/\\`, and that's explicitly documented in CLAUDE.md as a layering policy for *auto-generated* schema types — not a general 'internal module' convention.\n\nTests also import from \\`adcp.signing._canonical\\`, \\`adcp.signing._crypto\\`, \\`adcp.signing._replay\\` directly — if a test needs it, the module arguably isn't private.\n\n## Fix\n\nRename:\n- \\`_canonical.py\\` → \\`canonical.py\\`\n- \\`_crypto.py\\` → \\`crypto.py\\`\n- \\`_digest.py\\` → \\`digest.py\\`\n- \\`_errors.py\\` → \\`errors.py\\`\n- \\`_jwks.py\\` → \\`jwks.py\\`\n- \\`_middleware.py\\` → \\`middleware.py\\`\n- \\`_replay.py\\` → \\`replay.py\\`\n- \\`_revocation.py\\` → \\`revocation.py\\`\n- \\`_signer.py\\` → \\`signer.py\\`\n- \\`_verifier.py\\` → \\`verifier.py\\`\n\nUpdate imports across src and tests. Keep the \\`__init__.py\\` re-export layer.\n\n## Why this wasn't done in #183\n\nThe rename touches ~30 import statements across 12 source files and 7 test files. Bundled with the security/correctness fixes from the expert review it would've made the PR much harder to review. Doing it as a standalone PR lets the diff speak for itself.","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-18T21:47:32Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/189"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/issues/:id(.:format)
route-controllerissues
route-actionshow
fetch-noncev2:a25657d5-2eca-fb7f-bcf1-da5b4e6690a2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDDF0:96DDF:CFB37E:1082549:6B00FEB8
html-safe-nonce5d1df96c1f9edac120ed22c8c809222d938f875ce883120b36518a5e7649b178
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREYwOjk2RERGOkNGQjM3RToxMDgyNTQ5OjZCMDBGRUI4IiwidmlzaXRvcl9pZCI6IjMzMzcyNzIxODMwMDgzMjk0MDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccf289b03236bfa8acf6cf4e780169f23714c60df54c7607b5e7a3ab7239e7fe8
hovercard-subject-tagrepository:1090305973
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///issues/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/adcontextprotocol/adcp-client-python/issues/189
twitter:imagehttps://opengraph.githubassets.com/ad855be62f09a05c0db141a47c0256e3d9cc590ab5a26754e07365c6cd487083/adcontextprotocol/adcp-client-python
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ad855be62f09a05c0db141a47c0256e3d9cc590ab5a26754e07365c6cd487083/adcontextprotocol/adcp-client-python
og:image:altA python library to interact with adcp servers. Contribute to adcontextprotocol/adcp-client-python development by creating an account on GitHub.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/189#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F189
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F189
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fissues%2Fshow&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/189
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/189
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/189
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/189
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/189
#198https://github.com/adcontextprotocol/adcp-client-python/pull/198
Signing: rename _canonical.py etc. to match sibling-package conventionhttps://github.com/adcontextprotocol/adcp-client-python/issues/189#top
#198https://github.com/adcontextprotocol/adcp-client-python/pull/198
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 18, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/189#issue-4289260469
#183https://github.com/adcontextprotocol/adcp-client-python/issues/183
#183https://github.com/adcontextprotocol/adcp-client-python/issues/183
bokelleyhttps://github.com/bokelley
on Apr 18, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/189#event-24643110594
feat: implement AdCP RFC 9421 request-signing profilehttps://github.com/adcontextprotocol/adcp-client-python/commit/e73c37c80c4db5de8b314f3ff6811fe81d513096
e73c37chttps://github.com/adcontextprotocol/adcp-client-python/commit/e73c37c80c4db5de8b314f3ff6811fe81d513096
feat: implement AdCP RFC 9421 request-signing profilehttps://github.com/adcontextprotocol/adcp-client-python/commit/fc995e9f084aecc910dc279d9d7b0bc64fe7737d
fc995e9https://github.com/adcontextprotocol/adcp-client-python/commit/fc995e9f084aecc910dc279d9d7b0bc64fe7737d
refactor(signing): drop underscore prefix from internal module nameshttps://github.com/adcontextprotocol/adcp-client-python/commit/ae5cf6532275ece3e9d88bd3672f9bf332f8ef28
ae5cf65https://github.com/adcontextprotocol/adcp-client-python/commit/ae5cf6532275ece3e9d88bd3672f9bf332f8ef28
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#198https://github.com/adcontextprotocol/adcp-client-python/pull/198
on Apr 19, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/189#event-24648925900
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/189
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/189
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.