Title: Signing: thread auto-sign through AdcpClient protocol adapters · Issue #186 · adcontextprotocol/adcp-client-python · GitHub
Open Graph Title: Signing: thread auto-sign through AdcpClient protocol adapters · Issue #186 · adcontextprotocol/adcp-client-python
X Title: Signing: thread auto-sign through AdcpClient protocol adapters · Issue #186 · adcontextprotocol/adcp-client-python
Description: Follow-up to #183 (RFC 9421 request signing). The primitive adcp.signing.sign_request(...) is in place and conformant, but AdcpClient / ADCPMultiAgentClient do not yet auto-sign outgoing requests. What's missing The issue #183 deliverabl...
Open Graph Description: Follow-up to #183 (RFC 9421 request signing). The primitive adcp.signing.sign_request(...) is in place and conformant, but AdcpClient / ADCPMultiAgentClient do not yet auto-sign outgoing requests. ...
X Description: Follow-up to #183 (RFC 9421 request signing). The primitive adcp.signing.sign_request(...) is in place and conformant, but AdcpClient / ADCPMultiAgentClient do not yet auto-sign outgoing requests. ...
Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/186
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Signing: thread auto-sign through AdcpClient protocol adapters","articleBody":"Follow-up to #183 (RFC 9421 request signing). The primitive `adcp.signing.sign_request(...)` is in place and conformant, but `AdcpClient` / `ADCPMultiAgentClient` do not yet auto-sign outgoing requests.\n\n## What's missing\n\nThe issue #183 deliverable describes:\n> \\`AdcpClient(signing_key=..., agent_url=...)\\` — optional keyword-only params. \\`signing_key\\` is a \\`cryptography.hazmat.primitives.asymmetric.ed25519.Ed25519PrivateKey\\` or \\`EllipticCurvePrivateKey\\` (P-256).\n> On every outgoing request to operations in the seller's advertised \\`request_signing.required_for\\` or \\`supported_for\\`, compute the canonical signature base [...] and attach \\`Signature\\`, \\`Signature-Input\\`, and (when covered) \\`Content-Digest\\` headers.\n\nRight now callers have to call \\`sign_request\\` themselves and attach headers manually. Integration needs to:\n\n1. Accept signing config on \\`AdcpClient\\`/\\`ADCPMultiAgentClient\\` constructors.\n2. Resolve the counterparty's \\`request_signing\\` capability block (from \\`get_adcp_capabilities\\`) and decide whether to sign based on \\`required_for\\` / \\`supported_for\\`.\n3. Inject \\`sign_request\\` at the right point in the A2A and MCP protocol adapters (\\`src/adcp/protocols/\\`).\n4. Honor \\`covers_content_digest\\` tri-state: \\`required\\` → attach \\`Content-Digest\\` and cover it, \\`forbidden\\` → do not cover, \\`either\\` → signer's choice.\n\n## Why separate\n\nKeeping this as a follow-up because:\n- Protocol-adapter changes touch transport glue and deserve focused review.\n- Capability-driven sign/not-sign logic needs tests against real seller advertisements.\n- The primitive being stable means the integration can happen incrementally without breaking the conformance suite.\n\n## Out of scope here\n\n- Signer key storage/rotation (separate operational concern)\n- Dynamic JWKS discovery from \\`brand.json\\` (already covered by \\`CachingJwksResolver\\` on the verifier side; buyer-side discovery is a separate deliverable)","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-18T21:29:49Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/186"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:0fad0847-653f-22e0-d48c-36b754f67ece |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D388:785A9:C9D63B:100AC34:6B00FF2B |
| html-safe-nonce | 22e1f5a625661fb2c31b5a48ce46df7a4479ea402ce3e74576d30d90db73cead |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzg4Ojc4NUE5OkM5RDYzQjoxMDBBQzM0OjZCMDBGRjJCIiwidmlzaXRvcl9pZCI6IjYxMTI0MzAyNTg2ODA1NjE0NTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4bd79d7311c7f2de6901c1e15615e6775ca1d89aa66d38d6a24bf9075c5b75cc |
| hovercard-subject-tag | issue:4289224794 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/186/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9f73b7ae6969303010da2c1838f3a7f6c6d342b92e4878111172e603a478b15d/adcontextprotocol/adcp-client-python/issues/186 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9f73b7ae6969303010da2c1838f3a7f6c6d342b92e4878111172e603a478b15d/adcontextprotocol/adcp-client-python/issues/186 |
| og:image:alt | Follow-up to #183 (RFC 9421 request signing). The primitive adcp.signing.sign_request(...) is in place and conformant, but AdcpClient / ADCPMultiAgentClient do not yet auto-sign outgoing requests. ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bokelley |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git |
| octolytics-dimension-user_id | 221690821 |
| octolytics-dimension-user_login | adcontextprotocol |
| octolytics-dimension-repository_id | 1090305973 |
| octolytics-dimension-repository_nwo | adcontextprotocol/adcp-client-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1090305973 |
| octolytics-dimension-repository_network_root_nwo | adcontextprotocol/adcp-client-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width