René's URL Explorer Experiment


Title: Signing: thread auto-sign through AdcpClient protocol adapters · Issue #186 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: Signing: thread auto-sign through AdcpClient protocol adapters · Issue #186 · adcontextprotocol/adcp-client-python

X Title: Signing: thread auto-sign through AdcpClient protocol adapters · Issue #186 · adcontextprotocol/adcp-client-python

Description: Follow-up to #183 (RFC 9421 request signing). The primitive adcp.signing.sign_request(...) is in place and conformant, but AdcpClient / ADCPMultiAgentClient do not yet auto-sign outgoing requests. What's missing The issue #183 deliverabl...

Open Graph Description: Follow-up to #183 (RFC 9421 request signing). The primitive adcp.signing.sign_request(...) is in place and conformant, but AdcpClient / ADCPMultiAgentClient do not yet auto-sign outgoing requests. ...

X Description: Follow-up to #183 (RFC 9421 request signing). The primitive adcp.signing.sign_request(...) is in place and conformant, but AdcpClient / ADCPMultiAgentClient do not yet auto-sign outgoing requests. ...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/186

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Signing: thread auto-sign through AdcpClient protocol adapters","articleBody":"Follow-up to #183 (RFC 9421 request signing). The primitive `adcp.signing.sign_request(...)` is in place and conformant, but `AdcpClient` / `ADCPMultiAgentClient` do not yet auto-sign outgoing requests.\n\n## What's missing\n\nThe issue #183 deliverable describes:\n> \\`AdcpClient(signing_key=..., agent_url=...)\\` — optional keyword-only params. \\`signing_key\\` is a \\`cryptography.hazmat.primitives.asymmetric.ed25519.Ed25519PrivateKey\\` or \\`EllipticCurvePrivateKey\\` (P-256).\n> On every outgoing request to operations in the seller's advertised \\`request_signing.required_for\\` or \\`supported_for\\`, compute the canonical signature base [...] and attach \\`Signature\\`, \\`Signature-Input\\`, and (when covered) \\`Content-Digest\\` headers.\n\nRight now callers have to call \\`sign_request\\` themselves and attach headers manually. Integration needs to:\n\n1. Accept signing config on \\`AdcpClient\\`/\\`ADCPMultiAgentClient\\` constructors.\n2. Resolve the counterparty's \\`request_signing\\` capability block (from \\`get_adcp_capabilities\\`) and decide whether to sign based on \\`required_for\\` / \\`supported_for\\`.\n3. Inject \\`sign_request\\` at the right point in the A2A and MCP protocol adapters (\\`src/adcp/protocols/\\`).\n4. Honor \\`covers_content_digest\\` tri-state: \\`required\\` → attach \\`Content-Digest\\` and cover it, \\`forbidden\\` → do not cover, \\`either\\` → signer's choice.\n\n## Why separate\n\nKeeping this as a follow-up because:\n- Protocol-adapter changes touch transport glue and deserve focused review.\n- Capability-driven sign/not-sign logic needs tests against real seller advertisements.\n- The primitive being stable means the integration can happen incrementally without breaking the conformance suite.\n\n## Out of scope here\n\n- Signer key storage/rotation (separate operational concern)\n- Dynamic JWKS discovery from \\`brand.json\\` (already covered by \\`CachingJwksResolver\\` on the verifier side; buyer-side discovery is a separate deliverable)","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-18T21:29:49Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/186"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:0fad0847-653f-22e0-d48c-36b754f67ece
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD388:785A9:C9D63B:100AC34:6B00FF2B
html-safe-nonce22e1f5a625661fb2c31b5a48ce46df7a4479ea402ce3e74576d30d90db73cead
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzg4Ojc4NUE5OkM5RDYzQjoxMDBBQzM0OjZCMDBGRjJCIiwidmlzaXRvcl9pZCI6IjYxMTI0MzAyNTg2ODA1NjE0NTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4bd79d7311c7f2de6901c1e15615e6775ca1d89aa66d38d6a24bf9075c5b75cc
hovercard-subject-tagissue:4289224794
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/186/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9f73b7ae6969303010da2c1838f3a7f6c6d342b92e4878111172e603a478b15d/adcontextprotocol/adcp-client-python/issues/186
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9f73b7ae6969303010da2c1838f3a7f6c6d342b92e4878111172e603a478b15d/adcontextprotocol/adcp-client-python/issues/186
og:image:altFollow-up to #183 (RFC 9421 request signing). The primitive adcp.signing.sign_request(...) is in place and conformant, but AdcpClient / ADCPMultiAgentClient do not yet auto-sign outgoing requests. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/186#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F186
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F186
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/186
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/186
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/186
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/186
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/186
#200https://github.com/adcontextprotocol/adcp-client-python/pull/200
Signing: thread auto-sign through AdcpClient protocol adaptershttps://github.com/adcontextprotocol/adcp-client-python/issues/186#top
#200https://github.com/adcontextprotocol/adcp-client-python/pull/200
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 18, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/186#issue-4289224794
#183https://github.com/adcontextprotocol/adcp-client-python/issues/183
#183https://github.com/adcontextprotocol/adcp-client-python/issues/183
bokelleyhttps://github.com/bokelley
on Apr 18, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/186#event-24643110541
feat: implement AdCP RFC 9421 request-signing profilehttps://github.com/adcontextprotocol/adcp-client-python/commit/e73c37c80c4db5de8b314f3ff6811fe81d513096
e73c37chttps://github.com/adcontextprotocol/adcp-client-python/commit/e73c37c80c4db5de8b314f3ff6811fe81d513096
feat: implement AdCP RFC 9421 request-signing profilehttps://github.com/adcontextprotocol/adcp-client-python/commit/fc995e9f084aecc910dc279d9d7b0bc64fe7737d
fc995e9https://github.com/adcontextprotocol/adcp-client-python/commit/fc995e9f084aecc910dc279d9d7b0bc64fe7737d
feat(signing): auto-sign outgoing requests via ADCPClient signing kwarghttps://github.com/adcontextprotocol/adcp-client-python/commit/c07c946ff50cdd3ef32db263877ed6aada40e964
c07c946https://github.com/adcontextprotocol/adcp-client-python/commit/c07c946ff50cdd3ef32db263877ed6aada40e964
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#200https://github.com/adcontextprotocol/adcp-client-python/pull/200
on Apr 19, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/186#event-24649575542
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/186
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/186
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.