René's URL Explorer Experiment


Title: Implement RFC 9421 request signing (AdCP 3.0 optional profile) · Issue #183 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: Implement RFC 9421 request signing (AdCP 3.0 optional profile) · Issue #183 · adcontextprotocol/adcp-client-python

X Title: Implement RFC 9421 request signing (AdCP 3.0 optional profile) · Issue #183 · adcontextprotocol/adcp-client-python

Description: Paired SDK work for the AdCP RFC 9421 request-signing profile in adcp#2323 (3.0 optional, 4.0 required — tracked in adcp#2307). Scope Implement client signing and server verification for outgoing/incoming AdCP requests per the Signed Req...

Open Graph Description: Paired SDK work for the AdCP RFC 9421 request-signing profile in adcp#2323 (3.0 optional, 4.0 required — tracked in adcp#2307). Scope Implement client signing and server verification for outgoing/i...

X Description: Paired SDK work for the AdCP RFC 9421 request-signing profile in adcp#2323 (3.0 optional, 4.0 required — tracked in adcp#2307). Scope Implement client signing and server verification for outgoing/i...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/183

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Implement RFC 9421 request signing (AdCP 3.0 optional profile)","articleBody":"Paired SDK work for the AdCP RFC 9421 request-signing profile in adcp#2323 (3.0 optional, 4.0 required — tracked in adcp#2307).\n\n## Scope\n\nImplement client signing and server verification for outgoing/incoming AdCP requests per the [Signed Requests (Transport Layer)](https://adcontextprotocol.org/docs/building/implementation/security#signed-requests-transport-layer) profile. Conforms against the test vectors shipped in the spec repo at `static/test-vectors/request-signing/`.\n\n## Deliverables\n\n### Client-side (signer)\n\n- `AdcpClient(signing_key=..., agent_url=...)` — optional keyword-only params. `signing_key` is a `cryptography.hazmat.primitives.asymmetric.ed25519.Ed25519PrivateKey` or `EllipticCurvePrivateKey` (P-256).\n- On every outgoing request to operations in the seller's advertised `request_signing.required_for` or `supported_for`, compute the canonical signature base per RFC 9421 §2.5 with the covered components mandated by the AdCP profile:\n  - Always: `@method`, `@target-uri`, `@authority`\n  - With body: `content-type`\n  - With body AND seller advertises `covers_content_digest: \"required\"`: `content-digest` (RFC 9530, sha-256)\n  - If seller advertises `covers_content_digest: \"forbidden\"`, signer MUST NOT cover `content-digest`.\n- Attach `Signature`, `Signature-Input`, and (when covered) `Content-Digest` headers.\n- Sign with Ed25519 (default via `cryptography`) or ES256 (P-256 ECDSA). For ES256, encode r||s per RFC 9421 §3.3.2 — NOT DER. `cryptography`'s default is DER; convert.\n- Honor the profile's sig-params: `created`, `expires` (≤ `created + 300`), `nonce` (≥ 128 bits, base64url), `keyid` (matches a JWK `kid` in the signer's published JWKS), `alg` (`ed25519` or `ecdsa-p256-sha256`), `tag` (exactly `adcp/request-signing/v1`).\n- CLI helper: `python -m adcp.generate_signing_key [--alg ed25519|es256]` → writes PEM + prints JWK with `adcp_use: \"request-signing\"` for publication at `jwks_uri`.\n\n### Server-side (verifier)\n\n- `adcp.signing` module: middleware for Flask, FastAPI, Starlette.\n- Signature: `def verify_request_signature(request, *, options: VerifyOptions) -> VerifiedSigner`.\n- Implement the 13-step verifier checklist + pre-check from the spec:\n  0. Pre-check: reject unsigned request to operation in `required_for` with `request_signature_required`. Reject if `Signature` present without `Signature-Input` (or vice versa) — the downgrade loophole vector 019 catches this.\n  1. Parse `Signature-Input` / `Signature`\n  2. Params presence (all 6 required)\n  3. Tag check (`adcp/request-signing/v1`)\n  4. Alg allowlist\n  5. Window (including `expires > created`, ±60s skew, ≤ 300s max)\n  6. Covered components (considering `covers_content_digest` policy: `required` / `forbidden` / `either`)\n  7. Resolve `keyid` → JWKS → agent entry (with SSRF validation per AdCP webhook SSRF rules and 30-second JWKS refetch cooldown BETWEEN refetches)\n  8. Check `use: \"sig\"`, `key_ops` contains `verify`, `adcp_use == \"request-signing\"` (note: strip `adcp_use` before feeding the JWK to strict consumers like PyJWT's strict modes — retain for policy check)\n  9. Revocation check (BEFORE crypto verify to avoid cheap amplification)\n  10. Cryptographic verification of the signature base\n  11. Recompute and compare `content-digest` when covered\n  12. Replay dedup on `(keyid, nonce)`\n  13. Insert into replay cache only after all prior steps pass\n- Pluggable JWKS cache + SSRF-validated fetcher. Recommend `httpx` with a custom transport that validates the resolved IP against reserved ranges before connecting.\n- Pluggable replay store (in-memory `cachetools.TTLCache` default; Redis adapter via `redis-py` for multi-instance).\n- Return `VerifiedSigner(key_id=..., agent_url=..., verified_at=...)` for downstream authorization.\n- Emit typed errors matching the spec error taxonomy:\n  - `request_signature_required`\n  - `request_signature_header_malformed`\n  - `request_signature_params_incomplete`\n  - `request_signature_tag_invalid`\n  - `request_signature_alg_not_allowed`\n  - `request_signature_window_invalid`\n  - `request_signature_components_incomplete`\n  - `request_signature_components_unexpected`\n  - `request_signature_key_unknown`\n  - `request_signature_key_purpose_invalid`\n  - `request_signature_invalid`\n  - `request_signature_digest_mismatch`\n  - `request_signature_replayed`\n  - `request_signature_key_revoked`\n  - `request_signature_revocation_stale`\n  - `request_signature_jwks_unavailable`\n  - `request_signature_jwks_untrusted`\n- Return 401 with `WWW-Authenticate: Signature error=\"\u003ccode>\"` on rejection. Realm MUST be omitted per spec.\n- Respect the \"one Signature-Input label per request\" rule — verify `sig1` and ignore additional labels.\n\n### Conformance tests\n\n- Consume the test vectors shipped in the spec repo under `static/test-vectors/request-signing/`:\n  - 19 **negative** vectors — the verifier MUST return `expected_outcome.error_code` exactly. `failed_step` is informational.\n  - 3 **positive** vectors — the verifier MUST accept. Ed25519 signatures are byte-exact reproducible (determinism); ES256 is verify-only (random-k is conformant for verify).\n- Run order per the README's \"Recommended run order\" section: positives first, then parse-level negatives, then semantic, then key-path, then crypto/stateful.\n- Add end-to-end test: spin up FastAPI with `verify_request_signature`, point an `AdcpClient` at it with `signing_key`, drive a `create_media_buy`. Exercise `covers_content_digest: \"either\"` and `\"required\"`.\n\n### Docs\n\n- README section on \"Signing in 3.0\" — how to opt in as a buyer or a seller.\n- Python examples in the AdCP quickstart showing the 5-line integration.\n\n## Library recommendations\n\n- **RFC 9421 canonicalization + verification**: [`http-message-signatures`](https://pypi.org/project/http-message-signatures/) (PyPI) is the most mature Python implementation. Validate its output against the `expected_signature_base` in each positive vector — the library supports pluggable covered-component selection and sig-params, so configuring it for the AdCP profile is straightforward.\n- **JWK / JWKS**: [`python-jose`](https://pypi.org/project/python-jose/) or [`cryptography`](https://pypi.org/project/cryptography/) directly. `python-jose` preserves unknown JWK members (`adcp_use`) on parse. `cryptography`'s JWK handling is stricter; may need to strip `adcp_use` before conversion.\n- **Content-Digest (RFC 9530)**: small custom impl — `hashlib.sha256(body).digest()` then base64-encode per RFC 8941 structured dictionary shape (`sha-256=:\u003cb64>:`).\n- **SSRF-validated fetch**: `httpx.HTTPTransport` with custom `connect` hook, or a socket-level wrapper that validates the resolved IP against reserved ranges per the [Webhook URL validation](https://adcontextprotocol.org/docs/building/implementation/security#webhook-url-validation-ssrf) rules.\n- **Ed25519/ES256**: `cryptography.hazmat.primitives.asymmetric.ed25519` and `.ec`. Note: `cryptography` signs ECDSA with DER by default; you need to convert to IEEE P1363 (r||s) for RFC 9421 — use `cryptography.hazmat.primitives.asymmetric.utils.decode_dss_signature` to get `(r, s)` then big-endian pack.\n\n## Ordering\n\n1. Implement the verifier first — it consumes the conformance vectors directly and validates the spec.\n2. Implement the signer.\n3. End-to-end tests + docs.\n\n## Why this belongs in adcp-client-python\n\nThe spec is language-agnostic; the SDK is what Python implementers actually integrate. Shipping signing support in the SDK is what turns \"the profile is optional in 3.0\" from a theoretical statement into something Python-based counterparties can pilot. Without this, 4.0 required-signing lands on unimplemented libraries.\n\n## References\n\n- Spec PR: https://github.com/adcontextprotocol/adcp/pull/2323\n- v4.0 RFC: https://github.com/adcontextprotocol/adcp/issues/2307\n- TypeScript SDK equivalent: https://github.com/adcontextprotocol/adcp-client/issues/575\n- Go SDK equivalent: https://github.com/adcontextprotocol/adcp-go/issues/43\n- Governance JWS profile (shares JWKS substrate): adcp#2316\n- Follow-up 3.x: `warn_for` capability at adcp#2326; others at adcp#2324, #2325, #2327, #2328","author":{"url":"https://github.com/bokelley","@type":"Person","name":"bokelley"},"datePublished":"2026-04-18T18:48:03Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/183"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2b95836c-6259-03e7-d18d-74f3edbbe8d8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDF0E:296654:BF921F:101D0A3:6B00F8D9
html-safe-nonce20723c9ace1222a52e3fbe478f22190cb2773cef327c3ff25cdb78cd5c38cd69
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjBFOjI5NjY1NDpCRjkyMUY6MTAxRDBBMzo2QjAwRjhEOSIsInZpc2l0b3JfaWQiOiI5MDY0NjQyOTk2NzE2MjM5MDY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac95ac2252d2b2891f90af08a0876c02a1b4a91490607d4704fe7bc4458bd7c23b
hovercard-subject-tagissue:4288881350
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/183/issue_layout
twitter:imagehttps://opengraph.githubassets.com/0ad64fae63d9d83f40bb7779a6b5af643897918bf3a8593baeb2b856ec6670ab/adcontextprotocol/adcp-client-python/issues/183
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0ad64fae63d9d83f40bb7779a6b5af643897918bf3a8593baeb2b856ec6670ab/adcontextprotocol/adcp-client-python/issues/183
og:image:altPaired SDK work for the AdCP RFC 9421 request-signing profile in adcp#2323 (3.0 optional, 4.0 required — tracked in adcp#2307). Scope Implement client signing and server verification for outgoing/i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebokelley
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/183#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F183
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F183
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/183
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/183
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/183
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/183
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/183
#192https://github.com/adcontextprotocol/adcp-client-python/pull/192
Implement RFC 9421 request signing (AdCP 3.0 optional profile)https://github.com/adcontextprotocol/adcp-client-python/issues/183#top
#192https://github.com/adcontextprotocol/adcp-client-python/pull/192
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 18, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/183#issue-4288881350
Signed Requests (Transport Layer)https://adcontextprotocol.org/docs/building/implementation/security#signed-requests-transport-layer
http-message-signatureshttps://pypi.org/project/http-message-signatures/
python-josehttps://pypi.org/project/python-jose/
cryptographyhttps://pypi.org/project/cryptography/
Webhook URL validationhttps://adcontextprotocol.org/docs/building/implementation/security#webhook-url-validation-ssrf
spec(security): RFC 9421 request signing profile (3.0 optional) adcp#2323https://github.com/adcontextprotocol/adcp/pull/2323
Mandatory request signing for mutating calls (RFC 9421 HTTP Signatures or JWS) adcp#2307https://github.com/adcontextprotocol/adcp/issues/2307
Implement RFC 9421 request signing (AdCP 3.0 optional profile) adcp-client#575https://github.com/adcontextprotocol/adcp-client/issues/575
Implement RFC 9421 request signing (AdCP 3.0 optional profile) adcp-go#43https://github.com/adcontextprotocol/adcp-go/issues/43
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 18, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/183#issuecomment-4274367808
https://github.com/bokelley
bokelleyhttps://github.com/bokelley
on Apr 18, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/183#issuecomment-4274400512
adcontextprotocol/adcp#2331https://github.com/adcontextprotocol/adcp/issues/2331
bokelleyhttps://github.com/bokelley
on Apr 18, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/183#event-24643110522
feat: implement AdCP RFC 9421 request-signing profilehttps://github.com/adcontextprotocol/adcp-client-python/commit/e73c37c80c4db5de8b314f3ff6811fe81d513096
https://docs.github.com/articles/closing-issues-via-commit-messages
e73c37chttps://github.com/adcontextprotocol/adcp-client-python/commit/e73c37c80c4db5de8b314f3ff6811fe81d513096
feat: implement AdCP RFC 9421 request-signing profilehttps://github.com/adcontextprotocol/adcp-client-python/commit/fc995e9f084aecc910dc279d9d7b0bc64fe7737d
https://docs.github.com/articles/closing-issues-via-commit-messages
fc995e9https://github.com/adcontextprotocol/adcp-client-python/commit/fc995e9f084aecc910dc279d9d7b0bc64fe7737d
bokelleyhttps://github.com/bokelley
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
fc995e9https://github.com/adcontextprotocol/adcp-client-python/commit/fc995e9f084aecc910dc279d9d7b0bc64fe7737d
on Apr 18, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/183#event-24643354597
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/183
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/183
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.