René's URL Explorer Experiment


Title: Bug: get_adcp_signed_headers_for_webhook signs compact JSON but wire body uses default JSON · Issue #151 · adcontextprotocol/adcp-client-python · GitHub

Open Graph Title: Bug: get_adcp_signed_headers_for_webhook signs compact JSON but wire body uses default JSON · Issue #151 · adcontextprotocol/adcp-client-python

X Title: Bug: get_adcp_signed_headers_for_webhook signs compact JSON but wire body uses default JSON · Issue #151 · adcontextprotocol/adcp-client-python

Description: Summary get_adcp_signed_headers_for_webhook() in src/adcp/webhooks.py computes the HMAC signature over compact JSON (no spaces), but callers send the HTTP body via requests.post(url, json=payload) which uses default JSON (with spaces). R...

Open Graph Description: Summary get_adcp_signed_headers_for_webhook() in src/adcp/webhooks.py computes the HMAC signature over compact JSON (no spaces), but callers send the HTTP body via requests.post(url, json=payload) ...

X Description: Summary get_adcp_signed_headers_for_webhook() in src/adcp/webhooks.py computes the HMAC signature over compact JSON (no spaces), but callers send the HTTP body via requests.post(url, json=payload) ...

Opengraph URL: https://github.com/adcontextprotocol/adcp-client-python/issues/151

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bug: get_adcp_signed_headers_for_webhook signs compact JSON but wire body uses default JSON","articleBody":"## Summary\n\n`get_adcp_signed_headers_for_webhook()` in `src/adcp/webhooks.py` computes the HMAC signature over **compact JSON** (no spaces), but callers send the HTTP body via `requests.post(url, json=payload)` which uses **default JSON** (with spaces). Receivers that verify against raw HTTP body bytes (per the AdCP spec) will always get a signature mismatch.\n\n## Root Cause\n\nIn `get_adcp_signed_headers_for_webhook()`:\n\n```python\npayload_bytes = json.dumps(payload_dict, separators=(\",\", \":\"), sort_keys=False).encode(\"utf-8\")\nsigned_message = f\"{timestamp}.{payload_bytes.decode('utf-8')}\"\n```\n\nThis signs over compact JSON: `{\"contextId\":\"msg_123\",\"final\":false}`\n\nBut the caller sends the body with `requests.post(url, json=payload)`, which internally uses `json.dumps(payload)` with default separators, producing: `{\"contextId\": \"msg_123\", \"final\": false}`\n\nThe receiver verifies `HMAC(secret, \"{timestamp}.{raw_http_body}\")` — since the raw body has spaces but the signature was computed without spaces, they never match.\n\n## Reference Implementation Mismatch\n\nThe official [`@adcp/client` JS library](https://github.com/adcontextprotocol/adcp-client) (the reference implementation) uses `JSON.stringify(payload)` for signing, which produces **default serialization with spaces** — matching what goes on the wire.\n\nFrom the [JS test suite](https://github.com/adcontextprotocol/adcp-client/blob/main/test/webhook-signature-verification.test.js):\n\n```javascript\nconst message = `${timestamp}.${JSON.stringify(payload)}`;\nconst hmac = crypto.createHmac('sha256', webhookSecret);\nhmac.update(message);\nconst signature = `sha256=${hmac.digest('hex')}`;\n```\n\n`JSON.stringify` output: `{\"contextId\": \"msg_123\", \"final\": false}` (with spaces after `:` and `,`)\n\nThe Python client should match this behavior.\n\n## Reproduction\n\n```python\nimport json, hashlib, hmac\n\npayload = {\"contextId\": \"msg_123\", \"final\": False, \"kind\": \"status-update\"}\nsecret = \"my-test-webhook-secret-that-is-32chars!\"\ntimestamp = \"1773185740\"\n\n# What get_adcp_signed_headers_for_webhook signs (compact):\ncompact = json.dumps(payload, separators=(\",\", \":\"), sort_keys=False)\n# '{\"contextId\":\"msg_123\",\"final\":false,\"kind\":\"status-update\"}'\n\n# What requests.post(json=payload) sends on the wire (default):\ndefault = json.dumps(payload)\n# '{\"contextId\": \"msg_123\", \"final\": false, \"kind\": \"status-update\"}'\n\nsig_compact = hmac.new(secret.encode(), f\"{timestamp}.{compact}\".encode(), hashlib.sha256).hexdigest()\nsig_default = hmac.new(secret.encode(), f\"{timestamp}.{default}\".encode(), hashlib.sha256).hexdigest()\n\nprint(f\"Match: {sig_compact == sig_default}\")  # False\n```\n\n## Suggested Fix\n\n```python\n# In get_adcp_signed_headers_for_webhook(), change:\npayload_bytes = json.dumps(payload_dict, separators=(\",\", \":\"), sort_keys=False).encode(\"utf-8\")\n\n# To:\npayload_bytes = json.dumps(payload_dict).encode(\"utf-8\")\n```\n\nThis aligns with the JS reference implementation's `JSON.stringify()` behavior.\n\nAlternatively, the function's docstring could be updated to instruct callers to pre-serialize and send with `data=` instead of `json=`, but that's a larger change for all consumers.\n\n## Impact\n\nAll consumers of `get_adcp_signed_headers_for_webhook()` that use `requests.post(json=...)` or `httpx.post(json=...)` will have webhook HMAC validation failures on the receiver side. This is currently breaking `create_media_buy`, `update_media_buy`, and `sync_creatives` webhook callbacks.","author":{"url":"https://github.com/EmmaLouise2018","@type":"Person","name":"EmmaLouise2018"},"datePublished":"2026-03-11T00:35:26Z","url":"https://github.com/adcontextprotocol/adcp-client-python/issues/151"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:4e3fb4a2-3575-8c49-351d-e7653338a292
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8BA0:1148D3:EF6227:132A233:6B010EBB
html-safe-nonce7b26ba4053662dcdb4d2f2800d7bd493b1927394173630cc861a5522fd71db5a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkEwOjExNDhEMzpFRjYyMjc6MTMyQTIzMzo2QjAxMEVCQiIsInZpc2l0b3JfaWQiOiIzODE0NDE1NjQzNDA3NjE3NzIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5bcd2471c20c13876fe21343fce031ec879cc97c7813fd1c88fdb4c1ca43aca7
hovercard-subject-tagissue:4054978979
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adcontextprotocol/adcp-client-python/151/issue_layout
twitter:imagehttps://opengraph.githubassets.com/41f8e4fdb5ca5097a35659e64bc811a363c030aa45f65962c7127aff330f5235/adcontextprotocol/adcp-client-python/issues/151
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/41f8e4fdb5ca5097a35659e64bc811a363c030aa45f65962c7127aff330f5235/adcontextprotocol/adcp-client-python/issues/151
og:image:altSummary get_adcp_signed_headers_for_webhook() in src/adcp/webhooks.py computes the HMAC signature over compact JSON (no spaces), but callers send the HTTP body via requests.post(url, json=payload) ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameEmmaLouise2018
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/adcontextprotocol/adcp-client-python git https://github.com/adcontextprotocol/adcp-client-python.git
octolytics-dimension-user_id221690821
octolytics-dimension-user_loginadcontextprotocol
octolytics-dimension-repository_id1090305973
octolytics-dimension-repository_nwoadcontextprotocol/adcp-client-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1090305973
octolytics-dimension-repository_network_root_nwoadcontextprotocol/adcp-client-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/adcontextprotocol/adcp-client-python/issues/151#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F151
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fadcontextprotocol%2Fadcp-client-python%2Fissues%2F151
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=adcontextprotocol%2Fadcp-client-python
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/151
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/151
Reloadhttps://github.com/adcontextprotocol/adcp-client-python/issues/151
adcontextprotocolhttps://github.com/adcontextprotocol
adcp-client-pythonhttps://github.com/adcontextprotocol/adcp-client-python
Codehttps://github.com/adcontextprotocol/adcp-client-python
Issues44 (44)https://github.com/adcontextprotocol/adcp-client-python/issues
Pull requests13 (13)https://github.com/adcontextprotocol/adcp-client-python/pulls
Actionshttps://github.com/adcontextprotocol/adcp-client-python/actions
Projectshttps://github.com/adcontextprotocol/adcp-client-python/projects
Security and qualityhttps://github.com/adcontextprotocol/adcp-client-python/security
Insightshttps://github.com/adcontextprotocol/adcp-client-python/insights
https://github.com/adcontextprotocol/adcp-client-python
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/151
New issuehttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/151
#154https://github.com/adcontextprotocol/adcp-client-python/pull/154
#152https://github.com/adcontextprotocol/adcp-client-python/pull/152
Bug: get_adcp_signed_headers_for_webhook signs compact JSON but wire body uses default JSONhttps://github.com/adcontextprotocol/adcp-client-python/issues/151#top
#154https://github.com/adcontextprotocol/adcp-client-python/pull/154
#152https://github.com/adcontextprotocol/adcp-client-python/pull/152
https://github.com/EmmaLouise2018
EmmaLouise2018https://github.com/EmmaLouise2018
on Mar 11, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/151#issue-4054978979
@adcp/client JS libraryhttps://github.com/adcontextprotocol/adcp-client
JS test suitehttps://github.com/adcontextprotocol/adcp-client/blob/main/test/webhook-signature-verification.test.js
https://github.com/EmmaLouise2018
EmmaLouise2018https://github.com/EmmaLouise2018
on Mar 11, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/151#issuecomment-4035461157
https://docs.adcontextprotocol.org/docs/building/implementation/webhooks#hmac-sha256-recommended-for-productionhttps://docs.adcontextprotocol.org/docs/building/implementation/webhooks#hmac-sha256-recommended-for-production
EmmaLouise2018https://github.com/EmmaLouise2018
on Mar 11, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/151#event-23452230155
fix: use default JSON separators for webhook HMAC signinghttps://github.com/adcontextprotocol/adcp-client-python/commit/0dd495fd83c0c0d4df99fe794d878d0f98735cc8
https://docs.github.com/articles/closing-issues-via-commit-messages
0dd495fhttps://github.com/adcontextprotocol/adcp-client-python/commit/0dd495fd83c0c0d4df99fe794d878d0f98735cc8
fix: add raw_body support for verification and use Unix timestampshttps://github.com/adcontextprotocol/adcp-client-python/commit/4a663e5406bbf2ce533842fdd74c749a79f802d1
https://docs.github.com/articles/closing-issues-via-commit-messages
4a663e5https://github.com/adcontextprotocol/adcp-client-python/commit/4a663e5406bbf2ce533842fdd74c749a79f802d1
EmmaLouise2018https://github.com/EmmaLouise2018
completedhttps://github.com/adcontextprotocol/adcp-client-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#152https://github.com/adcontextprotocol/adcp-client-python/pull/152
on Mar 11, 2026https://github.com/adcontextprotocol/adcp-client-python/issues/151#event-23478431283
Sign up for freehttps://github.com/signup?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/151
Sign in to commenthttps://github.com/login?return_to=https://github.com/adcontextprotocol/adcp-client-python/issues/151
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.