Title: Difference with node-http-signature regarding (request-target) · Issue #5 · adamcin/httpsig-java · GitHub
Open Graph Title: Difference with node-http-signature regarding (request-target) · Issue #5 · adamcin/httpsig-java
X Title: Difference with node-http-signature regarding (request-target) · Issue #5 · adamcin/httpsig-java
Description: As it is seen from those lines: https://github.com/joyent/node-http-signature/blob/529441d9d04a8ecb296a2a152929332526344673/lib/signer.js#L331 httpsig-java/api/src/main/java/net/adamcin/httpsig/api/RequestContent.java Line 207 in c1351c8...
Open Graph Description: As it is seen from those lines: https://github.com/joyent/node-http-signature/blob/529441d9d04a8ecb296a2a152929332526344673/lib/signer.js#L331 httpsig-java/api/src/main/java/net/adamcin/httpsig/api...
X Description: As it is seen from those lines: https://github.com/joyent/node-http-signature/blob/529441d9d04a8ecb296a2a152929332526344673/lib/signer.js#L331 httpsig-java/api/src/main/java/net/adamcin/httpsig/api...
Opengraph URL: https://github.com/adamcin/httpsig-java/issues/5
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Difference with node-http-signature regarding (request-target)","articleBody":"As it is seen from those lines:\r\n\r\nhttps://github.com/joyent/node-http-signature/blob/529441d9d04a8ecb296a2a152929332526344673/lib/signer.js#L331\r\n\r\nhttps://github.com/adamcin/httpsig-java/blob/c1351c809340aec422bcb69352e78edbab62aa9d/api/src/main/java/net/adamcin/httpsig/api/RequestContent.java#L207\r\n\r\nThere is a difference between inclusion of request-target in a signing string.\r\nIn joyent implementation they prepend \"(request-target): \" before value.\r\nIn this implementation this is not done.\r\n\r\nI think this problem came from inconsistent spec ( https://github.com/joyent/node-http-signature/blob/529441d9d04a8ecb296a2a152929332526344673/http_signing.md ) which references `request-line` (depreceated) in Signing String Composition, but uses `request-target` in examples (one time missing colon).\r\n\r\nI think it is better to follow joyent implementation to avoid inconsistency.\r\nWhat are your thoughts?","author":{"url":"https://github.com/vonagam","@type":"Person","name":"vonagam"},"datePublished":"2017-03-04T23:20:33.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/5/httpsig-java/issues/5"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6295fd7c-0057-ce1a-00d9-1693784f8df4 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D04A:79348:2056D4E:2C3CC68:6A4EC37F |
| html-safe-nonce | 9b26ff7f4cd2d53d1427e2cca9f0d4877997df8ccacf213dd1c673949b961bfc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDRBOjc5MzQ4OjIwNTZENEU6MkMzQ0M2ODo2QTRFQzM3RiIsInZpc2l0b3JfaWQiOiIzMzEwMjM4NzIyNTMyNzU0MzAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8f3b40c30a7ce195af6113513ad452490f8e6967edf0b94d7fc63e8e8e53c2b6 |
| hovercard-subject-tag | issue:211916014 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/adamcin/httpsig-java/5/issue_layout |
| twitter:image | https://opengraph.githubassets.com/bab37d21c5dccf71b094f7ad9f1b45ee80e5117ab01f1e29c3474a9fc211bfdc/adamcin/httpsig-java/issues/5 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bab37d21c5dccf71b094f7ad9f1b45ee80e5117ab01f1e29c3474a9fc211bfdc/adamcin/httpsig-java/issues/5 |
| og:image:alt | As it is seen from those lines: https://github.com/joyent/node-http-signature/blob/529441d9d04a8ecb296a2a152929332526344673/lib/signer.js#L331 httpsig-java/api/src/main/java/net/adamcin/httpsig/api... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | vonagam |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-preview |
| go-import | github.com/adamcin/httpsig-java git https://github.com/adamcin/httpsig-java.git |
| octolytics-dimension-user_id | 524972 |
| octolytics-dimension-user_login | adamcin |
| octolytics-dimension-repository_id | 14969366 |
| octolytics-dimension-repository_nwo | adamcin/httpsig-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14969366 |
| octolytics-dimension-repository_network_root_nwo | adamcin/httpsig-java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width