Title: dist: Apply Copilot review suggestions from PR #1042 (GraalVM Community) by brunoborges · Pull Request #1059 · actions/setup-java · GitHub
Open Graph Title: dist: Apply Copilot review suggestions from PR #1042 (GraalVM Community) by brunoborges · Pull Request #1059 · actions/setup-java
X Title: dist: Apply Copilot review suggestions from PR #1042 (GraalVM Community) by brunoborges · Pull Request #1059 · actions/setup-java
Description: Description Follow-up to #1042 (now merged) addressing the two suggestions left by the Copilot reviewer that weren't applied before merge. 1. src/distributions/graalvm/installer.ts — surface API errors instead of masking them The GraalVM Community release listing previously treated any non-array JSON result as "no releases" and broke out of pagination. If the GitHub API returned an error payload (rate limiting, auth failure, etc.), this would later surface as a misleading "version not found" error rather than reporting the actual API failure. Now, a non-array response throws a descriptive error including the HTTP status code and a pointer to the GraalVM Community download page. A legitimate empty array ([]) still terminates pagination normally. 2. docs/advanced-usage.md — make the GraalVM Community example self-contained The example ran java -cp java HelloWorldApp / native-image -cp java HelloWorldApp, but never created HelloWorldApp or a java classpath directory, so it would fail when copied as-is. It now checks the installed binaries' versions (java --version / native-image --version), matching the GraalVM (Oracle) example just above it. Tests Added a test covering the new non-array release listing error path. Full GraalVM suite passes (50 tests). Rebuilt the dist/ bundle. Related Follow-up to #1042 Copilot review: #1042 (review) (inline suggestions) Check list Documentation changes (docs/advanced-usage.md) Tests added/updated
Open Graph Description: Description Follow-up to #1042 (now merged) addressing the two suggestions left by the Copilot reviewer that weren't applied before merge. 1. src/distributions/graalvm/installer.ts — surface AP...
X Description: Description Follow-up to #1042 (now merged) addressing the two suggestions left by the Copilot reviewer that weren't applied before merge. 1. src/distributions/graalvm/installer.ts — surfac...
Opengraph URL: https://github.com/actions/setup-java/pull/1059
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:4fad6aa5-a0d1-aaed-e17e-c24c940fa173 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C008:236C7E:BB20FC:FFC3F0:6A4C9465 |
| html-safe-nonce | af03c4b2cb87944b21895474c67bba38b2583f1e5133f7127acdb8f3484bb970 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDA4OjIzNkM3RTpCQjIwRkM6RkZDM0YwOjZBNEM5NDY1IiwidmlzaXRvcl9pZCI6IjU1MDU2MTg5OTExMTkxMTEyNjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8f374c497cdb742c1e7195d579abe4dcaff3bd89cab6792a4b461cd4f4de9d9a |
| hovercard-subject-tag | pull_request:3921839509 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,actions,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/actions/setup-java/pull/1059/files |
| twitter:image | https://avatars.githubusercontent.com/u/129743?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/129743?s=400&v=4 |
| og:image:alt | Description Follow-up to #1042 (now merged) addressing the two suggestions left by the Copilot reviewer that weren't applied before merge. 1. src/distributions/graalvm/installer.ts — surface AP... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/actions/setup-java git https://github.com/actions/setup-java.git |
| octolytics-dimension-user_id | 44036562 |
| octolytics-dimension-user_login | actions |
| octolytics-dimension-repository_id | 196057608 |
| octolytics-dimension-repository_nwo | actions/setup-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 196057608 |
| octolytics-dimension-repository_network_root_nwo | actions/setup-java |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7a2dede45637df6b92ddcfe2a557e67d4b5854ae |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width