René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Handler Finalize() methods are never called, so intended indexes are never created","articleBody":"## Summary\n\nThe `ISQLiteHandler` implementations each define a `public void Finalize(SqliteConnection db)` method, but **nothing ever calls it**. `Finalize` is not part of the `ISQLiteHandler` interface (which only declares `Init`, `Process`, and `Dispose`), and there is no dispatch site anywhere in the codebase. As a result, the finalization work in those methods never runs.\n\nFor most handlers the method is an empty stub, but two of them create indexes that are therefore never created:\n\n- `AssetBundleHandler.Finalize` -\u003e `preload_dependencies_object`, `preload_dependencies_dependency`\n- `ShaderHandler.Finalize` -\u003e `shader_subprograms_shader_index`, `shader_subprogram_keywords_subprogram_id_index`\n\n(Note: `SQLiteWriter.End()` runs `Resources.Finalize` / `Finalize.sql`, which creates the `refs` indexes. That is a separate, top-level mechanism and does run - it is unrelated to these per-handler `Finalize` methods.)\n\n## Impact\n\n- The four indexes above are missing from every analyze database, so queries that filter/join on `preload_dependencies(object)`, `preload_dependencies(dependency)`, `shader_subprograms(shader)`, and `shader_subprogram_keywords(subprogram_id)` do full scans. This is a performance issue only; results are still correct.\n- The empty `Finalize` stubs in the other handlers are dead code and misleadingly imply a finalization step exists.\n\n## Evidence\n\nAfter running `analyze` on `TestCommon/Data/LeadingEdgeBuilds/AssetBundles`:\n\n```\nsqlite\u003e SELECT name FROM sqlite_master WHERE type='index' AND name LIKE 'preload_%';\n-- (no rows)\n```\n\nThe `preload_dependencies` table and its data are present, but the indexes are not.\n\n## Affected files\n\n- `Analyzer/SQLite/Handlers/ISQLiteHandler.cs` - interface has no `Finalize`.\n- Non-empty bodies: `Analyzer/SQLite/Handlers/AssetBundleHandler.cs`, `Analyzer/SQLite/Handlers/ShaderHandler.cs`.\n- Empty stubs: `AnimationClipHandler.cs`, `AudioClipHandler.cs`, `BuildReportHandler.cs`, `MeshHandler.cs`, `MonoScriptHandler.cs`, `PackedAssetsHandler.cs`, `PreloadDataHandler.cs`, `Texture2DHandler.cs`.\n\n## Suggested fix\n\nEither:\n\n1. **Wire it up** - add `Finalize(SqliteConnection db)` to `ISQLiteHandler` and invoke it once per handler after all serialized files are processed (the handler lifecycle is owned by `SerializedFileSQLiteWriter`; `SQLiteWriter.End()` is the natural point at which finalization runs). Drop the now-redundant empty overrides where possible. This restores the four intended indexes.\n\n2. **Delete the dead code** - if the indexes are not wanted, remove all the `Finalize` methods.\n\nOption 1 is preferred since the indexes are clearly intended and benefit lookups on the dependency and shader-subprogram tables.\n\n## Notes\n\nThe two `preload_dependencies_*` index names were just updated in #82 (table rename); this bug predates that change - the indexes were never created under their old `asset_dependencies_*` names either.\n","author":{"url":"https://github.com/SkowronskiAndrew","@type":"Person","name":"SkowronskiAndrew"},"datePublished":"2026-07-06T01:21:06.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/83/UnityDataTools/issues/83"}