René's URL Explorer Experiment

Title: Test generation for Optional in the plugin (#226) by dtim · Pull Request #305 · UnitTestBot/UTBotJava · GitHub

Open Graph Title: Test generation for Optional in the plugin (#226) by dtim · Pull Request #305 · UnitTestBot/UTBotJava

X Title: Test generation for Optional in the plugin (#226) by dtim · Pull Request #305 · UnitTestBot/UTBotJava

Description: Description Added a check for overridden classes in shouldMock to avoid access to engine classes that are not available in the plugin. Implemented more accurate speculative marking of final fields as not null to avoid losing paths involving Optional.empty(), to enable NPE checks for final fields in user code, and to avoid generating non-informative NPE tests for final fields in system classes. UtSettings.checkNpeForFinalFields is now set default (false) in AbstractTestCaseGEneratorTest and SummaryTestCaseGeneratorTest. Fixes #226 Details There were two issues with test generation for Optional. The shouldMock function tried to load overridden classes (in particular, UtOptional) and failed as the entire org.utbot.engine.overrides package is not included in the UtContext class loader created by the plugin. This commit fixes the problem an explicit check for overridden classes in shouldMock. Execution paths involving Optional.empty() were lost. This was caused by the assumption that all final fields can be considered non-nullable to reduce the number of irrelevant NPE execution paths, especially in system classes, that can usually be reproduced only by reflection. The Optional class is different from most other system classes as it uses null as the marker of the empty value in its final field. The "non-nullable final" optimization leads to discarding execution paths with Optional.empty() as UNSAT, as the final value field should be both null (explicit assignment) and not null (assumption for final fields). This commit introduces a new memory array to track final fields. For each NPE branch, the "value is null" condition is augmented by the "field is not final" condition. As a result, NPE branches for final fields are discarded with UNSAT, while non-final fields are not affected. The finality check is enabled for system classes only, and may be turned off by setting UtSettings.checkNpeForFinalFields to true. Type of Change Breaking change (fix or feature that would cause existing functionality to not work as expected) This commit changes the default behavior of the engine with respect to final fields nullability assumptions. Previous behavior: null values for final fields are not allowed. Branches where the final field gets null value are discarded even if they are legitimate. No NPE tests are generated. New behavior: null values for final fields are allowed. NPE branches for final fields of system classes are discarded (the only expected change for system classes is fixing the Optional.empty() bug and any similar bugs if they exist), but can be allowed by setting UtSettings.checkNpeForFinalFields to true. NPE tests for application classes are now generated (they may be legit or redundant, but the best way to avoid redundant tests here and not to lose legit branches is to create objects using the public API instead of reflection). How Has This Been Tested? Automated Testing The UtSettings.checkNpeForFinalFields = true setting was previously used to allow NPE branch generation for final fields in utbot-framework unit tests. Setting it to false would break some tests. This commit turns off this special mode, so utbot-framework use the same settings w.r.t. final fields nullability as the plugin. No new test failures have been detected in this mode. A new test case was added: org.utbot.examples.collections.OptionalsTest#testOptionalOfPositive. Manual Scenario Generate tests for the following examples using the plugin. Optional.empty() public class OptionalExamples { public Optional nonEmptyIfPositive(int n) { if (n > 0) { return Optional.of(n); } else { return Optional.empty(); } } public Optional nonEmptyIfTrue(boolean condition) { return condition ? Optional.of(true) : Optional.empty(); } } For both methods, two tests should be generated, one expecting a non-empty value, and one expecting the Optional.empty() result. No NPE tests should be generated. NPE checks for application classes public class FinalNulls { private final Integer shift; public FinalNulls() { this.shift = null; } public FinalNulls(int shift) { this.shift = shift; } public int plus(int a){ return a + shift; } } Two tests should be generated: a test for shift != null and a NPE test (shift == null). Checklist (remove irrelevant options): The change followed the style guidelines of the UTBot project Self-review of the code is passed The change contains enough commentaries, particularly in hard-to-understand areas No new warnings Tests that prove my change is effective All tests pass locally with my changes

Open Graph Description: Description Added a check for overridden classes in shouldMock to avoid access to engine classes that are not available in the plugin. Implemented more accurate speculative marking of final fields ...

X Description: Description Added a check for overridden classes in shouldMock to avoid access to engine classes that are not available in the plugin. Implemented more accurate speculative marking of final fields ...

Opengraph URL: https://github.com/UnitTestBot/UTBotJava/pull/305

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width