René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Unnecessary reflection when one constructor is used more than once","articleBody":"**Description**\r\n\r\nIn some cases, generated tests will have to call one constructor more then once. In this case, second and following calls may use reflection even though it is unnecessary.\r\n\r\n**To Reproduce**\r\n\r\nLaunch action on class `UnnecessaryReflection` from below:\r\n\r\n```Java\r\nclass MyPoint {\r\n    public final int x, y;\r\n    public MyPoint(int x, int y) {\r\n        this.x = x;\r\n        this.y = y;\r\n    }\r\n}\r\n\r\nclass ClassWithPoint {\r\n    public MyPoint p;\r\n    public ClassWithPoint(MyPoint p) {\r\n        this.p = p;\r\n    }\r\n}\r\n\r\npublic class UnnecessaryReflection {\r\n    public ClassWithPoint f(ClassWithPoint c) {\r\n        if (c.p.x == 1)\r\n            return new ClassWithPoint(new MyPoint(2, 3));\r\n        return c;\r\n    }\r\n}\r\n```\r\n\r\n**Expected behavior**\r\n\r\nTests are generated correctly and without reflection.\r\n\r\n**Actual behavior**\r\n\r\nIn some tests, some UtBot doesn't instantiate `Point` with constructor and uses reflection instead.\r\n\r\n**Visual proofs (screenshots, logs, images)**\r\n\r\n```Java\r\n@Test\r\npublic void testF2() throws Exception {\r\n    UnnecessaryReflection unnecessaryReflection = new UnnecessaryReflection();\r\n    MyPoint myPoint = new MyPoint(1, -1464141532);\r\n    ClassWithPoint c = new ClassWithPoint(myPoint);\r\n\r\n    ClassWithPoint actual = unnecessaryReflection.f(c);\r\n\r\n    ClassWithPoint expected = new ClassWithPoint(null);\r\n    MyPoint myPoint1 = ((MyPoint) createInstance(\"testpackage.MyPoint\"));\r\n    setField(myPoint1, \"testpackage.MyPoint\", \"x\", 2);\r\n    setField(myPoint1, \"testpackage.MyPoint\", \"y\", 3);\r\n    expected.p = myPoint1;\r\n    MyPoint expectedP = expected.p;\r\n    MyPoint actualP = actual.p;\r\n    int expectedPX = expectedP.x;\r\n    int actualPX = actualP.x;\r\n    assertEquals(expectedPX, actualPX);\r\n\r\n    int expectedPY = expectedP.y;\r\n    int actualPY = actualP.y;\r\n    assertEquals(expectedPY, actualPY);\r\n\r\n}\r\n```\r\n\r\n**Environment**\r\n\r\nFuzzing 25% Symbolic execution 75%\r\n\r\n**Additional context**\r\n\r\nSeems like problem is in `ConstructorAnalyzer.analyze()` method which does nothing when called more then once. However, we can't just remove `visited` checks from there, because this would lead to infinite recursion in examples like `org.utbot.examples.codegen.deepequals.ClassWithCrossReferenceRelationshipTest#testClassWithCrossReferenceRelationship` -- see [failed attempt to fix issue this way](https://github.com/UnitTestBot/UTBotJava/pull/1293)\r\n","author":{"url":"https://github.com/volivan239","@type":"Person","name":"volivan239"},"datePublished":"2022-11-11T09:43:53.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/1353/UTBotJava/issues/1353"}