René's URL Explorer Experiment


Title: Avoid exporting anonymous identifiers by hazzard993 · Pull Request #756 · TypeScriptToLua/TypeScriptToLua · GitHub

Open Graph Title: Avoid exporting anonymous identifiers by hazzard993 · Pull Request #756 · TypeScriptToLua/TypeScriptToLua

X Title: Avoid exporting anonymous identifiers by hazzard993 · Pull Request #756 · TypeScriptToLua/TypeScriptToLua

Description: Closes #695 createLocalOrExportedOrGlobalDeclaration's logic couldn't tell if an identifier was an OmittedExpression so it treated it like any other identifier and put ____exports in front of it. For this particular case I added an exportable flag to identifiers to indicate whether or not the identifier is intended to be exported / accessible.

Open Graph Description: Closes #695 createLocalOrExportedOrGlobalDeclaration's logic couldn't tell if an identifier was an OmittedExpression so it treated it like any other identifier and put ____exports in front ...

X Description: Closes #695 createLocalOrExportedOrGlobalDeclaration's logic couldn't tell if an identifier was an OmittedExpression so it treated it like any other identifier and put ____exports i...

Opengraph URL: https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9b483b0d-f7a7-690e-ae11-45fdc0d8c7ea
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id93C6:220FAF:159A694:1BC5CB4:697480FE
html-safe-noncea06b1abbe61a3cceba7424bd69c3261f7db503bd1ff87901cdccc36f13bb9a5e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0M2OjIyMEZBRjoxNTlBNjk0OjFCQzVDQjQ6Njk3NDgwRkUiLCJ2aXNpdG9yX2lkIjoiMjc5NzU5NzU3NjQ2MTA1ODMwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2a1edcaba2150139d6401cfbf5354c06daed7307002f589efc3f1a63aa86f3e9
hovercard-subject-tagpull_request:347278480
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files
twitter:imagehttps://avatars.githubusercontent.com/u/22235587?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/22235587?s=400&v=4
og:image:altCloses #695 createLocalOrExportedOrGlobalDeclaration's logic couldn't tell if an identifier was an OmittedExpression so it treated it like any other identifier and put ____exports in front ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee0b95d743b7672c9ac0e1032d5f117950182dc164a83434a7db86510e8f0b37c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/TypeScriptToLua/TypeScriptToLua git https://github.com/TypeScriptToLua/TypeScriptToLua.git
octolytics-dimension-user_id44121206
octolytics-dimension-user_loginTypeScriptToLua
octolytics-dimension-repository_id115876595
octolytics-dimension-repository_nwoTypeScriptToLua/TypeScriptToLua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id115876595
octolytics-dimension-repository_network_root_nwoTypeScriptToLua/TypeScriptToLua
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release56fe7e2e8de6e57740bca50402351ea656f7a4bf
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FTypeScriptToLua%2FTypeScriptToLua%2Fpull%2F756%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FTypeScriptToLua%2FTypeScriptToLua%2Fpull%2F756%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=TypeScriptToLua%2FTypeScriptToLua
Reloadhttps://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files
Reloadhttps://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files
Reloadhttps://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files
TypeScriptToLua https://github.com/TypeScriptToLua
TypeScriptToLuahttps://github.com/TypeScriptToLua/TypeScriptToLua
Please reload this pagehttps://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files
Notifications https://github.com/login?return_to=%2FTypeScriptToLua%2FTypeScriptToLua
Fork 182 https://github.com/login?return_to=%2FTypeScriptToLua%2FTypeScriptToLua
Star 2.4k https://github.com/login?return_to=%2FTypeScriptToLua%2FTypeScriptToLua
Code https://github.com/TypeScriptToLua/TypeScriptToLua
Issues 138 https://github.com/TypeScriptToLua/TypeScriptToLua/issues
Pull requests 7 https://github.com/TypeScriptToLua/TypeScriptToLua/pulls
Actions https://github.com/TypeScriptToLua/TypeScriptToLua/actions
Wiki https://github.com/TypeScriptToLua/TypeScriptToLua/wiki
Security 0 https://github.com/TypeScriptToLua/TypeScriptToLua/security
Insights https://github.com/TypeScriptToLua/TypeScriptToLua/pulse
Code https://github.com/TypeScriptToLua/TypeScriptToLua
Issues https://github.com/TypeScriptToLua/TypeScriptToLua/issues
Pull requests https://github.com/TypeScriptToLua/TypeScriptToLua/pulls
Actions https://github.com/TypeScriptToLua/TypeScriptToLua/actions
Wiki https://github.com/TypeScriptToLua/TypeScriptToLua/wiki
Security https://github.com/TypeScriptToLua/TypeScriptToLua/security
Insights https://github.com/TypeScriptToLua/TypeScriptToLua/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FTypeScriptToLua%2FTypeScriptToLua%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FTypeScriptToLua%2FTypeScriptToLua%2Fissues%2Fnew%2Fchoose
Perryvwhttps://github.com/Perryvw
TypeScriptToLua:masterhttps://github.com/TypeScriptToLua/TypeScriptToLua/tree/master
hazzard993:no-export-anonymoushttps://github.com/hazzard993/TypescriptToLua/tree/no-export-anonymous
Conversation 4 https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756
Commits 5 https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/commits
Checks 0 https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/checks
Files changed https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files
Please reload this pagehttps://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files
Avoid exporting anonymous identifiers https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files#top
Show all changes 5 commits https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files
4ab708e Avoid exporting anonymous identifiers hazzard993 Dec 1, 2019 https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/commits/4ab708ed16fdbb45da4a9ef90517c9752d9c1afd
50ece7f Use existing test for anonymous destructuring hazzard993 Dec 3, 2019 https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/commits/50ece7f11f79c97f060146d481e54a34dec5353b
811a1c0 Remove TODO for issue 32656 with test filter hazzard993 Dec 3, 2019 https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/commits/811a1c0050bbd1b9bd13a1547959b87dabeb8603
ddac23f Update test/unit/destructuring.spec.ts hazzard993 Dec 3, 2019 https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/commits/ddac23fd118db09fea2064f2063cd0f1dffdbcae
1f3ac33 Update test/unit/destructuring.spec.ts hazzard993 Dec 3, 2019 https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/commits/1f3ac33a98519f8bcc709f50f444cac3c5e0718e
Clear filters https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files
Please reload this pagehttps://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files
Please reload this pagehttps://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files
LuaAST.ts https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files#diff-e11c370e78e523cb92e3c9a36d8c153cb8ebe00d3039d2c6c19eb711bb47a08c
LuaTransformer.ts https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files#diff-25f557aa7a4cfdeaf027be81b800955d6ccac71178b5f51c6a3fefa68526bdbd
destructuring.spec.ts https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files#diff-3685a42d7b9b8285e93322216f6e1fbb38c6e5b3e10c769b5ab01de64c1c46cd
src/LuaAST.tshttps://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files#diff-e11c370e78e523cb92e3c9a36d8c153cb8ebe00d3039d2c6c19eb711bb47a08c
View file https://github.com/hazzard993/TypescriptToLua/blob/1f3ac33a98519f8bcc709f50f444cac3c5e0718e/src/LuaAST.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/{{ revealButtonHref }}
https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files#diff-e11c370e78e523cb92e3c9a36d8c153cb8ebe00d3039d2c6c19eb711bb47a08c
https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files#diff-e11c370e78e523cb92e3c9a36d8c153cb8ebe00d3039d2c6c19eb711bb47a08c
https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files#diff-e11c370e78e523cb92e3c9a36d8c153cb8ebe00d3039d2c6c19eb711bb47a08c
https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files#diff-e11c370e78e523cb92e3c9a36d8c153cb8ebe00d3039d2c6c19eb711bb47a08c
src/LuaTransformer.tshttps://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files#diff-25f557aa7a4cfdeaf027be81b800955d6ccac71178b5f51c6a3fefa68526bdbd
View file https://github.com/hazzard993/TypescriptToLua/blob/1f3ac33a98519f8bcc709f50f444cac3c5e0718e/src/LuaTransformer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/{{ revealButtonHref }}
https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files#diff-25f557aa7a4cfdeaf027be81b800955d6ccac71178b5f51c6a3fefa68526bdbd
https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files#diff-25f557aa7a4cfdeaf027be81b800955d6ccac71178b5f51c6a3fefa68526bdbd
test/unit/destructuring.spec.tshttps://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files#diff-3685a42d7b9b8285e93322216f6e1fbb38c6e5b3e10c769b5ab01de64c1c46cd
View file https://github.com/hazzard993/TypescriptToLua/blob/1f3ac33a98519f8bcc709f50f444cac3c5e0718e/test/unit/destructuring.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/{{ revealButtonHref }}
https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files#diff-3685a42d7b9b8285e93322216f6e1fbb38c6e5b3e10c769b5ab01de64c1c46cd
https://github.com/TypeScriptToLua/TypeScriptToLua/pull/756/files#diff-3685a42d7b9b8285e93322216f6e1fbb38c6e5b3e10c769b5ab01de64c1c46cd
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.