René's URL Explorer Experiment

Title: Fixed multi returning all values by lolleko · Pull Request #1428 · TypeScriptToLua/TypeScriptToLua · GitHub

Open Graph Title: Fixed multi returning all values by lolleko · Pull Request #1428 · TypeScriptToLua/TypeScriptToLua

X Title: Fixed multi returning all values by lolleko · Pull Request #1428 · TypeScriptToLua/TypeScriptToLua

Description: We try to avoid using select() when we use [0] to access the first value of multiple returns (e.g. multiCall()[0]). In that case, we omit the select(). Unfortunately, this only works if the value is assigned directly (local x = multiCall()). In cases where the value is not assigned, omitting the select and keeping just the call expression (multiCall()) will lead to all return values being passed on. (See #1411) To fix this, we now wrap the call in parentheses using a new Lua parentheses expression. Using parentheses is the correct way to keep only the first value of multiple returns (see https://www.lua.org/manual/5.1/manual.html#2.5) TL;DR: multiCall()[0] used to transpile to multiCall() now it transpiles to (multiCall()) which ensures correct semantics across all potential usages. This fixes #1411

Open Graph Description: We try to avoid using select() when we use [0] to access the first value of multiple returns (e.g. multiCall()[0]). In that case, we omit the select(). Unfortunately, this only works if the value ...

X Description: We try to avoid using select() when we use [0] to access the first value of multiple returns (e.g. multiCall()[0]). In that case, we omit the select(). Unfortunately, this only works if the value ...

Opengraph URL: https://github.com/TypeScriptToLua/TypeScriptToLua/pull/1428

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width