René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Proposal: Lualib override plugins","articleBody":"In the last 2 weeks we received two requests for the ability to modify lualib output with plugins. One for supplying an environment-specific implementation of __TS__New, and another for a specialized ArrayForEach implementation for an environment's special tables.\r\n\r\nOther use cases for overriding lualib functions might be using computation/memory/garbage optimized versions of lualib functions.\r\n\r\nI think this is a 'quick win' as it seems relatively simple to implement this as follows:\r\n\r\nAdd a record to the plugin interface that allows supplying a string for a lualib feature:\r\n\r\n```diff\r\nexport interface Plugin {\r\n    /**\r\n     * An augmentation to the map of visitors that transform TypeScript AST to Lua AST.\r\n     *\r\n     * Key is a `SyntaxKind` of a processed node.\r\n     */\r\n    visitors?: Visitors;\r\n\r\n    /**\r\n     * A function that converts Lua AST to a string.\r\n     *\r\n     * At most one custom printer can be provided across all plugins.\r\n     */\r\n    printer?: Printer;\r\n+\r\n+    /**\r\n+     * Provide a custom string that will be emitted as implementation for a lualib feature.\r\n+     */\r\n+    lualib?: Partial\u003cRecord\u003cLuaLibFeature, string\u003e\u003e\r\n}\r\n```\r\n\r\nThen a plugin could look like this:\r\n```ts\r\nconst plugin = {\r\n    lualib: {\r\n        [LuaLibFeature.Delete]: `\r\n            function __TS__Delete(target, key)\r\n                target[key] = nil\r\n            end\r\n        `\r\n    }\r\n}\r\n```\r\n\r\nOr even:\r\n```ts\r\nconst plugin = {\r\n    lualib: {\r\n        ...garbageCollectorOptimizedLualibCollectionFromNpmPackage,\r\n        ...lualibFunctionsForEnvironment\r\n    }\r\n}\r\n```\r\n\r\nWe then pass these plugins to the printer and override the lualib methods it wants to emit.\r\n\r\nWhat I'm not sure about yet is if these should be supplied as Lua string or something else (TS/Lua AST/TS AST). Also leaving in the function header like I did in the example could potentially lead to typos and other issues, although we should easily be able to put in a diagnostic for that.\r\n","author":{"url":"https://github.com/Perryvw","@type":"Person","name":"Perryvw"},"datePublished":"2021-01-29T20:03:34.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/973/TypeScriptToLua/issues/973"}