Title: PvP Ranks extra honor · Issue #16 · TrinityCore/TrinityCoreCustomChanges · GitHub
Open Graph Title: PvP Ranks extra honor · Issue #16 · TrinityCore/TrinityCoreCustomChanges
X Title: PvP Ranks extra honor · Issue #16 · TrinityCore/TrinityCoreCustomChanges
Description: PvP Ranks calls honor *= 1 + sWorld->getRate(RATE_PVP_RANK_EXTRA_HONOR)*(((float)rank_diff) / 10.0f); but then honor = int32(honor_f); so the custom extra honor gets lost. honor_f should probably be changed instead. c840b87#diff-5589ee47...
Open Graph Description: PvP Ranks calls honor *= 1 + sWorld->getRate(RATE_PVP_RANK_EXTRA_HONOR)*(((float)rank_diff) / 10.0f); but then honor = int32(honor_f); so the custom extra honor gets lost. honor_f should probably b...
X Description: PvP Ranks calls honor *= 1 + sWorld->getRate(RATE_PVP_RANK_EXTRA_HONOR)*(((float)rank_diff) / 10.0f); but then honor = int32(honor_f); so the custom extra honor gets lost. honor_f should probabl...
Opengraph URL: https://github.com/TrinityCore/TrinityCoreCustomChanges/issues/16
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"PvP Ranks extra honor","articleBody":"PvP Ranks calls\r\n```cpp\r\nhonor *= 1 + sWorld->getRate(RATE_PVP_RANK_EXTRA_HONOR)*(((float)rank_diff) / 10.0f);\r\n```\r\nbut then\r\n```cpp\r\nhonor = int32(honor_f);\r\n```\r\nso the custom extra honor gets lost.\r\n\r\nhonor_f should probably be changed instead.\r\n\r\nhttps://github.com/TrinityCore/TrinityCoreCustomChanges/commit/c840b87d24ba21f1c06127f0d2ce991afe0de7b2#diff-5589ee47b3a7ad220cff105a8fe7eac3R6854","author":{"url":"https://github.com/jackpoz","@type":"Person","name":"jackpoz"},"datePublished":"2019-07-23T06:25:36Z","url":"https://github.com/TrinityCore/TrinityCoreCustomChanges/issues/16"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:850d45d1-bd3c-e4f7-3f94-6224d02a0343 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E744:140DC5:45DF:56D2:6AFFB5AB |
| html-safe-nonce | ac39fc30b7fcf3c64d8701c2e7c0ca7eb66f14ce899f3d9974886e6c377d13fb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzQ0OjE0MERDNTo0NURGOjU2RDI6NkFGRkI1QUIiLCJ2aXNpdG9yX2lkIjoiNTI4ODg2MDI0MTMxMDMyNDkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1496d13df2689128a23a328ee0a2da200b8a0fad251f42cf09e05243f7dc07f4 |
| hovercard-subject-tag | issue:471507657 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/TrinityCore/TrinityCoreCustomChanges/16/issue_layout |
| twitter:image | https://opengraph.githubassets.com/ab43a54445a067e2626d7f6336631607cdb3c5895bf58583c616085a2a07f73d/TrinityCore/TrinityCoreCustomChanges/issues/16 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ab43a54445a067e2626d7f6336631607cdb3c5895bf58583c616085a2a07f73d/TrinityCore/TrinityCoreCustomChanges/issues/16 |
| og:image:alt | PvP Ranks calls honor *= 1 + sWorld->getRate(RATE_PVP_RANK_EXTRA_HONOR)*(((float)rank_diff) / 10.0f); but then honor = int32(honor_f); so the custom extra honor gets lost. honor_f should probably b... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jackpoz |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7e461843db1c75e40d788c5cfd440d0e4ae1271cf19e06a798d0e7feb2d708f3 |
| turbo-cache-control | no-preview |
| go-import | github.com/TrinityCore/TrinityCoreCustomChanges git https://github.com/TrinityCore/TrinityCoreCustomChanges.git |
| octolytics-dimension-user_id | 539602 |
| octolytics-dimension-user_login | TrinityCore |
| octolytics-dimension-repository_id | 171278196 |
| octolytics-dimension-repository_nwo | TrinityCore/TrinityCoreCustomChanges |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 171278196 |
| octolytics-dimension-repository_network_root_nwo | TrinityCore/TrinityCoreCustomChanges |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d29a6a99861646939301302fab465f9f123b4773 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width