Title: [Design] ChangeNode method is too strict · Issue #7 · ToCSharp/TypeScriptAST · GitHub
Open Graph Title: [Design] ChangeNode method is too strict · Issue #7 · ToCSharp/TypeScriptAST
X Title: [Design] ChangeNode method is too strict · Issue #7 · ToCSharp/TypeScriptAST
Description: Hello, I came across an implementation that was far away from what I was expecting while using the ChangeNode() method. If the replacement string provided equals the current node's string representation, the method throws an exception wi...
Open Graph Description: Hello, I came across an implementation that was far away from what I was expecting while using the ChangeNode() method. If the replacement string provided equals the current node's string represent...
X Description: Hello, I came across an implementation that was far away from what I was expecting while using the ChangeNode() method. If the replacement string provided equals the current node's string repre...
Opengraph URL: https://github.com/ToCSharp/TypeScriptAST/issues/7
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Design] ChangeNode method is too strict","articleBody":"Hello, I came across an implementation that was far away from what I was expecting while using the `ChangeNode()` method.\r\nIf the replacement string provided equals the current node's string representation, the method throws an exception with message \"Same value\".\r\nI'm convinced that one would expect a no-op in that particular case, and that this implementation is very unnatural, at the very least. ","author":{"url":"https://github.com/remye06","@type":"Person","name":"remye06"},"datePublished":"2020-07-17T10:21:08.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/7/TypeScriptAST/issues/7"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:cb0f1289-a7d2-c5c9-500a-ad8200effb8e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A2FE:E2AFA:19701B8:2067D32:69918B5E |
| html-safe-nonce | a2ff7b7c6d796ab883b1acf130a2467ecaeab6983ebaf52de9e7b6ade165c33e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkZFOkUyQUZBOjE5NzAxQjg6MjA2N0QzMjo2OTkxOEI1RSIsInZpc2l0b3JfaWQiOiI1NTM0MTMxNTQzODE4MjEwMTQyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9a9523ee1eac5c159368dd06ebe414b0a223308e2eaa0a72056232f20812fb28 |
| hovercard-subject-tag | issue:659115312 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/ToCSharp/TypeScriptAST/7/issue_layout |
| twitter:image | https://opengraph.githubassets.com/4287b4e45c7094dc855567210b30152dca3f711d9da0801767f8f8e89ebf2d70/ToCSharp/TypeScriptAST/issues/7 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4287b4e45c7094dc855567210b30152dca3f711d9da0801767f8f8e89ebf2d70/ToCSharp/TypeScriptAST/issues/7 |
| og:image:alt | Hello, I came across an implementation that was far away from what I was expecting while using the ChangeNode() method. If the replacement string provided equals the current node's string represent... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | remye06 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| go-import | github.com/ToCSharp/TypeScriptAST git https://github.com/ToCSharp/TypeScriptAST.git |
| octolytics-dimension-user_id | 16608023 |
| octolytics-dimension-user_login | ToCSharp |
| octolytics-dimension-repository_id | 88155977 |
| octolytics-dimension-repository_nwo | ToCSharp/TypeScriptAST |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 88155977 |
| octolytics-dimension-repository_network_root_nwo | ToCSharp/TypeScriptAST |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width