| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:47aa61db-b318-4c34-a0e2-bb8e8daf0482 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9D7E:16F405:24AC48D:2F99BAE:6A5C9F9A |
| html-safe-nonce | e8e64626de675de3dbdd0af16c7b7fe5cd7bcb9d73a98dd67bfb0c5565335e15 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDdFOjE2RjQwNToyNEFDNDhEOjJGOTlCQUU6NkE1QzlGOUEiLCJ2aXNpdG9yX2lkIjoiMzMzNTYyMDUyNzU1NDA3NjU3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7d06d6f0546fdad00dd8c383dd511ac879b2edb22106e6aeb3caeb6be528f65c |
| hovercard-subject-tag | pull_request:766510292 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/TheAlgorithms/Python/pull/5608/files |
| twitter:image | https://avatars.githubusercontent.com/u/3709715?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3709715?s=400&v=4 |
| og:image:alt | Let's see what is required to finish #4052
Describe your change:
Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?
Checklist:
I have read CONTRIBUTING.... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/TheAlgorithms/Python git https://github.com/TheAlgorithms/Python.git |
| octolytics-dimension-user_id | 20487725 |
| octolytics-dimension-user_login | TheAlgorithms |
| octolytics-dimension-repository_id | 63476337 |
| octolytics-dimension-repository_nwo | TheAlgorithms/Python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 63476337 |
| octolytics-dimension-repository_network_root_nwo | TheAlgorithms/Python |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/TheAlgorithms/Python/pull/5608/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FTheAlgorithms%2FPython%2Fpull%2F5608%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FTheAlgorithms%2FPython%2Fpull%2F5608%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=TheAlgorithms%2FPython |
| Reload | https://github.com/TheAlgorithms/Python/pull/5608/files |
| Reload | https://github.com/TheAlgorithms/Python/pull/5608/files |
| Reload | https://github.com/TheAlgorithms/Python/pull/5608/files |
| Please reload this page | https://github.com/TheAlgorithms/Python/pull/5608/files |
|
TheAlgorithms
| https://github.com/TheAlgorithms |
| Python | https://github.com/TheAlgorithms/Python |
| Please reload this page | https://github.com/TheAlgorithms/Python/pull/5608/files |
|
Notifications
| https://github.com/login?return_to=%2FTheAlgorithms%2FPython |
|
Fork
50.9k
| https://github.com/login?return_to=%2FTheAlgorithms%2FPython |
|
Star
223k
| https://github.com/login?return_to=%2FTheAlgorithms%2FPython |
|
Code
| https://github.com/TheAlgorithms/Python |
|
Issues
141
| https://github.com/TheAlgorithms/Python/issues |
|
Pull requests
876
| https://github.com/TheAlgorithms/Python/pulls |
|
Discussions
| https://github.com/TheAlgorithms/Python/discussions |
|
Actions
| https://github.com/TheAlgorithms/Python/actions |
|
Projects
| https://github.com/TheAlgorithms/Python/projects |
|
Wiki
| https://github.com/TheAlgorithms/Python/wiki |
|
Security and quality
0
| https://github.com/TheAlgorithms/Python/security |
|
Insights
| https://github.com/TheAlgorithms/Python/pulse |
|
Code
| https://github.com/TheAlgorithms/Python |
|
Issues
| https://github.com/TheAlgorithms/Python/issues |
|
Pull requests
| https://github.com/TheAlgorithms/Python/pulls |
|
Discussions
| https://github.com/TheAlgorithms/Python/discussions |
|
Actions
| https://github.com/TheAlgorithms/Python/actions |
|
Projects
| https://github.com/TheAlgorithms/Python/projects |
|
Wiki
| https://github.com/TheAlgorithms/Python/wiki |
|
Security and quality
| https://github.com/TheAlgorithms/Python/security |
|
Insights
| https://github.com/TheAlgorithms/Python/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FTheAlgorithms%2FPython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FTheAlgorithms%2FPython%2Fissues%2Fnew%2Fchoose |
| cclauss | https://github.com/cclauss |
| master | https://github.com/TheAlgorithms/Python/tree/master |
| mypy-reality-check | https://github.com/TheAlgorithms/Python/tree/mypy-reality-check |
|
Conversation
15
| https://github.com/TheAlgorithms/Python/pull/5608 |
|
Commits
23
| https://github.com/TheAlgorithms/Python/pull/5608/commits |
|
Checks
0
| https://github.com/TheAlgorithms/Python/pull/5608/checks |
|
Files changed
| https://github.com/TheAlgorithms/Python/pull/5608/files |
| Please reload this page | https://github.com/TheAlgorithms/Python/pull/5608/files |
|
mypy: Exclude only 20 files that are still failing
| https://github.com/TheAlgorithms/Python/pull/5608/files#top |
|
Show all changes
23 commits
| https://github.com/TheAlgorithms/Python/pull/5608/files |
|
a68cc16
DRAFT: Run a mypy reality check
cclauss Oct 26, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/a68cc16656427345f729f82321107cd59694962f |
|
275615b
mypy --ignore-missing-imports --install-types --non-interactive
cclauss Oct 26, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/275615b8ccb435b8b81795b2ae148648adb9a662 |
|
43df758
Check our progress...
cclauss Oct 29, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/43df758437c92865ace98575d5eb921efc25c175 |
|
8ced76c
Update build.yml
cclauss Oct 29, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/8ced76cd5ac3127bf876d238c5a9941142fa198c |
|
5273f52
Update build.yml
cclauss Nov 3, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/5273f52726441639f875b78aa6528cb89c8bf229 |
|
c8b64a8
Update build.yml
cclauss Nov 3, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/c8b64a8d98c97f889664611c9efe2a3bcb852251 |
|
8ea9fab
Update build.yml
cclauss Nov 4, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/8ea9fab7ec6bdf75eec1bec3e7198edcdf67f2cf |
|
967e1bd
mypy --exclude 20 files
cclauss Nov 5, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/967e1bd4cf1d823e512a900cf1c0c0a1b1cd36db |
|
471e638
--exclude with no `=`
cclauss Nov 5, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/471e6381948c3f96f036b377f37722edd0d7d38f |
|
14633a1
Update build.yml
cclauss Nov 5, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/14633a158671f08e2fd2cd254e54f37061e85d8a |
|
f073fe7
558 character regex!!!
cclauss Nov 5, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/f073fe7cc42949afc352c00ce96a954ec8bec77a |
|
b0a5549
With quotes
cclauss Nov 5, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/b0a55498ef68747c37d096703b48066137a12c1c |
|
2d65941
mypy.ini: mega exclude
cclauss Nov 5, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/2d6594152533a6ac87b0abfddece740551278365 |
|
ffad6f5
Update mypy.ini
cclauss Nov 5, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/ffad6f59b7c64e12b8786ed7e4134079d7d93654 |
|
105c1f4
Update build.yml
cclauss Nov 5, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/105c1f41d034dc52f4999083cf355af08cb7a302 |
|
f972c84
Update mypy.ini
cclauss Nov 5, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/f972c84dd25983f435b635b1d99e299824a77ef6 |
|
9c621d3
Update build.yml
cclauss Nov 5, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/9c621d3d66a195cc71f29eaa1a28b338baa93b1d |
|
0091d5c
Update mypy.ini
cclauss Nov 5, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/0091d5cea1e94b7377a65612b6b21544918ddee1 |
|
9404b67
.py --> .p*
cclauss Nov 5, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/9404b67313713974ea5fcfa906a459454e0b5a7f |
|
3bfb2b6
Escape the dots!: `.` --> `\.`
cclauss Nov 5, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/3bfb2b6791711a4021aee78d8827ecc1ad563ca9 |
|
dcefccb
Remove the comment
cclauss Nov 5, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/dcefccb3431e7575afb60b295920dbbc4c4419c4 |
|
535988e
Leading slash
cclauss Nov 5, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/535988eea83af8324f6501dd40e04922ae6eb784 |
|
36d2c4b
Update mypy.ini
cclauss Nov 5, 2021
| https://github.com/TheAlgorithms/Python/pull/5608/commits/36d2c4bdd6ab2685948d30bdcc9589faf25eb44d |
|
Clear filters
| https://github.com/TheAlgorithms/Python/pull/5608/files |
| Please reload this page | https://github.com/TheAlgorithms/Python/pull/5608/files |
| Please reload this page | https://github.com/TheAlgorithms/Python/pull/5608/files |
|
build.yml
| https://github.com/TheAlgorithms/Python/pull/5608/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721 |
|
mypy.ini
| https://github.com/TheAlgorithms/Python/pull/5608/files#diff-6f2d4ba9ca9a357d31014946667b7bed1bfdbc6d2530afc77778fa0a36bee457 |
|
| https://github.com/TheAlgorithms/Python/blob/master/.github/CODEOWNERS#L10 |
| .github/workflows/build.yml | https://github.com/TheAlgorithms/Python/pull/5608/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721 |
|
View file
| https://github.com/TheAlgorithms/Python/blob/36d2c4bdd6ab2685948d30bdcc9589faf25eb44d/.github/workflows/build.yml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/TheAlgorithms/Python/pull/5608/{{ revealButtonHref }} |
|
| https://github.com/TheAlgorithms/Python/pull/5608/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721 |
|
| https://github.com/TheAlgorithms/Python/pull/5608/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721 |
| mypy.ini | https://github.com/TheAlgorithms/Python/pull/5608/files#diff-6f2d4ba9ca9a357d31014946667b7bed1bfdbc6d2530afc77778fa0a36bee457 |
|
View file
| https://github.com/TheAlgorithms/Python/blob/36d2c4bdd6ab2685948d30bdcc9589faf25eb44d/mypy.ini |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/TheAlgorithms/Python/pull/5608/{{ revealButtonHref }} |
| dhruvmanila | https://github.com/dhruvmanila |
| Nov 6, 2021 | https://github.com/TheAlgorithms/Python/pull/5608/files#r744119760 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/TheAlgorithms/Python/pull/5608/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |