| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f5ac233f-fd7f-4225-69d2-0dcadda59994 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ED58:26BE6B:16E3236:1F5344F:6AFB7FCE |
| html-safe-nonce | fba76aefad894eba72a54bbfb90b40362f999f98e0ed4f40bfc7e77a3ada789e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDU4OjI2QkU2QjoxNkUzMjM2OjFGNTM0NEY6NkFGQjdGQ0UiLCJ2aXNpdG9yX2lkIjoiNzEzNTU5ODk5NzM4ODYyMzgyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fc5942a979d3178bf4abd3b4c77110c93232a1696d7a20ad19dfc7683e67d66d |
| hovercard-subject-tag | pull_request:4230494952 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/TheAlgorithms/Python/15010/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/479a6e66777e790539faa23ef396fedfb4eb4f2c759ff20a22d90f8f20942514/TheAlgorithms/Python/pull/15010 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/479a6e66777e790539faa23ef396fedfb4eb4f2c759ff20a22d90f8f20942514/TheAlgorithms/Python/pull/15010 |
| og:image:alt | Fix bad-character shift having no effect (dead loop variable)
Fixes #14844
Summary
bad_character_heuristic() in strings/boyer_moore_search.py assigned the
computed shift to the for-loop variable i:... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bolverk |
| hostname | github.com |
| expected-hostname | github.com |
| None | ef32892d4269fb87b55e81cc4ba8d86e0f16aa28446ffbf46cba8be5179ab188 |
| turbo-cache-control | no-cache |
| go-import | github.com/TheAlgorithms/Python git https://github.com/TheAlgorithms/Python.git |
| octolytics-dimension-user_id | 20487725 |
| octolytics-dimension-user_login | TheAlgorithms |
| octolytics-dimension-repository_id | 63476337 |
| octolytics-dimension-repository_nwo | TheAlgorithms/Python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 63476337 |
| octolytics-dimension-repository_network_root_nwo | TheAlgorithms/Python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bc3703b4dcbe820d1284ef63c88b001c850be25e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/TheAlgorithms/Python/pull/15010#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FTheAlgorithms%2FPython%2Fpull%2F15010 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FTheAlgorithms%2FPython%2Fpull%2F15010 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=TheAlgorithms%2FPython |
| Reload | https://github.com/TheAlgorithms/Python/pull/15010 |
| Reload | https://github.com/TheAlgorithms/Python/pull/15010 |
| Reload | https://github.com/TheAlgorithms/Python/pull/15010 |
| TheAlgorithms | https://github.com/TheAlgorithms |
| Python | https://github.com/TheAlgorithms/Python |
| Code | https://github.com/TheAlgorithms/Python |
| Issues14 (14) | https://github.com/TheAlgorithms/Python/issues |
| Pull requests104 (104) | https://github.com/TheAlgorithms/Python/pulls |
| Discussions | https://github.com/TheAlgorithms/Python/discussions |
| Actions | https://github.com/TheAlgorithms/Python/actions |
| Projects | https://github.com/TheAlgorithms/Python/projects |
| Wiki | https://github.com/TheAlgorithms/Python/wiki |
| Security and quality | https://github.com/TheAlgorithms/Python/security |
| Insights | https://github.com/TheAlgorithms/Python/pulse |
| https://github.com/TheAlgorithms/Python |
| bolverk | https://github.com/bolverk |
| TheAlgorithms:master | https://github.com/TheAlgorithms/Python/tree/master |
| bolverk:fix/boyer-moore-bad-character-shift | https://github.com/bolverk/Python/tree/fix/boyer-moore-bad-character-shift |
| Conversation | https://github.com/TheAlgorithms/Python/pull/15010 |
| Commits2 (2) | https://github.com/TheAlgorithms/Python/pull/15010/commits |
| Checks | https://github.com/TheAlgorithms/Python/pull/15010/checks |
| Files changed | https://github.com/TheAlgorithms/Python/pull/15010/files |
| fix: bad-character shift in Boyer-Moore search has no effect | https://github.com/TheAlgorithms/Python/pull/15010#top |
| bolverk | https://github.com/bolverk |
| TheAlgorithms:master | https://github.com/TheAlgorithms/Python/tree/master |
| bolverk:fix/boyer-moore-bad-character-shift | https://github.com/bolverk/Python/tree/fix/boyer-moore-bad-character-shift |
|
| https://github.com/bolverk |
| bolverk | https://github.com/bolverk |
| Aug 7, 2026 | https://github.com/TheAlgorithms/Python/pull/15010#issue-5092611129 |
| #14844 | https://github.com/TheAlgorithms/Python/issues/14844 |
| CONTRIBUTING.md | https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md |
| Please reload this page | https://github.com/TheAlgorithms/Python/pull/15010 |
|
| https://github.com/almogyalin |
| fix: bad-character shift in Boyer-Moore search has no effect | https://github.com/TheAlgorithms/Python/pull/15010/commits/b55d94a52cd81855bd688fb0871dd934e1b23caa |
| b55d94a | https://github.com/TheAlgorithms/Python/pull/15010/commits/b55d94a52cd81855bd688fb0871dd934e1b23caa |
| https://github.com/apps/algorithms-keeper |
| algorithms-keeper | https://github.com/apps/algorithms-keeper |
|
enhancement
| https://github.com/TheAlgorithms/Python/issues?q=state%3Aopen%20label%3Aenhancement |
|
awaiting reviews
| https://github.com/TheAlgorithms/Python/issues?q=state%3Aopen%20label%3A%22awaiting%20reviews%22 |
| Aug 7, 2026 | https://github.com/TheAlgorithms/Python/pull/15010#event-29132722366 |
| https://github.com/daltino |
| daltino | https://github.com/daltino |
|
Aug 11, 2026
| https://github.com/TheAlgorithms/Python/pull/15010#pullrequestreview-4902008023 |
|
View reviewed changes
| https://github.com/TheAlgorithms/Python/pull/15010/files/b55d94a52cd81855bd688fb0871dd934e1b23caa |
| daltino | https://github.com/daltino |
| https://github.com/TheAlgorithms/Python/pull/15010#pullrequestreview-4902008023 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/TheAlgorithms/Python/pull/15010 |
| https://github.com/mindaugl |
| mindaugl | https://github.com/mindaugl |
|
Aug 12, 2026
| https://github.com/TheAlgorithms/Python/pull/15010#pullrequestreview-4918216872 |
|
View reviewed changes
| https://github.com/TheAlgorithms/Python/pull/15010/files/b55d94a52cd81855bd688fb0871dd934e1b23caa |
| https://github.com/bolverk |
| bolverk | https://github.com/bolverk |
| force-pushed | https://github.com/TheAlgorithms/Python/compare/537aaa9bc6d72e1a454d9fa4c96ab674c903c6b7..be1a24680c4a9a17e59bd2b1231ee6d827f6b24f |
| 537aaa9 | https://github.com/TheAlgorithms/Python/commit/537aaa9bc6d72e1a454d9fa4c96ab674c903c6b7 |
| be1a246 | https://github.com/TheAlgorithms/Python/commit/be1a24680c4a9a17e59bd2b1231ee6d827f6b24f |
|
Compare
| https://github.com/TheAlgorithms/Python/compare/537aaa9bc6d72e1a454d9fa4c96ab674c903c6b7..be1a24680c4a9a17e59bd2b1231ee6d827f6b24f |
| August 24, 2026 19:58 | https://github.com/TheAlgorithms/Python/pull/15010#event-29936532293 |
|
| https://github.com/almogyalin |
| fix: bad-character shift in Boyer-Moore search has no effect | https://github.com/TheAlgorithms/Python/pull/15010/commits/41d01d0c0ae5804b55168c521f55b428d5d8a0f7 |
| 41d01d0 | https://github.com/TheAlgorithms/Python/pull/15010/commits/41d01d0c0ae5804b55168c521f55b428d5d8a0f7 |
| https://github.com/bolverk |
| bolverk | https://github.com/bolverk |
| force-pushed | https://github.com/TheAlgorithms/Python/compare/be1a24680c4a9a17e59bd2b1231ee6d827f6b24f..41d01d0c0ae5804b55168c521f55b428d5d8a0f7 |
| be1a246 | https://github.com/TheAlgorithms/Python/commit/be1a24680c4a9a17e59bd2b1231ee6d827f6b24f |
| 41d01d0 | https://github.com/TheAlgorithms/Python/commit/41d01d0c0ae5804b55168c521f55b428d5d8a0f7 |
|
Compare
| https://github.com/TheAlgorithms/Python/compare/be1a24680c4a9a17e59bd2b1231ee6d827f6b24f..41d01d0c0ae5804b55168c521f55b428d5d8a0f7 |
| August 24, 2026 20:10 | https://github.com/TheAlgorithms/Python/pull/15010#event-29937120222 |
| https://github.com/bolverk |
| bolverk | https://github.com/bolverk |
| Aug 24, 2026 | https://github.com/TheAlgorithms/Python/pull/15010#issuecomment-5401278472 |
| Please reload this page | https://github.com/TheAlgorithms/Python/pull/15010 |
| https://github.com/priya-sundaram-dev |
| priya-sundaram-dev | https://github.com/priya-sundaram-dev |
|
Aug 25, 2026
| https://github.com/TheAlgorithms/Python/pull/15010#pullrequestreview-5018376167 |
|
View reviewed changes
| https://github.com/TheAlgorithms/Python/pull/15010/files/41d01d0c0ae5804b55168c521f55b428d5d8a0f7 |
| priya-sundaram-dev | https://github.com/priya-sundaram-dev |
| https://github.com/TheAlgorithms/Python/pull/15010#pullrequestreview-5018376167 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/TheAlgorithms/Python/pull/15010 |
| https://github.com/priya-sundaram-dev |
| priya-sundaram-dev | https://github.com/priya-sundaram-dev |
|
Sep 10, 2026
| https://github.com/TheAlgorithms/Python/pull/15010#ref-issue-5242842322 |
|
priya-sundaram-dev as a triager?
#15081
| https://github.com/TheAlgorithms/Python/issues/15081 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
|
Sep 10, 2026
| https://github.com/TheAlgorithms/Python/pull/15010#ref-pullrequest-4720051623 |
|
Fix Bug [#14844] : Boyer-Moore bad character shift has no effect (for-loop variable reassignment)
#14848
| https://github.com/TheAlgorithms/Python/pull/14848 |
| https://github.com/cclauss |
| cclauss | https://github.com/cclauss |
|
#14848
| https://github.com/TheAlgorithms/Python/pull/14848 |
| Sep 10, 2026 | https://github.com/TheAlgorithms/Python/pull/15010#event-30895456740 |
| https://github.co/hiddenchars |
| https://github.com/TheAlgorithms/Python/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FTheAlgorithms%2FPython%2Fpull%2F15010 |
|
| https://github.com/daltino |
|
daltino
| https://github.com/daltino |
|
| https://github.com/TheAlgorithms/Python/pull/15010/files/b55d94a52cd81855bd688fb0871dd934e1b23caa |
|
| https://github.com/mindaugl |
|
mindaugl
| https://github.com/mindaugl |
|
| https://github.com/TheAlgorithms/Python/pull/15010/files/b55d94a52cd81855bd688fb0871dd934e1b23caa |
|
| https://github.com/priya-sundaram-dev |
|
priya-sundaram-dev
| https://github.com/priya-sundaram-dev |
|
| https://github.com/TheAlgorithms/Python/pull/15010/files/41d01d0c0ae5804b55168c521f55b428d5d8a0f7 |
| Please reload this page | https://github.com/TheAlgorithms/Python/pull/15010 |
|
awaiting reviews
| https://github.com/TheAlgorithms/Python/issues?q=state%3Aopen%20label%3A%22awaiting%20reviews%22 |
|
enhancement
| https://github.com/TheAlgorithms/Python/issues?q=state%3Aopen%20label%3Aenhancement |
|
Bug: Boyer-Moore bad character shift has no effect (for-loop variable reassignment)
| https://github.com/TheAlgorithms/Python/issues/14844 |
| Please reload this page | https://github.com/TheAlgorithms/Python/pull/15010 |
|
| https://github.com/bolverk |
|
| https://github.com/daltino |
|
| https://github.com/mindaugl |
|
| https://github.com/priya-sundaram-dev |
|
| https://github.com/almogyalin |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |