René's URL Explorer Experiment


Title: Bug: Boyer-Moore bad character shift has no effect (for-loop variable reassignment) · Issue #14844 · TheAlgorithms/Python · GitHub

Open Graph Title: Bug: Boyer-Moore bad character shift has no effect (for-loop variable reassignment) · Issue #14844 · TheAlgorithms/Python

X Title: Bug: Boyer-Moore bad character shift has no effect (for-loop variable reassignment) · Issue #14844 · TheAlgorithms/Python

Description: Description In strings/boyer_moore_search.py, the bad_character_heuristic() method attempts to skip positions using the bad character rule, but the shift has no effect because it reassigns the for-loop variable i: def bad_character_heuri...

Open Graph Description: Description In strings/boyer_moore_search.py, the bad_character_heuristic() method attempts to skip positions using the bad character rule, but the shift has no effect because it reassigns the for-...

X Description: Description In strings/boyer_moore_search.py, the bad_character_heuristic() method attempts to skip positions using the bad character rule, but the shift has no effect because it reassigns the for-...

Opengraph URL: https://github.com/TheAlgorithms/Python/issues/14844

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bug: Boyer-Moore bad character shift has no effect (for-loop variable reassignment)","articleBody":"### Description\n\nIn `strings/boyer_moore_search.py`, the `bad_character_heuristic()` method attempts to skip positions using the bad character rule, but the shift has **no effect** because it reassigns the `for`-loop variable `i`:\n\n```python\ndef bad_character_heuristic(self) -> list[int]:\n    positions = []\n    for i in range(self.textLen - self.patLen + 1):\n        mismatch_index = self.mismatch_in_text(i)\n        if mismatch_index == -1:\n            positions.append(i)\n        else:\n            match_index = self.match_in_pattern(self.text[mismatch_index])\n            i = (mismatch_index - match_index)  # \u003c-- THIS HAS NO EFFECT\n    return positions\n```\n\nIn Python, reassigning the loop variable inside a `for` loop does not change the iteration. The next iteration always takes the next value from `range()`. This means:\n\n- The bad character shift is completely ignored\n- The algorithm checks **every position** sequentially\n- It behaves as brute-force O(nm), not Boyer-Moore O(n/m)\n- Results are correct, but performance is identical to naive search\n\n### Reproduction\n\n```python\nclass InstrumentedBMS(BoyerMooreSearch):\n    def bad_character_heuristic(self):\n        positions = []\n        self.iterations = 0\n        for i in range(self.textLen - self.patLen + 1):\n            self.iterations += 1\n            mismatch_index = self.mismatch_in_text(i)\n            if mismatch_index == -1:\n                positions.append(i)\n            else:\n                match_index = self.match_in_pattern(self.text[mismatch_index])\n                i = (mismatch_index - match_index)\n        return positions\n\ntext = \"ABCDEFGHIJKLMNOPABCDEFGHIJKLMNOP\"  # 32 chars\npattern = \"MNOP\"\nbms = InstrumentedBMS(text, pattern)\npositions = bms.bad_character_heuristic()\nprint(f\"Iterations: {bms.iterations}\")  # 29 (brute-force)\nprint(f\"Expected for BM: ~8\")           # should skip\n```\n\nOutput: `Iterations: 29` — same as brute-force. The shift assignment is dead code.\n\n### Suggested Fix\n\nReplace `for` loop with `while` loop to allow the shift to take effect:\n\n```python\ndef bad_character_heuristic(self) -> list[int]:\n    positions = []\n    i = 0\n    while i \u003c= self.textLen - self.patLen:\n        mismatch_index = self.mismatch_in_text(i)\n        if mismatch_index == -1:\n            positions.append(i)\n            i += 1\n        else:\n            match_index = self.match_in_pattern(self.text[mismatch_index])\n            i = max(i + 1, mismatch_index - match_index)\n    return positions\n```\n\n### Impact\n\nThis repository has 190k+ stars and is widely used as an educational reference. Students copying this implementation believe they have a Boyer-Moore algorithm with O(n/m) average performance, but actually have O(nm) brute-force search.\n\nFound during systematic algorithm audit: https://github.com/devladpopov/algorithm-autopsy","author":{"url":"https://github.com/devladpopov","@type":"Person","name":"devladpopov"},"datePublished":"2026-06-21T18:13:26Z","url":"https://github.com/TheAlgorithms/Python/issues/14844"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2e686513-8e9d-2e3e-0f6c-102fb784b2c6
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9242:1ACD9:7371E:A38D6:6AFB73E5
html-safe-noncef80bbefa0bda1b88756474b0bc129de269f5c42cb6a4cf7a9f5456390653969c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjQyOjFBQ0Q5OjczNzFFOkEzOEQ2OjZBRkI3M0U1IiwidmlzaXRvcl9pZCI6IjI2NTAxMDg0ODU0NDEzODU0NDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac714b3b022405a3d41fdb3a303599882f8a60a4d86658ebea573105b293a4e566
hovercard-subject-tagissue:4711472578
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/TheAlgorithms/Python/14844/issue_layout
twitter:imagehttps://opengraph.githubassets.com/60902fe112de22bdadbd67e89a478c7581525c0c313dbbc4fb0fa7fee3d7aa4a/TheAlgorithms/Python/issues/14844
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/60902fe112de22bdadbd67e89a478c7581525c0c313dbbc4fb0fa7fee3d7aa4a/TheAlgorithms/Python/issues/14844
og:image:altDescription In strings/boyer_moore_search.py, the bad_character_heuristic() method attempts to skip positions using the bad character rule, but the shift has no effect because it reassigns the for-...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedevladpopov
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
go-importgithub.com/TheAlgorithms/Python git https://github.com/TheAlgorithms/Python.git
octolytics-dimension-user_id20487725
octolytics-dimension-user_loginTheAlgorithms
octolytics-dimension-repository_id63476337
octolytics-dimension-repository_nwoTheAlgorithms/Python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id63476337
octolytics-dimension-repository_network_root_nwoTheAlgorithms/Python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/TheAlgorithms/Python/issues/14844#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FTheAlgorithms%2FPython%2Fissues%2F14844
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FTheAlgorithms%2FPython%2Fissues%2F14844
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=TheAlgorithms%2FPython
Reloadhttps://github.com/TheAlgorithms/Python/issues/14844
Reloadhttps://github.com/TheAlgorithms/Python/issues/14844
Reloadhttps://github.com/TheAlgorithms/Python/issues/14844
TheAlgorithmshttps://github.com/TheAlgorithms
Pythonhttps://github.com/TheAlgorithms/Python
Codehttps://github.com/TheAlgorithms/Python
Issues14 (14)https://github.com/TheAlgorithms/Python/issues
Pull requests104 (104)https://github.com/TheAlgorithms/Python/pulls
Discussionshttps://github.com/TheAlgorithms/Python/discussions
Actionshttps://github.com/TheAlgorithms/Python/actions
Projectshttps://github.com/TheAlgorithms/Python/projects
Wikihttps://github.com/TheAlgorithms/Python/wiki
Security and qualityhttps://github.com/TheAlgorithms/Python/security
Insightshttps://github.com/TheAlgorithms/Python/pulse
https://github.com/TheAlgorithms/Python
New issuehttps://github.com/login?return_to=https://github.com/TheAlgorithms/Python/issues/14844
New issuehttps://github.com/login?return_to=https://github.com/TheAlgorithms/Python/issues/14844
#14848https://github.com/TheAlgorithms/Python/pull/14848
Bug: Boyer-Moore bad character shift has no effect (for-loop variable reassignment)https://github.com/TheAlgorithms/Python/issues/14844#top
#14848https://github.com/TheAlgorithms/Python/pull/14848
bughttps://github.com/TheAlgorithms/Python/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/devladpopov
devladpopovhttps://github.com/devladpopov
on Jun 21, 2026https://github.com/TheAlgorithms/Python/issues/14844#issue-4711472578
https://github.com/devladpopov/algorithm-autopsyhttps://github.com/devladpopov/algorithm-autopsy
paulxg12https://github.com/paulxg12
on Jun 23, 2026https://github.com/TheAlgorithms/Python/issues/14844#event-27106302851
Fix Boyer-Moore bad character shift to use while loophttps://github.com/paulxg12/Python/commit/a4db14b49914b1e6ff180a2591ca6b0f0c7fa863
https://docs.github.com/articles/closing-issues-via-commit-messages
a4db14bhttps://github.com/paulxg12/Python/commit/a4db14b49914b1e6ff180a2591ca6b0f0c7fa863
cclausshttps://github.com/cclauss
bughttps://github.com/TheAlgorithms/Python/issues?q=state%3Aopen%20label%3A%22bug%22
on Sep 10, 2026https://github.com/TheAlgorithms/Python/issues/14844#event-30883743097
cclausshttps://github.com/cclauss
completedhttps://github.com/TheAlgorithms/Python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#14848https://github.com/TheAlgorithms/Python/pull/14848
on Sep 10, 2026https://github.com/TheAlgorithms/Python/issues/14844#event-30895456214
Sign up for freehttps://github.com/signup?return_to=https://github.com/TheAlgorithms/Python/issues/14844
Sign in to commenthttps://github.com/login?return_to=https://github.com/TheAlgorithms/Python/issues/14844
bughttps://github.com/TheAlgorithms/Python/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.