Title: Bug: Boyer-Moore bad character shift has no effect (for-loop variable reassignment) · Issue #14844 · TheAlgorithms/Python · GitHub
Open Graph Title: Bug: Boyer-Moore bad character shift has no effect (for-loop variable reassignment) · Issue #14844 · TheAlgorithms/Python
X Title: Bug: Boyer-Moore bad character shift has no effect (for-loop variable reassignment) · Issue #14844 · TheAlgorithms/Python
Description: Description In strings/boyer_moore_search.py, the bad_character_heuristic() method attempts to skip positions using the bad character rule, but the shift has no effect because it reassigns the for-loop variable i: def bad_character_heuri...
Open Graph Description: Description In strings/boyer_moore_search.py, the bad_character_heuristic() method attempts to skip positions using the bad character rule, but the shift has no effect because it reassigns the for-...
X Description: Description In strings/boyer_moore_search.py, the bad_character_heuristic() method attempts to skip positions using the bad character rule, but the shift has no effect because it reassigns the for-...
Opengraph URL: https://github.com/TheAlgorithms/Python/issues/14844
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bug: Boyer-Moore bad character shift has no effect (for-loop variable reassignment)","articleBody":"### Description\n\nIn `strings/boyer_moore_search.py`, the `bad_character_heuristic()` method attempts to skip positions using the bad character rule, but the shift has **no effect** because it reassigns the `for`-loop variable `i`:\n\n```python\ndef bad_character_heuristic(self) -> list[int]:\n positions = []\n for i in range(self.textLen - self.patLen + 1):\n mismatch_index = self.mismatch_in_text(i)\n if mismatch_index == -1:\n positions.append(i)\n else:\n match_index = self.match_in_pattern(self.text[mismatch_index])\n i = (mismatch_index - match_index) # \u003c-- THIS HAS NO EFFECT\n return positions\n```\n\nIn Python, reassigning the loop variable inside a `for` loop does not change the iteration. The next iteration always takes the next value from `range()`. This means:\n\n- The bad character shift is completely ignored\n- The algorithm checks **every position** sequentially\n- It behaves as brute-force O(nm), not Boyer-Moore O(n/m)\n- Results are correct, but performance is identical to naive search\n\n### Reproduction\n\n```python\nclass InstrumentedBMS(BoyerMooreSearch):\n def bad_character_heuristic(self):\n positions = []\n self.iterations = 0\n for i in range(self.textLen - self.patLen + 1):\n self.iterations += 1\n mismatch_index = self.mismatch_in_text(i)\n if mismatch_index == -1:\n positions.append(i)\n else:\n match_index = self.match_in_pattern(self.text[mismatch_index])\n i = (mismatch_index - match_index)\n return positions\n\ntext = \"ABCDEFGHIJKLMNOPABCDEFGHIJKLMNOP\" # 32 chars\npattern = \"MNOP\"\nbms = InstrumentedBMS(text, pattern)\npositions = bms.bad_character_heuristic()\nprint(f\"Iterations: {bms.iterations}\") # 29 (brute-force)\nprint(f\"Expected for BM: ~8\") # should skip\n```\n\nOutput: `Iterations: 29` — same as brute-force. The shift assignment is dead code.\n\n### Suggested Fix\n\nReplace `for` loop with `while` loop to allow the shift to take effect:\n\n```python\ndef bad_character_heuristic(self) -> list[int]:\n positions = []\n i = 0\n while i \u003c= self.textLen - self.patLen:\n mismatch_index = self.mismatch_in_text(i)\n if mismatch_index == -1:\n positions.append(i)\n i += 1\n else:\n match_index = self.match_in_pattern(self.text[mismatch_index])\n i = max(i + 1, mismatch_index - match_index)\n return positions\n```\n\n### Impact\n\nThis repository has 190k+ stars and is widely used as an educational reference. Students copying this implementation believe they have a Boyer-Moore algorithm with O(n/m) average performance, but actually have O(nm) brute-force search.\n\nFound during systematic algorithm audit: https://github.com/devladpopov/algorithm-autopsy","author":{"url":"https://github.com/devladpopov","@type":"Person","name":"devladpopov"},"datePublished":"2026-06-21T18:13:26Z","url":"https://github.com/TheAlgorithms/Python/issues/14844"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:2e686513-8e9d-2e3e-0f6c-102fb784b2c6 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9242:1ACD9:7371E:A38D6:6AFB73E5 |
| html-safe-nonce | f80bbefa0bda1b88756474b0bc129de269f5c42cb6a4cf7a9f5456390653969c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjQyOjFBQ0Q5OjczNzFFOkEzOEQ2OjZBRkI3M0U1IiwidmlzaXRvcl9pZCI6IjI2NTAxMDg0ODU0NDEzODU0NDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 714b3b022405a3d41fdb3a303599882f8a60a4d86658ebea573105b293a4e566 |
| hovercard-subject-tag | issue:4711472578 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/TheAlgorithms/Python/14844/issue_layout |
| twitter:image | https://opengraph.githubassets.com/60902fe112de22bdadbd67e89a478c7581525c0c313dbbc4fb0fa7fee3d7aa4a/TheAlgorithms/Python/issues/14844 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/60902fe112de22bdadbd67e89a478c7581525c0c313dbbc4fb0fa7fee3d7aa4a/TheAlgorithms/Python/issues/14844 |
| og:image:alt | Description In strings/boyer_moore_search.py, the bad_character_heuristic() method attempts to skip positions using the bad character rule, but the shift has no effect because it reassigns the for-... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | devladpopov |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48 |
| turbo-cache-control | no-preview |
| go-import | github.com/TheAlgorithms/Python git https://github.com/TheAlgorithms/Python.git |
| octolytics-dimension-user_id | 20487725 |
| octolytics-dimension-user_login | TheAlgorithms |
| octolytics-dimension-repository_id | 63476337 |
| octolytics-dimension-repository_nwo | TheAlgorithms/Python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 63476337 |
| octolytics-dimension-repository_network_root_nwo | TheAlgorithms/Python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2e8872b770cc4d5d0cc1f2026afab747a268e2ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width