René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[BUG]: MaxProductOfThree not working properly","articleBody":"### Description\n\nThe maxProductOfThree-function in Dynamic-Programming/MaxProductOfThree.js is not working properly when the values of the array vary around 0.\r\n\r\nI noticed something seemed off when I looked at the code for the function, and decided to test the function using random arrays of length 4, where the values varied between -3 and 3. The output was compared to the output of a function that calculated all possible products of 3 numbers in the array, and indeed the function produced incorrect outputs.\r\n\r\nExamples arrays that produce incorrect output:\r\n[-2,1,-1,1]: expected = 2, actual = -1.\r\n[-3,0,-1,1]: expected = 3, actual = 0.\r\n[-1,1,-1,1]: expected = 1, actual = -1.\n\n### Expected Behavior\n\nThe expected behavior of the function is to find the largest product that can be produced from 3 numbers of an array. Due to the implementation, it is currently not.\r\n\r\nExpected output of the following arrays of length 4:\r\n[-2,1,-1,1]: expected = 2.\r\n[-3,0,-1,1]: expected = 3.\r\n[-1,1,-1,1]: expected = 1.\n\n### Actual Behavior\n\nActual output of the arrays above:\r\n[-2,1,-1,1]: actual = -1.\r\n[-3,0,-1,1]: actual = 0.\r\n[-1,1,-1,1]: actual = -1.\n\n### Steps to reproduce (if applicable)\n\n1. Call the function maxProductOfThree with the input [-2, 1, -1, 1].\r\n2. Observe that the expected output is clearly 2, since (-2) * (-1) * 1 = 2\r\n3. Observe that the actual output is -1.\n\n### Additional information\n\nI suspect this has to do with the way the max and min variables are initialized to -1 in the function, instead of setting them to null to begin with.","author":{"url":"https://github.com/Xolvez","@type":"Person","name":"Xolvez"},"datePublished":"2023-02-18T15:02:03.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/1294/JavaScript/issues/1294"}