Title: fix(maths): canonicalize fraction components and normalize signs in ADTFraction by Bhumit267 · Pull Request #7766 · TheAlgorithms/Java · GitHub
Open Graph Title: fix(maths): canonicalize fraction components and normalize signs in ADTFraction by Bhumit267 · Pull Request #7766 · TheAlgorithms/Java
X Title: fix(maths): canonicalize fraction components and normalize signs in ADTFraction by Bhumit267 · Pull Request #7766 · TheAlgorithms/Java
Description: I have read CONTRIBUTING.md. This pull request is all my own work -- I have not plagiarized it. All filenames are in PascalCase. All functions and variable names follow Java naming conventions. All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations. All new algorithms include a corresponding test class that validates their functionality. All new code is formatted with clang-format -i --style=file path/to/your/file.java Fixes #7764 Description In ADTFraction.java, ADTFraction is defined as a Java record. Previously, the constructor only validated that the denominator was not zero, without reducing the fraction by the greatest common divisor (GCD) or normalizing negative signs to the numerator. This resulted in: Broken equals() and hashCode() contract: mathematically equivalent fractions (new ADTFraction(1, 2) and new ADTFraction(2, 4)) evaluated as not equal. Negative signs in the denominator were not normalized (1/-2 instead of -1/2), breaking equality checks against -1/2. Chained arithmetic operations in plus() and times() directly multiplied raw components, causing premature 32-bit signed integer overflow. Changes Added automatic fraction canonicalization (dividing both numerator and denominator by gcd(|a|, |b|)) in the compact constructor. Normalized signs so that the denominator is strictly positive (e.g. 3/-5 becomes -3/5, 0/5 becomes 0/1). Used 64-bit long intermediate variables during plus() and times() cross-multiplication to avoid integer overflow before GCD reduction. Added comprehensive unit tests in ADTFractionTest.java verifying reduction, sign normalization, and equality contracts. Verification mvn test -Dtest=ADTFractionTest passes (8/8 tests pass). mvn checkstyle:check passes with 0 violations.
Open Graph Description: I have read CONTRIBUTING.md. This pull request is all my own work -- I have not plagiarized it. All filenames are in PascalCase. All functions and variable names follow Java naming conventions. ...
X Description: I have read CONTRIBUTING.md. This pull request is all my own work -- I have not plagiarized it. All filenames are in PascalCase. All functions and variable names follow Java naming conventions. ...
Opengraph URL: https://github.com/TheAlgorithms/Java/pull/7766
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c0c58be3-a48c-0a05-b876-a19660c22c63 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AFAE:1EC9BC:3205BF1:3FD3035:6B01DA50 |
| html-safe-nonce | d8157d59ae02d5ea1ee51869496f15c980938753b2c8a8ebd1d9064245f474fc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkFFOjFFQzlCQzozMjA1QkYxOjNGRDMwMzU6NkIwMURBNTAiLCJ2aXNpdG9yX2lkIjoiODc0NTEzNzc0MjQ1NjkzNzA0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ec58dd3a3da0307edf3b784739ba1db8a44661bafa2018f824c8c112b668e881 |
| hovercard-subject-tag | pull_request:5389175744 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/TheAlgorithms/Java/pull/7766/files |
| twitter:image | https://avatars.githubusercontent.com/u/178378365?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/178378365?s=400&v=4 |
| og:image:alt | I have read CONTRIBUTING.md. This pull request is all my own work -- I have not plagiarized it. All filenames are in PascalCase. All functions and variable names follow Java naming conventions. ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/TheAlgorithms/Java git https://github.com/TheAlgorithms/Java.git |
| octolytics-dimension-user_id | 20487725 |
| octolytics-dimension-user_login | TheAlgorithms |
| octolytics-dimension-repository_id | 63477660 |
| octolytics-dimension-repository_nwo | TheAlgorithms/Java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 63477660 |
| octolytics-dimension-repository_network_root_nwo | TheAlgorithms/Java |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width