René's URL Explorer Experiment


Title: [BUG] ADTFraction: Lack of fraction reduction causes equals()/hashCode() contract violations and integer overflow · Issue #7764 · TheAlgorithms/Java · GitHub

Open Graph Title: [BUG] ADTFraction: Lack of fraction reduction causes equals()/hashCode() contract violations and integer overflow · Issue #7764 · TheAlgorithms/Java

X Title: [BUG] ADTFraction: Lack of fraction reduction causes equals()/hashCode() contract violations and integer overflow · Issue #7764 · TheAlgorithms/Java

Description: Description In com.thealgorithms.maths.ADTFraction.java, the ADTFraction class is declared as a Java record: public record ADTFraction(int numerator, int denominator) The constructor only verifies that denominator != 0. It does not simpl...

Open Graph Description: Description In com.thealgorithms.maths.ADTFraction.java, the ADTFraction class is declared as a Java record: public record ADTFraction(int numerator, int denominator) The constructor only verifies ...

X Description: Description In com.thealgorithms.maths.ADTFraction.java, the ADTFraction class is declared as a Java record: public record ADTFraction(int numerator, int denominator) The constructor only verifies ...

Opengraph URL: https://github.com/TheAlgorithms/Java/issues/7764

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[BUG] ADTFraction: Lack of fraction reduction causes equals()/hashCode() contract violations and integer overflow","articleBody":"### Description\nIn `com.thealgorithms.maths.ADTFraction.java`, the `ADTFraction` class is declared as a Java `record`:\n```java\npublic record ADTFraction(int numerator, int denominator)\n```\nThe constructor only verifies that `denominator != 0`. It does not simplify fractions by dividing by the greatest common divisor (GCD), nor does it normalize signs so that the denominator is always positive.\n\nThis leads to several bugs:\n1. **Broken `equals()` and `hashCode()` contract:** Because `record` creates automatic field-based `equals()`, mathematically equivalent fractions evaluate as unequal:\n   `new ADTFraction(1, 2).equals(new ADTFraction(2, 4))` returns `false`.\n   `new ADTFraction(1, -2).equals(new ADTFraction(-1, 2))` returns `false`.\n2. **Premature 32-bit Integer Overflow:** In `plus()` and `times()`, numerators and denominators are directly multiplied without reduction:\n   ```java\n   var numerator = this.denominator * fraction.numerator + this.numerator * fraction.denominator;\n   var denominator = this.denominator * fraction.denominator;\n   ```\n   Repeatedly adding or multiplying fractions rapidly causes `int` overflow into negative values, even when the underlying mathematical fraction has small reduced components.\n3. **Inconsistent `toString()` formatting:** Negative denominators yield confusing representations such as `\"1/-2\"` rather than `\"-1/2\"`.\n\n### Steps to reproduce\nRun the following test case:\n```java\n@Test\nvoid testFractionEquivalenceAndSignNormalization() {\n    ADTFraction f1 = new ADTFraction(1, 2);\n    ADTFraction f2 = new ADTFraction(2, 4);\n    assertEquals(f1, f2, \"Equivalent fractions should be equal\");\n\n    ADTFraction neg1 = new ADTFraction(-1, 2);\n    ADTFraction neg2 = new ADTFraction(1, -2);\n    assertEquals(neg1, neg2, \"Fractions with negative signs in numerator or denominator should be equal\");\n}\n```\n\n### Expected behavior\n`ADTFraction` should reduce fractions to canonical form in its constructor (by dividing both `numerator` and `denominator` by their GCD) and normalize the denominator to always be positive.\n\n### Additional context\nSimplifying in the compact constructor ensures that all arithmetic operations produce canonical fractions and avoids premature integer overflows.\n","author":{"url":"https://github.com/Bhumit267","@type":"Person","name":"Bhumit267"},"datePublished":"2026-11-19T04:37:21Z","url":"https://github.com/TheAlgorithms/Java/issues/7764"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:3a3e9e41-a967-3f5c-4ac1-f69ee28a781e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB5E2:31D532:E1BA40:12B7E05:6B01D2F2
html-safe-nonce138168226e35606a7b38ae13fccc4b2b3e2efd87eb1754d73f1874e6e03fad15
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUUyOjMxRDUzMjpFMUJBNDA6MTJCN0UwNTo2QjAxRDJGMiIsInZpc2l0b3JfaWQiOiIzNzA4OTUwODgzMjA4Mzg1MjY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca86e04f441b2117a72308880b3fb09fe5e702188c76cad853eb417960189a410
hovercard-subject-tagissue:6482493731
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/TheAlgorithms/Java/7764/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b7107365bacd2dc83e40d7c2433f24f93e5a45125bab74660291f715db21b5d4/TheAlgorithms/Java/issues/7764
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b7107365bacd2dc83e40d7c2433f24f93e5a45125bab74660291f715db21b5d4/TheAlgorithms/Java/issues/7764
og:image:altDescription In com.thealgorithms.maths.ADTFraction.java, the ADTFraction class is declared as a Java record: public record ADTFraction(int numerator, int denominator) The constructor only verifies ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBhumit267
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/TheAlgorithms/Java git https://github.com/TheAlgorithms/Java.git
octolytics-dimension-user_id20487725
octolytics-dimension-user_loginTheAlgorithms
octolytics-dimension-repository_id63477660
octolytics-dimension-repository_nwoTheAlgorithms/Java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id63477660
octolytics-dimension-repository_network_root_nwoTheAlgorithms/Java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/TheAlgorithms/Java/issues/7764#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FTheAlgorithms%2FJava%2Fissues%2F7764
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FTheAlgorithms%2FJava%2Fissues%2F7764
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=TheAlgorithms%2FJava
Reloadhttps://github.com/TheAlgorithms/Java/issues/7764
Reloadhttps://github.com/TheAlgorithms/Java/issues/7764
Reloadhttps://github.com/TheAlgorithms/Java/issues/7764
TheAlgorithmshttps://github.com/TheAlgorithms
Javahttps://github.com/TheAlgorithms/Java
Codehttps://github.com/TheAlgorithms/Java
Issues5 (5)https://github.com/TheAlgorithms/Java/issues
Pull requests19 (19)https://github.com/TheAlgorithms/Java/pulls
Actionshttps://github.com/TheAlgorithms/Java/actions
Security and qualityhttps://github.com/TheAlgorithms/Java/security
Insightshttps://github.com/TheAlgorithms/Java/insights
https://github.com/TheAlgorithms/Java
New issuehttps://github.com/login?return_to=https://github.com/TheAlgorithms/Java/issues/7764
New issuehttps://github.com/login?return_to=https://github.com/TheAlgorithms/Java/issues/7764
#7766https://github.com/TheAlgorithms/Java/pull/7766
[BUG] ADTFraction: Lack of fraction reduction causes equals()/hashCode() contract violations and integer overflowhttps://github.com/TheAlgorithms/Java/issues/7764#top
#7766https://github.com/TheAlgorithms/Java/pull/7766
https://github.com/Bhumit267
Bhumit267https://github.com/Bhumit267
on Nov 19, 2026https://github.com/TheAlgorithms/Java/issues/7764#issue-6482493731
Sign up for freehttps://github.com/signup?return_to=https://github.com/TheAlgorithms/Java/issues/7764
Sign in to commenthttps://github.com/login?return_to=https://github.com/TheAlgorithms/Java/issues/7764
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.