Title: [BUG] ADTFraction: Lack of fraction reduction causes equals()/hashCode() contract violations and integer overflow · Issue #7764 · TheAlgorithms/Java · GitHub
Open Graph Title: [BUG] ADTFraction: Lack of fraction reduction causes equals()/hashCode() contract violations and integer overflow · Issue #7764 · TheAlgorithms/Java
X Title: [BUG] ADTFraction: Lack of fraction reduction causes equals()/hashCode() contract violations and integer overflow · Issue #7764 · TheAlgorithms/Java
Description: Description In com.thealgorithms.maths.ADTFraction.java, the ADTFraction class is declared as a Java record: public record ADTFraction(int numerator, int denominator) The constructor only verifies that denominator != 0. It does not simpl...
Open Graph Description: Description In com.thealgorithms.maths.ADTFraction.java, the ADTFraction class is declared as a Java record: public record ADTFraction(int numerator, int denominator) The constructor only verifies ...
X Description: Description In com.thealgorithms.maths.ADTFraction.java, the ADTFraction class is declared as a Java record: public record ADTFraction(int numerator, int denominator) The constructor only verifies ...
Opengraph URL: https://github.com/TheAlgorithms/Java/issues/7764
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[BUG] ADTFraction: Lack of fraction reduction causes equals()/hashCode() contract violations and integer overflow","articleBody":"### Description\nIn `com.thealgorithms.maths.ADTFraction.java`, the `ADTFraction` class is declared as a Java `record`:\n```java\npublic record ADTFraction(int numerator, int denominator)\n```\nThe constructor only verifies that `denominator != 0`. It does not simplify fractions by dividing by the greatest common divisor (GCD), nor does it normalize signs so that the denominator is always positive.\n\nThis leads to several bugs:\n1. **Broken `equals()` and `hashCode()` contract:** Because `record` creates automatic field-based `equals()`, mathematically equivalent fractions evaluate as unequal:\n `new ADTFraction(1, 2).equals(new ADTFraction(2, 4))` returns `false`.\n `new ADTFraction(1, -2).equals(new ADTFraction(-1, 2))` returns `false`.\n2. **Premature 32-bit Integer Overflow:** In `plus()` and `times()`, numerators and denominators are directly multiplied without reduction:\n ```java\n var numerator = this.denominator * fraction.numerator + this.numerator * fraction.denominator;\n var denominator = this.denominator * fraction.denominator;\n ```\n Repeatedly adding or multiplying fractions rapidly causes `int` overflow into negative values, even when the underlying mathematical fraction has small reduced components.\n3. **Inconsistent `toString()` formatting:** Negative denominators yield confusing representations such as `\"1/-2\"` rather than `\"-1/2\"`.\n\n### Steps to reproduce\nRun the following test case:\n```java\n@Test\nvoid testFractionEquivalenceAndSignNormalization() {\n ADTFraction f1 = new ADTFraction(1, 2);\n ADTFraction f2 = new ADTFraction(2, 4);\n assertEquals(f1, f2, \"Equivalent fractions should be equal\");\n\n ADTFraction neg1 = new ADTFraction(-1, 2);\n ADTFraction neg2 = new ADTFraction(1, -2);\n assertEquals(neg1, neg2, \"Fractions with negative signs in numerator or denominator should be equal\");\n}\n```\n\n### Expected behavior\n`ADTFraction` should reduce fractions to canonical form in its constructor (by dividing both `numerator` and `denominator` by their GCD) and normalize the denominator to always be positive.\n\n### Additional context\nSimplifying in the compact constructor ensures that all arithmetic operations produce canonical fractions and avoids premature integer overflows.\n","author":{"url":"https://github.com/Bhumit267","@type":"Person","name":"Bhumit267"},"datePublished":"2026-11-19T04:37:21Z","url":"https://github.com/TheAlgorithms/Java/issues/7764"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3a3e9e41-a967-3f5c-4ac1-f69ee28a781e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B5E2:31D532:E1BA40:12B7E05:6B01D2F2 |
| html-safe-nonce | 138168226e35606a7b38ae13fccc4b2b3e2efd87eb1754d73f1874e6e03fad15 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUUyOjMxRDUzMjpFMUJBNDA6MTJCN0UwNTo2QjAxRDJGMiIsInZpc2l0b3JfaWQiOiIzNzA4OTUwODgzMjA4Mzg1MjY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a86e04f441b2117a72308880b3fb09fe5e702188c76cad853eb417960189a410 |
| hovercard-subject-tag | issue:6482493731 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/TheAlgorithms/Java/7764/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b7107365bacd2dc83e40d7c2433f24f93e5a45125bab74660291f715db21b5d4/TheAlgorithms/Java/issues/7764 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b7107365bacd2dc83e40d7c2433f24f93e5a45125bab74660291f715db21b5d4/TheAlgorithms/Java/issues/7764 |
| og:image:alt | Description In com.thealgorithms.maths.ADTFraction.java, the ADTFraction class is declared as a Java record: public record ADTFraction(int numerator, int denominator) The constructor only verifies ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Bhumit267 |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/TheAlgorithms/Java git https://github.com/TheAlgorithms/Java.git |
| octolytics-dimension-user_id | 20487725 |
| octolytics-dimension-user_login | TheAlgorithms |
| octolytics-dimension-repository_id | 63477660 |
| octolytics-dimension-repository_nwo | TheAlgorithms/Java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 63477660 |
| octolytics-dimension-repository_network_root_nwo | TheAlgorithms/Java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width