René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Define focus restoration for controlled dialogs","articleBody":"## Evidence\n\nMerged PR #1205 moved shipping overlays onto the shared Radix-backed `Dialog`, but the controlled-dialog call sites do not register an opener with `DialogTrigger`.\n\nCurrent source has 16 controlled `Dialog` roots and no shipping `DialogTrigger` usage. Radix stores the trigger in `context.triggerRef`, then its modal `onCloseAutoFocus` handler prevents the browser default and calls `context.triggerRef.current?.focus()`. Without a registered trigger, that ref is null, so keyboard focus is not restored to the control that opened the dialog.\n\nThis is straightforward for colocated single openers, such as the NPM baseline package picker. It is not one mechanical change for every caller:\n\n- Some dialogs are controlled by an opener in a parent component.\n- The admin role removal dialog has one dynamic opener per table row.\n- Some design-system examples currently keep their opener outside the `Dialog` root.\n\nRepeated title, body, keyword, and open-PR searches found no existing owner. Issue #775 tracks unrelated empty-name, label, landmark, and skip-navigation findings.\n\n## Expected impact\n\nClosing a dialog should return keyboard and assistive-technology users to the control that opened it. Falling back to the document body loses their place and makes repeated actions harder.\n\n## Proposed direction\n\nAdopt one explicit controlled-dialog focus contract:\n\n1. Require `DialogTrigger asChild` for dialogs with one colocated opener.\n2. Add a typed shared API for external or dynamic openers, such as an explicit restore-focus ref or a narrowly exposed Radix close-auto-focus callback.\n3. Add a browser-level regression test that opens a dialog, closes it with Escape and the close button, and verifies focus returns to the actual opener.\n\n## Alternatives and tradeoffs\n\n- Requiring `DialogTrigger` everywhere keeps the shared API smallest, but dynamic table-row openers would need dialog state and content moved per row or another structural change.\n- Restoring the previously active element automatically inside `DialogContent` reduces call-site work, but it changes every dialog and can restore focus to a stale or unrelated node when opening is indirect.\n- Exposing only `onCloseAutoFocus` matches Radix directly, but every caller must repeat the same focus logic and the shared primitive cannot enforce consistency.\n\n## Decision needed\n\n@tannerlinsley, should the shared controlled-dialog contract support both `DialogTrigger` for colocated openers and an explicit restore-focus ref for external or dynamic openers, or should every dialog be restructured so one `DialogTrigger` always owns the opener?\n\nSource: #1205\n","author":{"url":"https://github.com/tannerlinsley","@type":"Person","name":"tannerlinsley"},"datePublished":"2026-09-01T15:36:42Z","url":"https://github.com/TanStack/tanstack.com/issues/1209"}