Title: fix(create): preserve ignored existing add-on targets by tannerlinsley · Pull Request #554 · TanStack/cli · GitHub
Open Graph Title: fix(create): preserve ignored existing add-on targets by tannerlinsley · Pull Request #554 · TanStack/cli
X Title: fix(create): preserve ignored existing add-on targets by tannerlinsley · Pull Request #554 · TanStack/cli
Description: Adding pnpm build settings could silently replace an existing .npmrc when it was ignored by git. Load existing output targets before merging so registry settings survive and overwrite confirmation also covers ignored or empty files. AI review notes: Five real filesystem regressions fail on current main and pass with this change. They cover preserving synthetic registry settings, cancellation without writes, an explicit root-check setting, an empty existing file and another ignored output target. The frozen install and affected lint pass. The unchanged normal hook built all 10 projects and passed 550 unit tests. All eight blocking Chrome e2e tests passed and the normal hook exited successfully. An actual compiled CLI blank scaffold outside the monorepo followed by the compiled addToApp flow retained synthetic registry settings and added the standalone pnpm setting. The install command was recorded rather than executed in that fixture. The normal browser gates separately cover installed generated apps and production-valid blank and AI builds without provider calls. No dependencies, public API or workflow changes. The compiled add-to-app module adds 683 raw bytes and 162 gzip bytes, measured against the accepted current-main build. This is a leaf-module measurement, not a whole-package or startup claim. Includes an @tanstack/create patch changeset. Publishing remains dependent on resolving the staged core artifact tracked in #551. Summary by CodeRabbit Bug Fixes Existing ignored files are now considered when adding pnpm workspace settings, helping preserve .npmrc registry configuration. You’re prompted before an ignored file is overwritten, and can cancel the operation to keep its contents. Empty ignored files are also recognized as existing, helping prevent unintended overwrites.
Open Graph Description: Adding pnpm build settings could silently replace an existing .npmrc when it was ignored by git. Load existing output targets before merging so registry settings survive and overwrite confirmation ...
X Description: Adding pnpm build settings could silently replace an existing .npmrc when it was ignored by git. Load existing output targets before merging so registry settings survive and overwrite confirmation ...
Opengraph URL: https://github.com/TanStack/cli/pull/554
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:756f7c6c-784f-9eb6-113a-32904fa29495 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EAA6:2A274A:25885B:33D587:6AF9A6DA |
| html-safe-nonce | a7e22d1ed7a0c6bb82afc84dbc2f55f82e6e567b6fbb77c66b5b3158db8c067d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUE2OjJBMjc0QToyNTg4NUI6MzNENTg3OjZBRjlBNkRBIiwidmlzaXRvcl9pZCI6IjYxMDkwOTc2MTc0NjE0NTQ1NTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 927b56bd9518a47e1a32d2ffb68ee0c5ef5459c710bd75398936eb9d55a4beeb |
| hovercard-subject-tag | pull_request:5143203993 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/TanStack/cli/pull/554/files |
| twitter:image | https://avatars.githubusercontent.com/u/5580297?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5580297?s=400&v=4 |
| og:image:alt | Adding pnpm build settings could silently replace an existing .npmrc when it was ignored by git. Load existing output targets before merging so registry settings survive and overwrite confirmation ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/TanStack/cli git https://github.com/TanStack/cli.git |
| octolytics-dimension-user_id | 72518640 |
| octolytics-dimension-user_login | TanStack |
| octolytics-dimension-repository_id | 932949058 |
| octolytics-dimension-repository_nwo | TanStack/cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 932949058 |
| octolytics-dimension-repository_network_root_nwo | TanStack/cli |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 072e34035c13c31543fba9f025cbbbda4210dae4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width