Title: Add units to reachability timeout/memory-limit flags by mtorp · Pull Request #236 · SocketDev/socket-python-cli · GitHub
Open Graph Title: Add units to reachability timeout/memory-limit flags by mtorp · Pull Request #236 · SocketDev/socket-python-cli
X Title: Add units to reachability timeout/memory-limit flags by mtorp · Pull Request #236 · SocketDev/socket-python-cli
Description: What Adds optional units to the reachability resource flags. The reachability engine (@coana-tech/cli) owns the unit grammar, parsing, and validation; the Python CLI passes the value through verbatim, so there is a single source of truth. --reach-analysis-timeout (alias --reach-timeout): optional duration unit s / m / h — e.g. 90s, 10m, 1h. --reach-analysis-memory-limit (alias --reach-memory-limit): optional size unit MB / GB, case-insensitive — e.g. 512MB, 8GB. --reach-concurrency is unchanged (unitless, >= 1). How Drop type=int on the four flags → accept raw strings; dataclass fields reach_analysis_timeout / reach_analysis_memory_limit become Optional[str]. Values forward verbatim to coana --analysis-timeout / --memory-limit. A defensive str() is kept at the coana forward point: config-file values bypass argparse's type= converter via set_defaults, so a JSON number can arrive as an int; str() is idempotent for unit strings ("10m" → "10m") and just guarantees subprocess receives a string. This is not unit parsing. The forward guard uses if x is not None (instead of truthiness) so an explicit empty string flows through and triggers coana's own error, rather than being silently dropped. Bump pinned DEFAULT_COANA_CLI_VERSION 15.3.24 → 15.5.0, which ships the unit parser. Backward compatibility Bare numbers still work exactly as before — seconds for the timeout, MB for the memory limit. This legacy form is no longer documented but continues to function. Docs / tests docs/cli-reference.md table rows updated (units + new pin); help text mirrors coana's wording. CHANGELOG.md entry added. Unit tests cover unit-bearing values, bare-int back-compat, and int→str coercion. Full unit suite green (341 passed). Part of the cross-repo "CLI reachability units" effort, aligned with the Coana CLI (which shipped the parser in @coana-tech/cli 15.5.0) and socket-cli.
Open Graph Description: What Adds optional units to the reachability resource flags. The reachability engine (@coana-tech/cli) owns the unit grammar, parsing, and validation; the Python CLI passes the value through verbat...
X Description: What Adds optional units to the reachability resource flags. The reachability engine (@coana-tech/cli) owns the unit grammar, parsing, and validation; the Python CLI passes the value through verbat...
Opengraph URL: https://github.com/SocketDev/socket-python-cli/pull/236
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:701ee099-cb31-dfb8-9687-88699b76f311 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BFA0:162B2:50A19F:72B95E:6A4E71AC |
| html-safe-nonce | c478dc2b03b12c821b24748940620cf382e3eaa77eb233ded75d8266769bf4d8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRkEwOjE2MkIyOjUwQTE5Rjo3MkI5NUU6NkE0RTcxQUMiLCJ2aXNpdG9yX2lkIjoiNzMxNTQ2MzkxNjk3MjA0NDcxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6d27ccce9b8b305d4ab87f74aacae82c05f9e7cd9c1b33f84b52978fb3f5ecd9 |
| hovercard-subject-tag | pull_request:3890902316 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/SocketDev/socket-python-cli/pull/236/files |
| twitter:image | https://avatars.githubusercontent.com/u/5579277?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5579277?s=400&v=4 |
| og:image:alt | What Adds optional units to the reachability resource flags. The reachability engine (@coana-tech/cli) owns the unit grammar, parsing, and validation; the Python CLI passes the value through verbat... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/SocketDev/socket-python-cli git https://github.com/SocketDev/socket-python-cli.git |
| octolytics-dimension-user_id | 69326764 |
| octolytics-dimension-user_login | SocketDev |
| octolytics-dimension-repository_id | 802230750 |
| octolytics-dimension-repository_nwo | SocketDev/socket-python-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 802230750 |
| octolytics-dimension-repository_network_root_nwo | SocketDev/socket-python-cli |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width