René's URL Explorer Experiment

Title: refactor: dedupe ecosystem dispatch, telemetry, API client, cleanup, get by mikolalysenko · Pull Request #88 · SocketDev/socket-patch · GitHub

Open Graph Title: refactor: dedupe ecosystem dispatch, telemetry, API client, cleanup, get by mikolalysenko · Pull Request #88 · SocketDev/socket-patch

X Title: refactor: dedupe ecosystem dispatch, telemetry, API client, cleanup, get by mikolalysenko · Pull Request #88 · SocketDev/socket-patch

Description: Summary Net ~718 lines removed across six files in the two core crates. No behavior changes; no public API breakage; all 1308 tests pass with no new warnings. ecosystem_dispatch.rs (953 → 556): macro-extracted the 8 per-ecosystem scan blocks duplicated between `find_packages_for_purls` and `find_packages_for_rollback`; the two functions now share a `dispatch_find` core that takes a `pypi_merge` callback for the only meaningful divergence. `commands/get.rs` (1901 → 1767): hoisted `report_error` / `print_json` / `empty_result_json` / `report_fetch_failure` / `write_all_patch_blobs` / `vulnerabilities_for_manifest` / `build_patch_record`; folded the three identical CVE/GHSA/PURL search match arms into one dispatch. `utils/telemetry.rs` (1107 → 1027): replaced ~18 hand-built `HashMap` constructions with a single `fire()` helper plus `serde_json::json!({...})` literals; each per-event tracker is now 3–5 lines instead of 10–20. `api/client.rs` (1336 → 1322): collapsed `search_patches_by_cve` / `by_ghsa` / `by_package` into a shared `search_patches_by_route(route, identifier)`. `api/blob_fetcher.rs` (871 → 833): derived `Default` for `FetchMissingBlobsResult`, introduced `all_failed_result` for the three blocker-on-mkdir branches, removed the redundant `empty_result()` helper. `utils/cleanup_blobs.rs` (585 → 540): unified `cleanup_unused_blobs` / `cleanup_unused_archives` behind a `cleanup_dir(dir, dry_run, is_used)` core taking a closure for the per-file "is this still in use" check. Test plan `cargo test --features cargo` — 499 lib tests + all integration tests pass `cargo test --features "cargo golang maven composer nuget deno"` — all tests pass under every feature gate `cargo build --tests --features "cargo golang maven composer nuget deno"` — no new warnings (only the two pre-existing snake_case warnings in `crawler_maven_e2e.rs`) CI on the PR 🤖 Generated with Claude Code

Open Graph Description: Summary Net ~718 lines removed across six files in the two core crates. No behavior changes; no public API breakage; all 1308 tests pass with no new warnings. ecosystem_dispatch.rs (953 → 556): ma...

X Description: Summary Net ~718 lines removed across six files in the two core crates. No behavior changes; no public API breakage; all 1308 tests pass with no new warnings. ecosystem_dispatch.rs (953 → 556): ma...

Opengraph URL: https://github.com/SocketDev/socket-patch/pull/88

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width