| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:71c55f38-6a7e-59a3-f463-7a7d8dc65095 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9C76:211793:D7341:11F4B9:6969B674 |
| html-safe-nonce | f763fa333fe59c05a282450771a781b6889f1b7e68a5ae0aa3aa5aab478c8b9a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Qzc2OjIxMTc5MzpENzM0MToxMUY0Qjk6Njk2OUI2NzQiLCJ2aXNpdG9yX2lkIjoiMzA2NjYwNDI4NDU4NTU1NTU3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4af90bc16857efd5bbad28583f6aecc4a8929890f631b4f4eba63e86cbffafa4 |
| hovercard-subject-tag | pull_request:179463694 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/Shopify/shopify_python/94/pull_request_layout |
| twitter:image | https://avatars.githubusercontent.com/u/8085?s=400&v=4 |
| twitter:card | summary |
| og:image | https://avatars.githubusercontent.com/u/8085?s=400&v=4 |
| og:image:alt | Addresses #22 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | alejandrolujan |
| hostname | github.com |
| expected-hostname | github.com |
| None | acedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056 |
| turbo-cache-control | no-preview |
| go-import | github.com/Shopify/shopify_python git https://github.com/Shopify/shopify_python.git |
| octolytics-dimension-user_id | 8085 |
| octolytics-dimension-user_login | Shopify |
| octolytics-dimension-repository_id | 82142052 |
| octolytics-dimension-repository_nwo | Shopify/shopify_python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 82142052 |
| octolytics-dimension-repository_network_root_nwo | Shopify/shopify_python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 83c08c21cdda978090dc44364b71aa5bc6dcea79 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/Shopify/shopify_python/pull/94#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FShopify%2Fshopify_python%2Fpull%2F94 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FShopify%2Fshopify_python%2Fpull%2F94 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=Shopify%2Fshopify_python |
| Reload | https://github.com/Shopify/shopify_python/pull/94 |
| Reload | https://github.com/Shopify/shopify_python/pull/94 |
| Reload | https://github.com/Shopify/shopify_python/pull/94 |
|
Shopify
| https://github.com/Shopify |
| shopify_python | https://github.com/Shopify/shopify_python |
|
Notifications
| https://github.com/login?return_to=%2FShopify%2Fshopify_python |
|
Fork
11
| https://github.com/login?return_to=%2FShopify%2Fshopify_python |
|
Star
67
| https://github.com/login?return_to=%2FShopify%2Fshopify_python |
|
Code
| https://github.com/Shopify/shopify_python |
|
Issues
10
| https://github.com/Shopify/shopify_python/issues |
|
Pull requests
6
| https://github.com/Shopify/shopify_python/pulls |
|
Actions
| https://github.com/Shopify/shopify_python/actions |
|
Projects
0
| https://github.com/Shopify/shopify_python/projects |
|
Models
| https://github.com/Shopify/shopify_python/models |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/Shopify/shopify_python/security |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/94 |
|
Insights
| https://github.com/Shopify/shopify_python/pulse |
|
Code
| https://github.com/Shopify/shopify_python |
|
Issues
| https://github.com/Shopify/shopify_python/issues |
|
Pull requests
| https://github.com/Shopify/shopify_python/pulls |
|
Actions
| https://github.com/Shopify/shopify_python/actions |
|
Projects
| https://github.com/Shopify/shopify_python/projects |
|
Models
| https://github.com/Shopify/shopify_python/models |
|
Security
| https://github.com/Shopify/shopify_python/security |
|
Insights
| https://github.com/Shopify/shopify_python/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FShopify%2Fshopify_python%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FShopify%2Fshopify_python%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/Shopify/shopify_python/pull/94#issue-comment-box |
| alejandrolujan | https://github.com/alejandrolujan |
| master | https://github.com/Shopify/shopify_python/tree/master |
| linter-forbid-sequence-str | https://github.com/Shopify/shopify_python/tree/linter-forbid-sequence-str |
|
Linter rule to forbid Sequence[str]
| https://github.com/Shopify/shopify_python/pull/94#top |
| alejandrolujan | https://github.com/alejandrolujan |
| master | https://github.com/Shopify/shopify_python/tree/master |
| linter-forbid-sequence-str | https://github.com/Shopify/shopify_python/tree/linter-forbid-sequence-str |
|
Conversation
2
| https://github.com/Shopify/shopify_python/pull/94 |
|
Commits
11
| https://github.com/Shopify/shopify_python/pull/94/commits |
|
Checks
0
| https://github.com/Shopify/shopify_python/pull/94/checks |
|
Files changed
| https://github.com/Shopify/shopify_python/pull/94/files |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/94 |
| https://github.co/hiddenchars |
| https://github.com/Shopify/shopify_python/pull/{{ revealButtonHref }} |
|
| https://github.com/alejandrolujan |
| alejandrolujan | https://github.com/alejandrolujan |
| Apr 4, 2018 | https://github.com/Shopify/shopify_python/pull/94#issue-311326812 |
| #22 | https://github.com/Shopify/shopify_python/issues/22 |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/94 |
| April 4, 2018 09:10 | https://github.com/Shopify/shopify_python/pull/94#commits-pushed-afdc9a0 |
| Refactoring check out of process_tokens | https://github.com/Shopify/shopify_python/pull/94/commits/afdc9a0b3f367c97aaf544eb3be75704a716559d |
| afdc9a0 | https://github.com/Shopify/shopify_python/pull/94/commits/afdc9a0b3f367c97aaf544eb3be75704a716559d |
| Adding check for Sequence[str] | https://github.com/Shopify/shopify_python/pull/94/commits/01173a760d889ff9fb344f8c10ebf6751b87a733 |
| 01173a7 | https://github.com/Shopify/shopify_python/pull/94/commits/01173a760d889ff9fb344f8c10ebf6751b87a733 |
| Adding more tests for different uses of type annotations | https://github.com/Shopify/shopify_python/pull/94/commits/831f936c01c232115d8e04a1e93f2a646ea76504 |
| 831f936 | https://github.com/Shopify/shopify_python/pull/94/commits/831f936c01c232115d8e04a1e93f2a646ea76504 |
| Added tests for Py3 catching of Sequence[str] | https://github.com/Shopify/shopify_python/pull/94/commits/585d3cb6bc55230118ce965659868cf44913286c |
| 585d3cb | https://github.com/Shopify/shopify_python/pull/94/commits/585d3cb6bc55230118ce965659868cf44913286c |
| https://github.com/alejandrolujan |
| alejandrolujan | https://github.com/alejandrolujan |
| Apr 4, 2018 | https://github.com/Shopify/shopify_python/pull/94#issuecomment-378685634 |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/94 |
| April 4, 2018 13:47 | https://github.com/Shopify/shopify_python/pull/94#commits-pushed-d6f552b |
| Dogfooding Sequence[str] to List[str] | https://github.com/Shopify/shopify_python/pull/94/commits/d6f552b081df20e1f44122673d2450f8bc2a071d |
| d6f552b | https://github.com/Shopify/shopify_python/pull/94/commits/d6f552b081df20e1f44122673d2450f8bc2a071d |
| Cleaning up linting violations | https://github.com/Shopify/shopify_python/pull/94/commits/3167b4f20c9051a1394a7f30d4808052bf29d0eb |
| 3167b4f | https://github.com/Shopify/shopify_python/pull/94/commits/3167b4f20c9051a1394a7f30d4808052bf29d0eb |
| Adjusting line numbers for expected messages | https://github.com/Shopify/shopify_python/pull/94/commits/f8204a6833200c0719390e7232b485dd8b63c52d |
| f8204a6 | https://github.com/Shopify/shopify_python/pull/94/commits/f8204a6833200c0719390e7232b485dd8b63c52d |
| Py3 support for sequence of string | https://github.com/Shopify/shopify_python/pull/94/commits/90d3f91ec4db922e927aa2d1f9e3606d48221917 |
| 90d3f91 | https://github.com/Shopify/shopify_python/pull/94/commits/90d3f91ec4db922e927aa2d1f9e3606d48221917 |
| Removing unnecessary newline | https://github.com/Shopify/shopify_python/pull/94/commits/78ea38886542dc8cc22733eacb4bff209b73765b |
| 78ea388 | https://github.com/Shopify/shopify_python/pull/94/commits/78ea38886542dc8cc22733eacb4bff209b73765b |
| Increasing the min python version requirement for :type annotation sy… | https://github.com/Shopify/shopify_python/pull/94/commits/78d83fc5a0e01805875630e4e25fa994d905a1ca |
| 78d83fc | https://github.com/Shopify/shopify_python/pull/94/commits/78d83fc5a0e01805875630e4e25fa994d905a1ca |
| Cleanup | https://github.com/Shopify/shopify_python/pull/94/commits/6f6cad6efa2776d8cb0485530d432ba92211df3c |
| 6f6cad6 | https://github.com/Shopify/shopify_python/pull/94/commits/6f6cad6efa2776d8cb0485530d432ba92211df3c |
| https://github.com/alejandrolujan |
| alejandrolujan | https://github.com/alejandrolujan |
| Apr 5, 2018 | https://github.com/Shopify/shopify_python/pull/94#event-1559461082 |
| https://github.com/alejandrolujan |
| alejandrolujan | https://github.com/alejandrolujan |
| JasonMWhite | https://github.com/JasonMWhite |
| cfournie | https://github.com/cfournie |
| April 5, 2018 18:51 | https://github.com/Shopify/shopify_python/pull/94#event-1559461289 |
| https://github.com/alejandrolujan |
| alejandrolujan | https://github.com/alejandrolujan |
| Apr 5, 2018 | https://github.com/Shopify/shopify_python/pull/94#event-1559461867 |
| https://github.com/alejandrolujan |
| alejandrolujan | https://github.com/alejandrolujan |
| Apr 5, 2018 | https://github.com/Shopify/shopify_python/pull/94#event-1559462231 |
| https://github.com/cfournie |
| cfournie | https://github.com/cfournie |
|
Apr 6, 2018
| https://github.com/Shopify/shopify_python/pull/94#pullrequestreview-110106103 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/94/files/6f6cad6efa2776d8cb0485530d432ba92211df3c |
| https://github.com/JasonMWhite |
| JasonMWhite | https://github.com/JasonMWhite |
|
Apr 6, 2018
| https://github.com/Shopify/shopify_python/pull/94#pullrequestreview-110107316 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/94/files/6f6cad6efa2776d8cb0485530d432ba92211df3c |
| shopify_python/git_utils.py | https://github.com/Shopify/shopify_python/pull/94/files/6f6cad6efa2776d8cb0485530d432ba92211df3c#diff-2b629dff02ceacfa0ddc2f5fd2d5dc9521b24e7a914cca403e6f6bc73760a9d1 |
| JasonMWhite | https://github.com/JasonMWhite |
| Apr 6, 2018 | https://github.com/Shopify/shopify_python/pull/94#discussion_r179793471 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/94 |
| https://github.com/alejandrolujan |
| alejandrolujan | https://github.com/alejandrolujan |
| 8c4a781 | https://github.com/Shopify/shopify_python/commit/8c4a781b705ef0682c15932fd7331b7f934ab89d |
| Apr 6, 2018 | https://github.com/Shopify/shopify_python/pull/94#event-1561502653 |
| https://github.com/alejandrolujan |
| alejandrolujan | https://github.com/alejandrolujan |
| April 6, 2018 18:36 | https://github.com/Shopify/shopify_python/pull/94#event-1561502744 |
| https://github.com/alejandrolujan |
| alejandrolujan | https://github.com/alejandrolujan |
|
Apr 6, 2018
| https://github.com/Shopify/shopify_python/pull/94#ref-issue-213447808 |
|
Linter: forbid typing.Sequence[str]
#22
| https://github.com/Shopify/shopify_python/issues/22 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FShopify%2Fshopify_python%2Fpull%2F94 |
|
| https://github.com/JasonMWhite |
|
JasonMWhite
| https://github.com/JasonMWhite |
|
| https://github.com/Shopify/shopify_python/pull/94/files/6f6cad6efa2776d8cb0485530d432ba92211df3c |
|
| https://github.com/cfournie |
|
cfournie
| https://github.com/cfournie |
|
| https://github.com/Shopify/shopify_python/pull/94/files/6f6cad6efa2776d8cb0485530d432ba92211df3c |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/94 |
|
| https://github.com/alejandrolujan |
|
| https://github.com/cfournie |
|
| https://github.com/JasonMWhite |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |