| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b1539745-cd71-7f77-baaa-28d87d93730d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C20C:A457C:15A2BAF:1CF6098:6969B675 |
| html-safe-nonce | 5713c2ac98e2a1ebcd2398ae90e78848706110cf44c5ff0f85135522dd135566 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjBDOkE0NTdDOjE1QTJCQUY6MUNGNjA5ODo2OTY5QjY3NSIsInZpc2l0b3JfaWQiOiI1NjY2MTU2ODM3MDM5ODc5Nzk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 369d11632e0d6548f4e06cf55bd23d1218446c2936bae541ee836aceabe04f45 |
| hovercard-subject-tag | pull_request:115189803 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/Shopify/shopify_python/57/pull_request_layout |
| twitter:image | https://avatars.githubusercontent.com/u/8085?s=400&v=4 |
| twitter:card | summary |
| og:image | https://avatars.githubusercontent.com/u/8085?s=400&v=4 |
| og:image:alt | Part of a rule on #36
simple-lambdas has been implemented.
This PR is for preference of Operator Fcns over Lambda Fcns (https://google.github.io/styleguide/pyguide.html?showone=Lambda_Functions#Lam... |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zeedann |
| hostname | github.com |
| expected-hostname | github.com |
| None | acedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056 |
| turbo-cache-control | no-preview |
| go-import | github.com/Shopify/shopify_python git https://github.com/Shopify/shopify_python.git |
| octolytics-dimension-user_id | 8085 |
| octolytics-dimension-user_login | Shopify |
| octolytics-dimension-repository_id | 82142052 |
| octolytics-dimension-repository_nwo | Shopify/shopify_python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 82142052 |
| octolytics-dimension-repository_network_root_nwo | Shopify/shopify_python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 83c08c21cdda978090dc44364b71aa5bc6dcea79 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/Shopify/shopify_python/pull/57#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FShopify%2Fshopify_python%2Fpull%2F57 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FShopify%2Fshopify_python%2Fpull%2F57 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=Shopify%2Fshopify_python |
| Reload | https://github.com/Shopify/shopify_python/pull/57 |
| Reload | https://github.com/Shopify/shopify_python/pull/57 |
| Reload | https://github.com/Shopify/shopify_python/pull/57 |
|
Shopify
| https://github.com/Shopify |
| shopify_python | https://github.com/Shopify/shopify_python |
|
Notifications
| https://github.com/login?return_to=%2FShopify%2Fshopify_python |
|
Fork
11
| https://github.com/login?return_to=%2FShopify%2Fshopify_python |
|
Star
67
| https://github.com/login?return_to=%2FShopify%2Fshopify_python |
|
Code
| https://github.com/Shopify/shopify_python |
|
Issues
10
| https://github.com/Shopify/shopify_python/issues |
|
Pull requests
6
| https://github.com/Shopify/shopify_python/pulls |
|
Actions
| https://github.com/Shopify/shopify_python/actions |
|
Projects
0
| https://github.com/Shopify/shopify_python/projects |
|
Models
| https://github.com/Shopify/shopify_python/models |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/Shopify/shopify_python/security |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
|
Insights
| https://github.com/Shopify/shopify_python/pulse |
|
Code
| https://github.com/Shopify/shopify_python |
|
Issues
| https://github.com/Shopify/shopify_python/issues |
|
Pull requests
| https://github.com/Shopify/shopify_python/pulls |
|
Actions
| https://github.com/Shopify/shopify_python/actions |
|
Projects
| https://github.com/Shopify/shopify_python/projects |
|
Models
| https://github.com/Shopify/shopify_python/models |
|
Security
| https://github.com/Shopify/shopify_python/security |
|
Insights
| https://github.com/Shopify/shopify_python/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FShopify%2Fshopify_python%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FShopify%2Fshopify_python%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/Shopify/shopify_python/pull/57#issue-comment-box |
| zeedann | https://github.com/zeedann |
| master | https://github.com/Shopify/shopify_python/tree/master |
| lambda | https://github.com/Shopify/shopify_python/tree/lambda |
|
prefer operator fncs to lambda fncs
| https://github.com/Shopify/shopify_python/pull/57#top |
| zeedann | https://github.com/zeedann |
| master | https://github.com/Shopify/shopify_python/tree/master |
| lambda | https://github.com/Shopify/shopify_python/tree/lambda |
|
Conversation
46
| https://github.com/Shopify/shopify_python/pull/57 |
|
Commits
1
| https://github.com/Shopify/shopify_python/pull/57/commits |
|
Checks
0
| https://github.com/Shopify/shopify_python/pull/57/checks |
|
Files changed
| https://github.com/Shopify/shopify_python/pull/57/files |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.co/hiddenchars |
| https://github.com/Shopify/shopify_python/pull/{{ revealButtonHref }} |
|
| https://github.com/zeedann |
| zeedann | https://github.com/zeedann |
| Apr 10, 2017 | https://github.com/Shopify/shopify_python/pull/57#issue-220767047 |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| #36 | https://github.com/Shopify/shopify_python/issues/36 |
| https://google.github.io/styleguide/pyguide.html?showone=Lambda_Functions#Lambda_Functions | https://google.github.io/styleguide/pyguide.html?showone=Lambda_Functions#Lambda_Functions |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/cfournie |
| cfournie | https://github.com/cfournie |
|
Apr 10, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-31961616 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files |
| shopify_python/google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-e22cf98d5486ac3fd548804beae96ddda0cb068510d622a08661b29859fd0985 |
| cfournie | https://github.com/cfournie |
| Apr 10, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r110765142 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/zeedann |
| zeedann | https://github.com/zeedann |
| force-pushed | https://github.com/Shopify/shopify_python/compare/2f09877952a79921866cf86c42ca4bbdeab4365e..8bfdf88579517928938a97a4f97b2d6e7f11bd90 |
| 2f09877 | https://github.com/Shopify/shopify_python/commit/2f09877952a79921866cf86c42ca4bbdeab4365e |
| 8bfdf88 | https://github.com/Shopify/shopify_python/commit/8bfdf88579517928938a97a4f97b2d6e7f11bd90 |
|
Compare
| https://github.com/Shopify/shopify_python/compare/2f09877952a79921866cf86c42ca4bbdeab4365e..8bfdf88579517928938a97a4f97b2d6e7f11bd90 |
| April 11, 2017 03:06 | https://github.com/Shopify/shopify_python/pull/57#event-1037558134 |
| https://github.com/cfournie |
| cfournie | https://github.com/cfournie |
|
Apr 11, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-32097529 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files |
| cfournie | https://github.com/cfournie |
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-32097529 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| shopify_python/google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-e22cf98d5486ac3fd548804beae96ddda0cb068510d622a08661b29859fd0985 |
| cfournie | https://github.com/cfournie |
| Apr 11, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r110894514 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| shopify_python/google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-e22cf98d5486ac3fd548804beae96ddda0cb068510d622a08661b29859fd0985 |
| cfournie | https://github.com/cfournie |
| Apr 11, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r110895170 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| shopify_python/google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-e22cf98d5486ac3fd548804beae96ddda0cb068510d622a08661b29859fd0985 |
| cfournie | https://github.com/cfournie |
| Apr 11, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r110896013 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| zeedann | https://github.com/zeedann |
| Apr 11, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r110902652 |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| cfournie | https://github.com/cfournie |
| Apr 11, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r110959424 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| erikwright | https://github.com/erikwright |
| Apr 11, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r110994103 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| zeedann | https://github.com/zeedann |
| Apr 11, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111010320 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @erikwright | https://github.com/erikwright |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| erikwright | https://github.com/erikwright |
| Apr 11, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111022682 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @zeedann | https://github.com/zeedann |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| zeedann | https://github.com/zeedann |
| Apr 11, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111025121 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| shopify_python/google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-e22cf98d5486ac3fd548804beae96ddda0cb068510d622a08661b29859fd0985 |
| cfournie | https://github.com/cfournie |
| Apr 11, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r110896618 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| zeedann | https://github.com/zeedann |
| Apr 11, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r110900343 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| cfournie | https://github.com/cfournie |
| Apr 11, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r110959162 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @erikwright | https://github.com/erikwright |
| @honkfestival | https://github.com/honkfestival |
| @JasonMWhite | https://github.com/JasonMWhite |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| JasonMWhite | https://github.com/JasonMWhite |
| Apr 11, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r110960708 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| zeedann | https://github.com/zeedann |
| Apr 11, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r110987607 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| erikwright | https://github.com/erikwright |
| Apr 11, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r110994430 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/zeedann |
| zeedann | https://github.com/zeedann |
| force-pushed | https://github.com/Shopify/shopify_python/compare/c038a32977c0739466143dd50ef22d1b1ac80dc2..bf3993a63775c72e060c3607a99951e33b54ac09 |
| c038a32 | https://github.com/Shopify/shopify_python/commit/c038a32977c0739466143dd50ef22d1b1ac80dc2 |
| bf3993a | https://github.com/Shopify/shopify_python/commit/bf3993a63775c72e060c3607a99951e33b54ac09 |
|
Compare
| https://github.com/Shopify/shopify_python/compare/c038a32977c0739466143dd50ef22d1b1ac80dc2..bf3993a63775c72e060c3607a99951e33b54ac09 |
| April 11, 2017 19:09 | https://github.com/Shopify/shopify_python/pull/57#event-1038936522 |
| https://github.com/zeedann |
| zeedann | https://github.com/zeedann |
| Apr 11, 2017 | https://github.com/Shopify/shopify_python/pull/57#issuecomment-293373215 |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/cfournie |
| cfournie | https://github.com/cfournie |
|
Apr 11, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-32205742 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files |
| tests/shopify_python/test_google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-f6a1d94c0fe808ec28be752dc09601e22aa585d3f0a49b24863987cd0f5310fa |
| cfournie | https://github.com/cfournie |
| Apr 11, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r110993566 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| erikwright | https://github.com/erikwright |
| Apr 11, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111028896 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/zeedann |
| zeedann | https://github.com/zeedann |
| force-pushed | https://github.com/Shopify/shopify_python/compare/a0256aa117f618fd2633e7ddc44a82dc116a5935..2c79ea4b14033a80eb51d3cbd3fed4a88b58d970 |
| a0256aa | https://github.com/Shopify/shopify_python/commit/a0256aa117f618fd2633e7ddc44a82dc116a5935 |
| 2c79ea4 | https://github.com/Shopify/shopify_python/commit/2c79ea4b14033a80eb51d3cbd3fed4a88b58d970 |
|
Compare
| https://github.com/Shopify/shopify_python/compare/a0256aa117f618fd2633e7ddc44a82dc116a5935..2c79ea4b14033a80eb51d3cbd3fed4a88b58d970 |
| April 12, 2017 02:16 | https://github.com/Shopify/shopify_python/pull/57#event-1039398392 |
| https://github.com/cfournie |
| cfournie | https://github.com/cfournie |
|
Apr 12, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-32371261 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files |
| tests/shopify_python/test_google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-f6a1d94c0fe808ec28be752dc09601e22aa585d3f0a49b24863987cd0f5310fa |
| cfournie | https://github.com/cfournie |
| Apr 12, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111147627 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| tests/shopify_python/test_google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-f6a1d94c0fe808ec28be752dc09601e22aa585d3f0a49b24863987cd0f5310fa |
| cfournie | https://github.com/cfournie |
| Apr 12, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111147756 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/cfournie |
| cfournie | https://github.com/cfournie |
|
Apr 12, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-32441917 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files |
| https://github.com/zeedann |
| zeedann | https://github.com/zeedann |
| Apr 12, 2017 | https://github.com/Shopify/shopify_python/pull/57#issuecomment-293661696 |
| @erikwright | https://github.com/erikwright |
| @JasonMWhite | https://github.com/JasonMWhite |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/erikwright |
| erikwright | https://github.com/erikwright |
|
Apr 12, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-32454947 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files |
| shopify_python/google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-e22cf98d5486ac3fd548804beae96ddda0cb068510d622a08661b29859fd0985 |
| erikwright | https://github.com/erikwright |
| Apr 12, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111224112 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/erikwright |
| erikwright | https://github.com/erikwright |
|
Apr 12, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-32457291 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files |
| shopify_python/google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-e22cf98d5486ac3fd548804beae96ddda0cb068510d622a08661b29859fd0985 |
| erikwright | https://github.com/erikwright |
| Apr 12, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111226299 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/erikwright |
| erikwright | https://github.com/erikwright |
|
Apr 12, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-32457419 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files |
| shopify_python/google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-e22cf98d5486ac3fd548804beae96ddda0cb068510d622a08661b29859fd0985 |
| erikwright | https://github.com/erikwright |
| Apr 12, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111226423 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/erikwright |
| erikwright | https://github.com/erikwright |
|
Apr 12, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-32458096 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files |
| tests/shopify_python/test_google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-f6a1d94c0fe808ec28be752dc09601e22aa585d3f0a49b24863987cd0f5310fa |
| erikwright | https://github.com/erikwright |
| Apr 12, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111227018 |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| erikwright | https://github.com/erikwright |
| Apr 12, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111228248 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| erikwright | https://github.com/erikwright |
| Apr 12, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111232114 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/erikwright |
| erikwright | https://github.com/erikwright |
|
Apr 12, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-32459001 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files |
| shopify_python/google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-e22cf98d5486ac3fd548804beae96ddda0cb068510d622a08661b29859fd0985 |
| erikwright | https://github.com/erikwright |
| Apr 12, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111227901 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| zeedann | https://github.com/zeedann |
| Apr 12, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111229624 |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/zeedann |
| zeedann | https://github.com/zeedann |
| force-pushed | https://github.com/Shopify/shopify_python/compare/931aa177999dc6a30458b981263c00dc5312efa8..ad73b171f24b9b395bb32a1f58ea6bede01b1c1f |
| 931aa17 | https://github.com/Shopify/shopify_python/commit/931aa177999dc6a30458b981263c00dc5312efa8 |
| ad73b17 | https://github.com/Shopify/shopify_python/commit/ad73b171f24b9b395bb32a1f58ea6bede01b1c1f |
|
Compare
| https://github.com/Shopify/shopify_python/compare/931aa177999dc6a30458b981263c00dc5312efa8..ad73b171f24b9b395bb32a1f58ea6bede01b1c1f |
| April 12, 2017 19:22 | https://github.com/Shopify/shopify_python/pull/57#event-1040754371 |
| https://github.com/zeedann |
| zeedann | https://github.com/zeedann |
| Apr 13, 2017 | https://github.com/Shopify/shopify_python/pull/57#issuecomment-293957224 |
| @erikwright | https://github.com/erikwright |
| @JasonMWhite | https://github.com/JasonMWhite |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/JasonMWhite |
| JasonMWhite | https://github.com/JasonMWhite |
|
Apr 17, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-33017832 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files |
| shopify_python/google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-e22cf98d5486ac3fd548804beae96ddda0cb068510d622a08661b29859fd0985 |
| JasonMWhite | https://github.com/JasonMWhite |
| Apr 17, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111754919 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/JasonMWhite |
| JasonMWhite | https://github.com/JasonMWhite |
|
Apr 17, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-33018196 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files |
| shopify_python/google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-e22cf98d5486ac3fd548804beae96ddda0cb068510d622a08661b29859fd0985 |
| JasonMWhite | https://github.com/JasonMWhite |
| Apr 17, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111755239 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/JasonMWhite |
| JasonMWhite | https://github.com/JasonMWhite |
|
Apr 17, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-33018375 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files |
| shopify_python/google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-e22cf98d5486ac3fd548804beae96ddda0cb068510d622a08661b29859fd0985 |
| JasonMWhite | https://github.com/JasonMWhite |
| Apr 17, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111755394 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/JasonMWhite |
| JasonMWhite | https://github.com/JasonMWhite |
|
Apr 17, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-33018564 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files |
| tests/shopify_python/test_google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-f6a1d94c0fe808ec28be752dc09601e22aa585d3f0a49b24863987cd0f5310fa |
| JasonMWhite | https://github.com/JasonMWhite |
| Apr 17, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111755552 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| JasonMWhite | https://github.com/JasonMWhite |
| Apr 17, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111755864 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/JasonMWhite |
| JasonMWhite | https://github.com/JasonMWhite |
|
Apr 17, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-33018602 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files |
| tests/shopify_python/test_google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-f6a1d94c0fe808ec28be752dc09601e22aa585d3f0a49b24863987cd0f5310fa |
| JasonMWhite | https://github.com/JasonMWhite |
| Apr 17, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111755590 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/JasonMWhite |
| JasonMWhite | https://github.com/JasonMWhite |
|
Apr 17, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-33019043 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files |
| tests/shopify_python/test_google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-f6a1d94c0fe808ec28be752dc09601e22aa585d3f0a49b24863987cd0f5310fa |
| JasonMWhite | https://github.com/JasonMWhite |
| Apr 17, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111756019 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/zeedann |
| zeedann | https://github.com/zeedann |
| force-pushed | https://github.com/Shopify/shopify_python/compare/75e1dd15239110c1906e5cdae69fb44b6ce149ea..6445c029dc681a58e157e85196b8fb5735c56c82 |
| 75e1dd1 | https://github.com/Shopify/shopify_python/commit/75e1dd15239110c1906e5cdae69fb44b6ce149ea |
| 6445c02 | https://github.com/Shopify/shopify_python/commit/6445c029dc681a58e157e85196b8fb5735c56c82 |
|
Compare
| https://github.com/Shopify/shopify_python/compare/75e1dd15239110c1906e5cdae69fb44b6ce149ea..6445c029dc681a58e157e85196b8fb5735c56c82 |
| April 17, 2017 17:38 | https://github.com/Shopify/shopify_python/pull/57#event-1045279051 |
| https://github.com/cfournie |
| cfournie | https://github.com/cfournie |
|
Apr 17, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-33051075 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files |
| shopify_python/google_styleguide.py | https://github.com/Shopify/shopify_python/pull/57/files#diff-e22cf98d5486ac3fd548804beae96ddda0cb068510d622a08661b29859fd0985 |
| cfournie | https://github.com/cfournie |
| Apr 17, 2017 | https://github.com/Shopify/shopify_python/pull/57#discussion_r111785408 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/zeedann |
| zeedann | https://github.com/zeedann |
| force-pushed | https://github.com/Shopify/shopify_python/compare/a9eac469a42d1d427f206d0460830beedc00bde8..2bd73c71d86342c063775919100e38da60074762 |
| a9eac46 | https://github.com/Shopify/shopify_python/commit/a9eac469a42d1d427f206d0460830beedc00bde8 |
| 2bd73c7 | https://github.com/Shopify/shopify_python/commit/2bd73c71d86342c063775919100e38da60074762 |
|
Compare
| https://github.com/Shopify/shopify_python/compare/a9eac469a42d1d427f206d0460830beedc00bde8..2bd73c71d86342c063775919100e38da60074762 |
| April 17, 2017 18:20 | https://github.com/Shopify/shopify_python/pull/57#event-1045343205 |
| https://github.com/zeedann |
| zeedann | https://github.com/zeedann |
| Apr 17, 2017 | https://github.com/Shopify/shopify_python/pull/57#issuecomment-294556452 |
| https://travis-ci.org/Shopify/shopify_python/jobs/222856408#L439 | https://travis-ci.org/Shopify/shopify_python/jobs/222856408#L439 |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/JasonMWhite |
| JasonMWhite | https://github.com/JasonMWhite |
| Apr 17, 2017 | https://github.com/Shopify/shopify_python/pull/57#issuecomment-294566689 |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/zeedann |
| zeedann | https://github.com/zeedann |
| force-pushed | https://github.com/Shopify/shopify_python/compare/fcc3f4ca8c5cd4ff08160d568c9ac07af688f3d0..80146faf80d979c5231ade8864f5813689154919 |
| fcc3f4c | https://github.com/Shopify/shopify_python/commit/fcc3f4ca8c5cd4ff08160d568c9ac07af688f3d0 |
| 80146fa | https://github.com/Shopify/shopify_python/commit/80146faf80d979c5231ade8864f5813689154919 |
|
Compare
| https://github.com/Shopify/shopify_python/compare/fcc3f4ca8c5cd4ff08160d568c9ac07af688f3d0..80146faf80d979c5231ade8864f5813689154919 |
| April 17, 2017 19:39 | https://github.com/Shopify/shopify_python/pull/57#event-1045452748 |
| https://github.com/zeedann |
| zeedann | https://github.com/zeedann |
| force-pushed | https://github.com/Shopify/shopify_python/compare/80146faf80d979c5231ade8864f5813689154919..5da34ddfcb86bad3ffa9fd474cc7e8fc898b9d0e |
| 80146fa | https://github.com/Shopify/shopify_python/commit/80146faf80d979c5231ade8864f5813689154919 |
| 5da34dd | https://github.com/Shopify/shopify_python/commit/5da34ddfcb86bad3ffa9fd474cc7e8fc898b9d0e |
|
Compare
| https://github.com/Shopify/shopify_python/compare/80146faf80d979c5231ade8864f5813689154919..5da34ddfcb86bad3ffa9fd474cc7e8fc898b9d0e |
| April 17, 2017 19:47 | https://github.com/Shopify/shopify_python/pull/57#event-1045464374 |
| https://github.com/zeedann |
| zeedann | https://github.com/zeedann |
| Apr 17, 2017 | https://github.com/Shopify/shopify_python/pull/57#issuecomment-294572621 |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/cfournie |
| cfournie | https://github.com/cfournie |
| Apr 17, 2017 | https://github.com/Shopify/shopify_python/pull/57#issuecomment-294574831 |
| re-ran master and it failed | https://travis-ci.org/Shopify/shopify_python/jobs/221730388 |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
|
| https://github.com/zeedann |
| updates | https://github.com/Shopify/shopify_python/pull/57/commits/fa13bb506351d425124915205fd5b6031f85f08f |
| fa13bb5 | https://github.com/Shopify/shopify_python/pull/57/commits/fa13bb506351d425124915205fd5b6031f85f08f |
| https://github.com/zeedann |
| zeedann | https://github.com/zeedann |
| force-pushed | https://github.com/Shopify/shopify_python/compare/42de6f174ff71321d40b7d6e119df29fb460bb18..fa13bb506351d425124915205fd5b6031f85f08f |
| 42de6f1 | https://github.com/Shopify/shopify_python/commit/42de6f174ff71321d40b7d6e119df29fb460bb18 |
| fa13bb5 | https://github.com/Shopify/shopify_python/commit/fa13bb506351d425124915205fd5b6031f85f08f |
|
Compare
| https://github.com/Shopify/shopify_python/compare/42de6f174ff71321d40b7d6e119df29fb460bb18..fa13bb506351d425124915205fd5b6031f85f08f |
| April 17, 2017 21:03 | https://github.com/Shopify/shopify_python/pull/57#event-1045573979 |
| https://github.com/zeedann |
| zeedann | https://github.com/zeedann |
| Apr 17, 2017 | https://github.com/Shopify/shopify_python/pull/57#issuecomment-294593251 |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| @cfournie | https://github.com/cfournie |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/zeedann |
| zeedann | https://github.com/zeedann |
| Apr 20, 2017 | https://github.com/Shopify/shopify_python/pull/57#issuecomment-295915659 |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
| https://github.com/JasonMWhite |
| JasonMWhite | https://github.com/JasonMWhite |
|
Apr 20, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-33893756 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files/fa13bb506351d425124915205fd5b6031f85f08f |
| https://github.com/cfournie |
| cfournie | https://github.com/cfournie |
|
Apr 21, 2017
| https://github.com/Shopify/shopify_python/pull/57#pullrequestreview-34015573 |
|
View reviewed changes
| https://github.com/Shopify/shopify_python/pull/57/files/fa13bb506351d425124915205fd5b6031f85f08f |
| https://github.com/zeedann |
| zeedann | https://github.com/zeedann |
| d8dac26 | https://github.com/Shopify/shopify_python/commit/d8dac261f8338af0289708d0b69b039f2f7bf58d |
| Apr 21, 2017 | https://github.com/Shopify/shopify_python/pull/57#event-1052458174 |
| https://github.com/cfournie |
| cfournie | https://github.com/cfournie |
| April 21, 2017 14:08 | https://github.com/Shopify/shopify_python/pull/57#event-1052498852 |
| https://github.com/JasonMWhite |
| JasonMWhite | https://github.com/JasonMWhite |
|
May 30, 2017
| https://github.com/Shopify/shopify_python/pull/57#ref-pullrequest-232318226 |
|
bump to 0.4.0
#71
| https://github.com/Shopify/shopify_python/pull/71 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FShopify%2Fshopify_python%2Fpull%2F57 |
|
| https://github.com/erikwright |
|
erikwright
| https://github.com/erikwright |
|
| https://github.com/Shopify/shopify_python/pull/57/files/8c03eb668326f6aa0e20fada711187cec08ddaff |
|
| https://github.com/cfournie |
|
cfournie
| https://github.com/cfournie |
|
| https://github.com/Shopify/shopify_python/pull/57/files/fa13bb506351d425124915205fd5b6031f85f08f |
|
| https://github.com/JasonMWhite |
|
JasonMWhite
| https://github.com/JasonMWhite |
|
| https://github.com/Shopify/shopify_python/pull/57/files/fa13bb506351d425124915205fd5b6031f85f08f |
| Please reload this page | https://github.com/Shopify/shopify_python/pull/57 |
|
| https://github.com/zeedann |
|
| https://github.com/JasonMWhite |
|
| https://github.com/cfournie |
|
| https://github.com/erikwright |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |