René's URL Explorer Experiment


Title: 2.x Upgrade Count() Issue · Issue #204 · SharpRepository/SharpRepository · GitHub

Open Graph Title: 2.x Upgrade Count() Issue · Issue #204 · SharpRepository/SharpRepository

X Title: 2.x Upgrade Count() Issue · Issue #204 · SharpRepository/SharpRepository

Description: I just tried upgrading our SharpRepository packages to 2.x and ran into an exception. I traced it down to SharpRepositoryBase.Count(ISpecification criteria). Compare that Count(ISpecification criteria) to 1.5.0.2's: https://github....

Open Graph Description: I just tried upgrading our SharpRepository packages to 2.x and ran into an exception. I traced it down to SharpRepositoryBase.Count(ISpecification criteria). Compare that Count(ISpecification...

X Description: I just tried upgrading our SharpRepository packages to 2.x and ran into an exception. I traced it down to SharpRepositoryBase.Count(ISpecification<T> criteria). Compare that Count(ISpecificat...

Opengraph URL: https://github.com/SharpRepository/SharpRepository/issues/204

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"2.x Upgrade Count() Issue","articleBody":"I just tried upgrading our SharpRepository packages to 2.x and ran into an exception.\r\n\r\nI traced it down to `SharpRepositoryBase.Count(ISpecification\u003cT\u003e criteria)`.\r\n\r\n![image](https://user-images.githubusercontent.com/811086/40168275-f3976400-5977-11e8-8707-8aca212928a4.png)\r\n\r\nCompare that `Count(ISpecification\u003cT\u003e criteria)` to 1.5.0.2's: https://github.com/SharpRepository/SharpRepository/blob/1.5.0.2/SharpRepository.Repository/RepositoryBase.cs#L826\r\n\r\nSo at some point all of the `Expression\u003c\u003e`s were compiled into `Func\u003c\u003e`s. I wondered why.\r\n\r\nSo, I tracked down the change in question: https://github.com/SharpRepository/SharpRepository/commit/8c1f9aaf5c23e82e91621adf8762ce6c71d620a9#diff-d24380b902ea13a619155432be3b7b18R841\r\n\r\nLooks like this was done as part of a change to handle differences in NETSTANDARD vs NETFX reflection/types. \r\n\r\nBut, in our case, broke what was working.\r\n\r\nIs that `Compile()` necessary? If not we should probably revert to the old method which doesn't throw (See below where `predicate` is the `Func\u003c\u003e`).\r\n\r\n![image](https://user-images.githubusercontent.com/811086/40167855-f1354d68-5976-11e8-8d95-0f70b84ef429.png)\r\n\r\n","author":{"url":"https://github.com/tynorton","@type":"Person","name":"tynorton"},"datePublished":"2018-05-17T09:15:29.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":7},"url":"https://github.com/204/SharpRepository/issues/204"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:61d2e66d-6862-9f77-bfd8-de4ac5bff8ea
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE5D2:1DFAA9:12AD2AF:18068C3:69743B6E
html-safe-nonced229ce8a0f1b9d75ef2f94977692e01f11d87c239c54fd646ef3a3d3f54b4a0c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUQyOjFERkFBOToxMkFEMkFGOjE4MDY4QzM6Njk3NDNCNkUiLCJ2aXNpdG9yX2lkIjoiNDAzOTUyNjc4OTMwOTI4MzE4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8ba633b78c5951b7a32f8f5179af74a266452fd227bb77d5cf21144ab27f2af0
hovercard-subject-tagissue:323937255
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/SharpRepository/SharpRepository/204/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d38fd7996e910cd04ced5aaed9de45429736973008a5ef0ec0201a5be98c4040/SharpRepository/SharpRepository/issues/204
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d38fd7996e910cd04ced5aaed9de45429736973008a5ef0ec0201a5be98c4040/SharpRepository/SharpRepository/issues/204
og:image:altI just tried upgrading our SharpRepository packages to 2.x and ran into an exception. I traced it down to SharpRepositoryBase.Count(ISpecification criteria). Compare that Count(ISpecification...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametynorton
hostnamegithub.com
expected-hostnamegithub.com
Nonee0b95d743b7672c9ac0e1032d5f117950182dc164a83434a7db86510e8f0b37c
turbo-cache-controlno-preview
go-importgithub.com/SharpRepository/SharpRepository git https://github.com/SharpRepository/SharpRepository.git
octolytics-dimension-user_id1801360
octolytics-dimension-user_loginSharpRepository
octolytics-dimension-repository_id4514047
octolytics-dimension-repository_nwoSharpRepository/SharpRepository
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id4514047
octolytics-dimension-repository_network_root_nwoSharpRepository/SharpRepository
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release56fe7e2e8de6e57740bca50402351ea656f7a4bf
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/SharpRepository/SharpRepository/issues/204#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FSharpRepository%2FSharpRepository%2Fissues%2F204
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FSharpRepository%2FSharpRepository%2Fissues%2F204
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=SharpRepository%2FSharpRepository
Reloadhttps://github.com/SharpRepository/SharpRepository/issues/204
Reloadhttps://github.com/SharpRepository/SharpRepository/issues/204
Reloadhttps://github.com/SharpRepository/SharpRepository/issues/204
SharpRepository https://github.com/SharpRepository
SharpRepositoryhttps://github.com/SharpRepository/SharpRepository
Notifications https://github.com/login?return_to=%2FSharpRepository%2FSharpRepository
Fork 165 https://github.com/login?return_to=%2FSharpRepository%2FSharpRepository
Star 658 https://github.com/login?return_to=%2FSharpRepository%2FSharpRepository
Code https://github.com/SharpRepository/SharpRepository
Issues 28 https://github.com/SharpRepository/SharpRepository/issues
Pull requests 10 https://github.com/SharpRepository/SharpRepository/pulls
Actions https://github.com/SharpRepository/SharpRepository/actions
Projects 0 https://github.com/SharpRepository/SharpRepository/projects
Wiki https://github.com/SharpRepository/SharpRepository/wiki
Security 0 https://github.com/SharpRepository/SharpRepository/security
Insights https://github.com/SharpRepository/SharpRepository/pulse
Code https://github.com/SharpRepository/SharpRepository
Issues https://github.com/SharpRepository/SharpRepository/issues
Pull requests https://github.com/SharpRepository/SharpRepository/pulls
Actions https://github.com/SharpRepository/SharpRepository/actions
Projects https://github.com/SharpRepository/SharpRepository/projects
Wiki https://github.com/SharpRepository/SharpRepository/wiki
Security https://github.com/SharpRepository/SharpRepository/security
Insights https://github.com/SharpRepository/SharpRepository/pulse
New issuehttps://github.com/login?return_to=https://github.com/SharpRepository/SharpRepository/issues/204
New issuehttps://github.com/login?return_to=https://github.com/SharpRepository/SharpRepository/issues/204
2.x Upgrade Count() Issuehttps://github.com/SharpRepository/SharpRepository/issues/204#top
bughttps://github.com/SharpRepository/SharpRepository/issues?q=state%3Aopen%20label%3A%22bug%22
testinghttps://github.com/SharpRepository/SharpRepository/issues?q=state%3Aopen%20label%3A%22testing%22
waiting feedbackhttps://github.com/SharpRepository/SharpRepository/issues?q=state%3Aopen%20label%3A%22waiting%20feedback%22
https://github.com/tynorton
https://github.com/tynorton
tynortonhttps://github.com/tynorton
on May 17, 2018https://github.com/SharpRepository/SharpRepository/issues/204#issue-323937255
https://user-images.githubusercontent.com/811086/40168275-f3976400-5977-11e8-8707-8aca212928a4.png
https://github.com/SharpRepository/SharpRepository/blob/1.5.0.2/SharpRepository.Repository/RepositoryBase.cs#L826https://github.com/SharpRepository/SharpRepository/blob/1.5.0.2/SharpRepository.Repository/RepositoryBase.cs#L826
8c1f9aa#diff-d24380b902ea13a619155432be3b7b18R841https://github.com/SharpRepository/SharpRepository/commit/8c1f9aaf5c23e82e91621adf8762ce6c71d620a9#diff-d24380b902ea13a619155432be3b7b18R841
https://user-images.githubusercontent.com/811086/40167855-f1354d68-5976-11e8-8d95-0f70b84ef429.png
bughttps://github.com/SharpRepository/SharpRepository/issues?q=state%3Aopen%20label%3A%22bug%22
testinghttps://github.com/SharpRepository/SharpRepository/issues?q=state%3Aopen%20label%3A%22testing%22
waiting feedbackhttps://github.com/SharpRepository/SharpRepository/issues?q=state%3Aopen%20label%3A%22waiting%20feedback%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.