René's URL Explorer Experiment


Title: Fix ALSA device not closing (#233) by chatziko · Pull Request #241 · Sendspin/sendspin-python-cli · GitHub

Open Graph Title: Fix ALSA device not closing (#233) by chatziko · Pull Request #241 · Sendspin/sendspin-python-cli

X Title: Fix ALSA device not closing (#233) by chatziko · Pull Request #241 · Sendspin/sendspin-python-cli

Description: Synchronized audio player for Sendspin servers. Contribute to Sendspin/sendspin-python-cli development by creating an account on GitHub.

Open Graph Description: This PR fixes the issue of ALSA staying open after stream end (#233), by calling the existing AudioPlayer::_close_stream from AudioStreamHandler::_on_stream_end. Tested on Linux, with this change t...

X Description: This PR fixes the issue of ALSA staying open after stream end (#233), by calling the existing AudioPlayer::_close_stream from AudioStreamHandler::_on_stream_end. Tested on Linux, with this change t...

Opengraph URL: https://github.com/Sendspin/sendspin-python-cli/pull/241

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:12608cee-9f2f-e5d3-e1e4-d11454802712
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8176:2B2806:F3B2C5:14CCA01:6AEC5A19
html-safe-nonceac6c8ee2667c209706f1422673245be3959a29fa5d7e3ad7f8e6deb588974f6b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTc2OjJCMjgwNjpGM0IyQzU6MTRDQ0EwMTo2QUVDNUExOSIsInZpc2l0b3JfaWQiOiI5OTM4ODYwNjE1MDAwNjIyMzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccb7635ad761eb51c57810e1e937d4ad95d16f7d8b29bd29c6bab8aaa5d91a67a
hovercard-subject-tagpull_request:3608354731
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/Sendspin/sendspin-python-cli/241/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4c5e2421c78aba8e8680119dcc5089a073f6643f25f33d15f71f49e416e9a746/Sendspin/sendspin-python-cli/pull/241
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4c5e2421c78aba8e8680119dcc5089a073f6643f25f33d15f71f49e416e9a746/Sendspin/sendspin-python-cli/pull/241
og:image:altThis PR fixes the issue of ALSA staying open after stream end (#233), by calling the existing AudioPlayer::_close_stream from AudioStreamHandler::_on_stream_end. Tested on Linux, with this change t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamechatziko
hostnamegithub.com
expected-hostnamegithub.com
None7d7db1e529b542851575839b1ff051a015ba048c1b57e26f6068abf951bdffcf
turbo-cache-controlno-cache
go-importgithub.com/Sendspin/sendspin-python-cli git https://github.com/Sendspin/sendspin-python-cli.git
octolytics-dimension-user_id214994244
octolytics-dimension-user_loginSendspin
octolytics-dimension-repository_id1109978202
octolytics-dimension-repository_nwoSendspin/sendspin-python-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1109978202
octolytics-dimension-repository_network_root_nwoSendspin/sendspin-python-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release61edfff9455d0559e1ba55a5c1197bc11672beb7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/Sendspin/sendspin-python-cli/pull/241#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FSendspin%2Fsendspin-python-cli%2Fpull%2F241
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FSendspin%2Fsendspin-python-cli%2Fpull%2F241
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=Sendspin%2Fsendspin-python-cli
Reloadhttps://github.com/Sendspin/sendspin-python-cli/pull/241
Reloadhttps://github.com/Sendspin/sendspin-python-cli/pull/241
Reloadhttps://github.com/Sendspin/sendspin-python-cli/pull/241
Sendspinhttps://github.com/Sendspin
sendspin-python-clihttps://github.com/Sendspin/sendspin-python-cli
Codehttps://github.com/Sendspin/sendspin-python-cli
Issues25 (25)https://github.com/Sendspin/sendspin-python-cli/issues
Pull requests11 (11)https://github.com/Sendspin/sendspin-python-cli/pulls
Actionshttps://github.com/Sendspin/sendspin-python-cli/actions
Projectshttps://github.com/Sendspin/sendspin-python-cli/projects
Security and qualityhttps://github.com/Sendspin/sendspin-python-cli/security
Insightshttps://github.com/Sendspin/sendspin-python-cli/pulse
https://github.com/Sendspin/sendspin-python-cli
balloobhttps://github.com/balloob
Sendspin:mainhttps://github.com/Sendspin/sendspin-python-cli/tree/main
chatziko:fix-alsa-close-devicehttps://github.com/chatziko/sendspin-cli/tree/fix-alsa-close-device
Conversationhttps://github.com/Sendspin/sendspin-python-cli/pull/241
Commits2 (2)https://github.com/Sendspin/sendspin-python-cli/pull/241/commits
Checkshttps://github.com/Sendspin/sendspin-python-cli/pull/241/checks
Files changedhttps://github.com/Sendspin/sendspin-python-cli/pull/241/files
Fix ALSA device not closing (#233)https://github.com/Sendspin/sendspin-python-cli/pull/241#top
balloobhttps://github.com/balloob
Sendspin:mainhttps://github.com/Sendspin/sendspin-python-cli/tree/main
chatziko:fix-alsa-close-devicehttps://github.com/chatziko/sendspin-cli/tree/fix-alsa-close-device
https://github.com/chatziko
chatzikohttps://github.com/chatziko
Apr 30, 2026https://github.com/Sendspin/sendspin-python-cli/pull/241#issue-4357607730
#233https://github.com/Sendspin/sendspin-python-cli/issues/233
Please reload this pagehttps://github.com/Sendspin/sendspin-python-cli/pull/241
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
April 30, 2026 11:12https://github.com/Sendspin/sendspin-python-cli/pull/241#event-25030955132
started reviewinghttps://github.com/Sendspin/sendspin-python-cli/sessions/b34e1ba1-ffdf-4b7c-8bc8-e430c2d8feab
chatzikohttps://github.com/chatziko
April 30, 2026 11:13https://github.com/Sendspin/sendspin-python-cli/pull/241#event-25030967733
View session https://github.com/Sendspin/sendspin-python-cli/sessions/b34e1ba1-ffdf-4b7c-8bc8-e430c2d8feab
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Apr 30, 2026 https://github.com/Sendspin/sendspin-python-cli/pull/241#pullrequestreview-4204647612
View reviewed changes https://github.com/Sendspin/sendspin-python-cli/pull/241/files
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/Sendspin/sendspin-python-cli/pull/241#pullrequestreview-4204647612
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Add Copilot custom instructionshttps://github.com/Sendspin/sendspin-cli/new/main?filename=.github/instructions/*.instructions.md
Learn how to get startedhttps://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot
Please reload this pagehttps://github.com/Sendspin/sendspin-python-cli/pull/241
sendspin/audio_connector.pyhttps://github.com/Sendspin/sendspin-python-cli/pull/241/files#diff-3421ff6530e137dcd05c843b76620f9e9c723c1ac747757e333d142930a076df
Please reload this pagehttps://github.com/Sendspin/sendspin-python-cli/pull/241
sendspin/audio_connector.pyhttps://github.com/Sendspin/sendspin-python-cli/pull/241/files#diff-3421ff6530e137dcd05c843b76620f9e9c723c1ac747757e333d142930a076df
Please reload this pagehttps://github.com/Sendspin/sendspin-python-cli/pull/241
sendspin/audio.pyhttps://github.com/Sendspin/sendspin-python-cli/pull/241/files#diff-3c6320801d183c6d0dab582c65ede68a37480b662dfee02712db7c9824804479
Please reload this pagehttps://github.com/Sendspin/sendspin-python-cli/pull/241
sendspin/audio_connector.pyhttps://github.com/Sendspin/sendspin-python-cli/pull/241/files#diff-3421ff6530e137dcd05c843b76620f9e9c723c1ac747757e333d142930a076df
Please reload this pagehttps://github.com/Sendspin/sendspin-python-cli/pull/241
https://github.com/chatziko
chatzikohttps://github.com/chatziko
Apr 30, 2026https://github.com/Sendspin/sendspin-python-cli/pull/241#event-25031720376
https://github.com/chatziko
chatzikohttps://github.com/chatziko
force-pushedhttps://github.com/Sendspin/sendspin-python-cli/compare/d07070c6e535e19fbd29aacf4e8c3be14d7be1c0..77fa84f2356a91c2f0b9e5426915a11eb74aad00
d07070chttps://github.com/Sendspin/sendspin-python-cli/commit/d07070c6e535e19fbd29aacf4e8c3be14d7be1c0
77fa84fhttps://github.com/Sendspin/sendspin-python-cli/commit/77fa84f2356a91c2f0b9e5426915a11eb74aad00
Compare https://github.com/Sendspin/sendspin-python-cli/compare/d07070c6e535e19fbd29aacf4e8c3be14d7be1c0..77fa84f2356a91c2f0b9e5426915a11eb74aad00
April 30, 2026 11:37https://github.com/Sendspin/sendspin-python-cli/pull/241#event-25031720473
https://github.com/chatziko
Fix ALSA device not closing (https://github.com/Sendspin/sendspin-python-cli/pull/241/commits/3ed20455e0f86ae6019d4827e844ae386cd4c27c
Sendspin#233https://github.com/Sendspin/sendspin-python-cli/issues/233
)https://github.com/Sendspin/sendspin-python-cli/pull/241/commits/3ed20455e0f86ae6019d4827e844ae386cd4c27c
3ed2045https://github.com/Sendspin/sendspin-python-cli/pull/241/commits/3ed20455e0f86ae6019d4827e844ae386cd4c27c
https://github.com/chatziko
chatzikohttps://github.com/chatziko
Apr 30, 2026https://github.com/Sendspin/sendspin-python-cli/pull/241#event-25031888917
https://github.com/claude
https://github.com/balloob
Simplify close_stream pathhttps://github.com/Sendspin/sendspin-python-cli/pull/241/commits/8f33aa3cb17eef6d23c1dfa080d40984c0e9dcce
8f33aa3https://github.com/Sendspin/sendspin-python-cli/pull/241/commits/8f33aa3cb17eef6d23c1dfa080d40984c0e9dcce
https://claude.ai/code/session_01KQj4He8YRjv1VW7ErRCAsvhttps://claude.ai/code/session_01KQj4He8YRjv1VW7ErRCAsv
https://github.com/balloob
balloobhttps://github.com/balloob
bugfix https://github.com/Sendspin/sendspin-python-cli/issues?q=state%3Aopen%20label%3Abugfix
May 3, 2026https://github.com/Sendspin/sendspin-python-cli/pull/241#event-25111087488
https://github.com/balloob
balloobhttps://github.com/balloob
May 3, 2026 https://github.com/Sendspin/sendspin-python-cli/pull/241#pullrequestreview-4216691805
View reviewed changes https://github.com/Sendspin/sendspin-python-cli/pull/241/files/8f33aa3cb17eef6d23c1dfa080d40984c0e9dcce
https://github.com/balloob
balloobhttps://github.com/balloob
82950ddhttps://github.com/Sendspin/sendspin-python-cli/commit/82950ddc5f921f15edbe4f76743714b69a919103
May 3, 2026https://github.com/Sendspin/sendspin-python-cli/pull/241#event-25111111251
Please reload this pagehttps://github.com/Sendspin/sendspin-python-cli/pull/241
https://github.com/balloob
balloobhttps://github.com/balloob
May 3, 2026 https://github.com/Sendspin/sendspin-python-cli/pull/241#ref-issue-4308202063
ALSA stream stays RUNNING indefinitely after audio stops #233 https://github.com/Sendspin/sendspin-python-cli/issues/233
https://github.co/hiddenchars
https://github.com/Sendspin/sendspin-python-cli/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FSendspin%2Fsendspin-python-cli%2Fpull%2F241
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
Learn more about Copilot code review.https://gh.io/copilot-code-review-docs
https://github.com/Sendspin/sendspin-python-cli/pull/241/files/d07070c6e535e19fbd29aacf4e8c3be14d7be1c0
https://github.com/balloob
balloob https://github.com/balloob
https://github.com/Sendspin/sendspin-python-cli/pull/241/files/8f33aa3cb17eef6d23c1dfa080d40984c0e9dcce
Please reload this pagehttps://github.com/Sendspin/sendspin-python-cli/pull/241
bugfix https://github.com/Sendspin/sendspin-python-cli/issues?q=state%3Aopen%20label%3Abugfix
Please reload this pagehttps://github.com/Sendspin/sendspin-python-cli/pull/241
https://github.com/chatziko
https://github.com/balloob
https://github.com/apps/copilot-pull-request-reviewer
https://github.com/claude
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.