Title: Expanded the testcase for GRPlatform>>secureHashFor: by jbrichau · Pull Request #182 · SeasideSt/Grease · GitHub
Open Graph Title: Expanded the testcase for GRPlatform>>secureHashFor: by jbrichau · Pull Request #182 · SeasideSt/Grease
X Title: Expanded the testcase for GRPlatform>>secureHashFor: by jbrichau · Pull Request #182 · SeasideSt/Grease
Description: The method GRPlatform>>secureHashFor: accepts both a String and a ByteArray as argument. The contents of the ByteArray can be any sequence of bytes, so it should not represent a valid UTF8 encoded String (for example). In this PR, we extend the test case to also cover the use of a ByteArray. In Seaside, all invocations of the method always passed a String instance as argument, until the e-tag implementation for the file libraries, which also uses it to generate a hash for any served file, which may include binary files (e.g. images). See SeasideSt/Seaside#1325.
Open Graph Description: The method GRPlatform>>secureHashFor: accepts both a String and a ByteArray as argument. The contents of the ByteArray can be any sequence of bytes, so it should not represent a valid UTF8 en...
X Description: The method GRPlatform>>secureHashFor: accepts both a String and a ByteArray as argument. The contents of the ByteArray can be any sequence of bytes, so it should not represent a valid...
Opengraph URL: https://github.com/SeasideSt/Grease/pull/182
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:19b6ae3f-4bf8-5721-0b15-3a0a1435bcdb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 923A:19BAB9:6717F:87AA7:696B3222 |
| html-safe-nonce | aeb3cbb82f1bc6c2978bdd25756563a4b0a28d610b58e52332fdcd858fed414a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjNBOjE5QkFCOTo2NzE3Rjo4N0FBNzo2OTZCMzIyMiIsInZpc2l0b3JfaWQiOiI2NzkwMTQwNDU4MzI0MTQ0Njc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | acc9d83ed55cfc7896caaef796bb123ed1e486f77ab56d9154c5ec2af5675515 |
| hovercard-subject-tag | pull_request:2258006237 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/SeasideSt/Grease/pull/182/files |
| twitter:image | https://avatars.githubusercontent.com/u/933094?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/933094?s=400&v=4 |
| og:image:alt | The method GRPlatform>>secureHashFor: accepts both a String and a ByteArray as argument. The contents of the ByteArray can be any sequence of bytes, so it should not represent a valid UTF8 en... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/SeasideSt/Grease git https://github.com/SeasideSt/Grease.git |
| octolytics-dimension-user_id | 8545049 |
| octolytics-dimension-user_login | SeasideSt |
| octolytics-dimension-repository_id | 16862014 |
| octolytics-dimension-repository_nwo | SeasideSt/Grease |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 16862014 |
| octolytics-dimension-repository_network_root_nwo | SeasideSt/Grease |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width