Title: Empty subcollection tests fail on latest Pharo and Squeak versions · Issue #147 · SeasideSt/Grease · GitHub
Open Graph Title: Empty subcollection tests fail on latest Pharo and Squeak versions · Issue #147 · SeasideSt/Grease
X Title: Empty subcollection tests fail on latest Pharo and Squeak versions · Issue #147 · SeasideSt/Grease
Description: Our tests for #beginsWithSubCollection: and #endsWithSubCollection: with empty arguments fail on the latest Pharo and Squeak versions. It looks like they changed the behavior of #beginsWith: and #endsWith: The current expectation seems t...
Open Graph Description: Our tests for #beginsWithSubCollection: and #endsWithSubCollection: with empty arguments fail on the latest Pharo and Squeak versions. It looks like they changed the behavior of #beginsWith: and #e...
X Description: Our tests for #beginsWithSubCollection: and #endsWithSubCollection: with empty arguments fail on the latest Pharo and Squeak versions. It looks like they changed the behavior of #beginsWith: and #e...
Opengraph URL: https://github.com/SeasideSt/Grease/issues/147
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Empty subcollection tests fail on latest Pharo and Squeak versions","articleBody":"Our tests for `#beginsWithSubCollection:` and `#endsWithSubCollection:` with empty arguments fail on the latest Pharo and Squeak versions. It looks like they changed the behavior of `#beginsWith:` and `#endsWith:`\r\n\r\nThe current expectation seems to be based on ANSI `#indexOfSubCollection:startingAt:` which states\r\n\r\n\u003e Answer 0 if no such subsequence is found in the receiver, or if targetSequence is empty.\r\n\r\nAn illustrative example\r\n\r\n```smalltalk\r\n#(1 2 3) beginsWithSubCollection: #(1). \"true\"\r\n#(1 2 3) beginsWithSubCollection: #(). \"false in Pharo 10 and Squeak\r\n5, true in Pharo 11 and Squeak 6 \"\r\n\r\n#(1 2 3) endsWithSubCollection: #(3). \"true\"\r\n#(1 2 3) endsWithSubCollection: #(). \"false in Pharo 10 and Squeak 5,\r\ntrue in Pharo 11 and Squeak 6 \"\r\n```\r\nThere are several possible solutions, the ones with the least chance of blast damage seem to be:\r\n- remove the empty argument tests, we don't seem to have any senders with empty arguments\r\n- introduce `#greaseBeginsWithSubCollection:` and `#greaseEndsWithSubCollection;`\r\n\r\nSee http://lists.squeakfoundation.org/pipermail/seaside-dev/2022-September/007363.html","author":{"url":"https://github.com/marschall","@type":"Person","name":"marschall"},"datePublished":"2022-09-02T16:18:37.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/147/Grease/issues/147"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e183fec1-90e5-b61d-20f1-a1ba63e6dd79 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BD08:1E3DA2:3580DAD:46C0F5A:69745E91 |
| html-safe-nonce | e37eb32e71aaff874b476fba3d8e407bf9f10581d5e0594c3faec90e008e0aa5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDA4OjFFM0RBMjozNTgwREFEOjQ2QzBGNUE6Njk3NDVFOTEiLCJ2aXNpdG9yX2lkIjoiMTEwNTU4MTU4NjU2NTU4NjU3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1da1f716d7d9c9c53a34aec23ba18836e090cdb7b159f04c30ed08d817d7aea2 |
| hovercard-subject-tag | issue:1360392279 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/SeasideSt/Grease/147/issue_layout |
| twitter:image | https://opengraph.githubassets.com/29c045763c01a159b99bc1d5bde185d94a2819e19d28d7e19e0c1e442c14ea40/SeasideSt/Grease/issues/147 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/29c045763c01a159b99bc1d5bde185d94a2819e19d28d7e19e0c1e442c14ea40/SeasideSt/Grease/issues/147 |
| og:image:alt | Our tests for #beginsWithSubCollection: and #endsWithSubCollection: with empty arguments fail on the latest Pharo and Squeak versions. It looks like they changed the behavior of #beginsWith: and #e... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | marschall |
| hostname | github.com |
| expected-hostname | github.com |
| None | e0b95d743b7672c9ac0e1032d5f117950182dc164a83434a7db86510e8f0b37c |
| turbo-cache-control | no-preview |
| go-import | github.com/SeasideSt/Grease git https://github.com/SeasideSt/Grease.git |
| octolytics-dimension-user_id | 8545049 |
| octolytics-dimension-user_login | SeasideSt |
| octolytics-dimension-repository_id | 16862014 |
| octolytics-dimension-repository_nwo | SeasideSt/Grease |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 16862014 |
| octolytics-dimension-repository_network_root_nwo | SeasideSt/Grease |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 56fe7e2e8de6e57740bca50402351ea656f7a4bf |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width