| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e5398437-dac8-ff7b-612b-cd452d398150 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AC8C:3969EC:8674FA:C00DDA:6AFAB301 |
| html-safe-nonce | 388ebef9706d8a5b050d3579b43a1d1e6936aea06abe904e54ea40dcfd0f1a01 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzhDOjM5NjlFQzo4Njc0RkE6QzAwRERBOjZBRkFCMzAxIiwidmlzaXRvcl9pZCI6IjQxMDU1NDM3NjUyNzQwNDcyMzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 554bfb858e2dd53f9b8dd1a33b5ccd6e8f59039e72634844b52549097e305298 |
| hovercard-subject-tag | pull_request:2359819843 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/SamRemis/smithy-python/1/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/32d24fa7a3ef9afe98bf9f75cda49d94d5a00d24c9d9feb834734587e9e90a72/SamRemis/smithy-python/pull/1 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/32d24fa7a3ef9afe98bf9f75cda49d94d5a00d24c9d9feb834734587e9e90a72/SamRemis/smithy-python/pull/1 |
| og:image:alt | Anti-review:
This PR is to take some notes on Alex's PR to help me get some understanding of what's going on in the smithy-python repo |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | SamRemis |
| hostname | github.com |
| expected-hostname | github.com |
| None | 612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7 |
| turbo-cache-control | no-cache |
| go-import | github.com/SamRemis/smithy-python git https://github.com/SamRemis/smithy-python.git |
| octolytics-dimension-user_id | 5881835 |
| octolytics-dimension-user_login | SamRemis |
| octolytics-dimension-repository_id | 927927875 |
| octolytics-dimension-repository_nwo | SamRemis/smithy-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 342067205 |
| octolytics-dimension-repository_parent_nwo | smithy-lang/smithy-python |
| octolytics-dimension-repository_network_root_id | 342067205 |
| octolytics-dimension-repository_network_root_nwo | smithy-lang/smithy-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 072e34035c13c31543fba9f025cbbbda4210dae4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/SamRemis/smithy-python/pull/1#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FSamRemis%2Fsmithy-python%2Fpull%2F1 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FSamRemis%2Fsmithy-python%2Fpull%2F1 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=SamRemis%2Fsmithy-python |
| Reload | https://github.com/SamRemis/smithy-python/pull/1 |
| Reload | https://github.com/SamRemis/smithy-python/pull/1 |
| Reload | https://github.com/SamRemis/smithy-python/pull/1 |
| SamRemis | https://github.com/SamRemis |
| smithy-python | https://github.com/SamRemis/smithy-python |
| Code | https://github.com/SamRemis/smithy-python |
| Pull requests12 (12) | https://github.com/SamRemis/smithy-python/pulls |
| Actions | https://github.com/SamRemis/smithy-python/actions |
| Projects | https://github.com/SamRemis/smithy-python/projects |
| Security and quality | https://github.com/SamRemis/smithy-python/security |
| Insights | https://github.com/SamRemis/smithy-python/pulse |
| https://github.com/SamRemis/smithy-python |
| SamRemis | https://github.com/SamRemis |
| develop | https://github.com/SamRemis/smithy-python/tree/develop |
| notes-pr | https://github.com/SamRemis/smithy-python/tree/notes-pr |
| Conversation | https://github.com/SamRemis/smithy-python/pull/1 |
| Commits4 (4) | https://github.com/SamRemis/smithy-python/pull/1/commits |
| Checks | https://github.com/SamRemis/smithy-python/pull/1/checks |
| Files changed | https://github.com/SamRemis/smithy-python/pull/1/files |
| Notes pr | https://github.com/SamRemis/smithy-python/pull/1#top |
| SamRemis | https://github.com/SamRemis |
| develop | https://github.com/SamRemis/smithy-python/tree/develop |
| notes-pr | https://github.com/SamRemis/smithy-python/tree/notes-pr |
|
| https://github.com/SamRemis |
| SamRemis | https://github.com/SamRemis |
| Feb 26, 2025 | https://github.com/SamRemis/smithy-python/pull/1#issue-2881835837 |
| Please reload this page | https://github.com/SamRemis/smithy-python/pull/1 |
| Please reload this page | https://github.com/SamRemis/smithy-python/pull/1 |
| alextwoods | https://github.com/alextwoods |
| February 25, 2025 10:48 | https://github.com/SamRemis/smithy-python/pull/1#commits-pushed-cb47f65 |
|
| https://github.com/alextwoods |
| WIP - add user agent interceptor/plugin | https://github.com/SamRemis/smithy-python/pull/1/commits/cb47f65a56f588dfca5f7fe705395927cdcb655e |
| cb47f65 | https://github.com/SamRemis/smithy-python/pull/1/commits/cb47f65a56f588dfca5f7fe705395927cdcb655e |
|
| https://github.com/alextwoods |
| Working implementation with basic user agent | https://github.com/SamRemis/smithy-python/pull/1/commits/91e82083c4811fc742101c7d0cdbd3ca5afdffe2 |
| 91e8208 | https://github.com/SamRemis/smithy-python/pull/1/commits/91e82083c4811fc742101c7d0cdbd3ca5afdffe2 |
|
| https://github.com/alextwoods |
| Fix pyright errors | https://github.com/SamRemis/smithy-python/pull/1/commits/d3b1d159ec78580307106f7e9dccf6cbd2cf8316 |
| d3b1d15 | https://github.com/SamRemis/smithy-python/pull/1/commits/d3b1d159ec78580307106f7e9dccf6cbd2cf8316 |
|
| https://github.com/alextwoods |
| Use short form license | https://github.com/SamRemis/smithy-python/pull/1/commits/203193392b4f21891e6a6194f81c66ca7b0e0a54 |
| 2031933 | https://github.com/SamRemis/smithy-python/pull/1/commits/203193392b4f21891e6a6194f81c66ca7b0e0a54 |
| https://github.com/SamRemis |
| SamRemis | https://github.com/SamRemis |
|
Feb 26, 2025
| https://github.com/SamRemis/smithy-python/pull/1#pullrequestreview-2644738163 |
|
View reviewed changes
| https://github.com/SamRemis/smithy-python/pull/1/files/203193392b4f21891e6a6194f81c66ca7b0e0a54 |
| ...en/aws/core/src/main/java/software/amazon/smithy/python/aws/codegen/AwsPythonDependency.java | https://github.com/SamRemis/smithy-python/pull/1/files/203193392b4f21891e6a6194f81c66ca7b0e0a54#diff-6e33f5309fcd3584b50a23042fee01730d2285682fa163c793a65db809d89c9a |
| SamRemis | https://github.com/SamRemis |
| Feb 26, 2025 | https://github.com/SamRemis/smithy-python/pull/1#discussion_r1971706641 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://smithy.io/javadoc/1.19.0/software/amazon/smithy/utils/SmithyUnstableApi.html | https://smithy.io/javadoc/1.19.0/software/amazon/smithy/utils/SmithyUnstableApi.html |
| Please reload this page | https://github.com/SamRemis/smithy-python/pull/1 |
| ...en/aws/core/src/main/java/software/amazon/smithy/python/aws/codegen/AwsPythonDependency.java | https://github.com/SamRemis/smithy-python/pull/1/files/203193392b4f21891e6a6194f81c66ca7b0e0a54#diff-6e33f5309fcd3584b50a23042fee01730d2285682fa163c793a65db809d89c9a |
| SamRemis | https://github.com/SamRemis |
| Feb 26, 2025 | https://github.com/SamRemis/smithy-python/pull/1#discussion_r1971711742 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/SamRemis/smithy-python/pull/1 |
| ...en/aws/core/src/main/java/software/amazon/smithy/python/aws/codegen/AwsPythonDependency.java | https://github.com/SamRemis/smithy-python/pull/1/files/203193392b4f21891e6a6194f81c66ca7b0e0a54#diff-6e33f5309fcd3584b50a23042fee01730d2285682fa163c793a65db809d89c9a |
| SamRemis | https://github.com/SamRemis |
| Feb 26, 2025 | https://github.com/SamRemis/smithy-python/pull/1#discussion_r1971715479 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| referenced later | https://github.com/SamRemis/smithy-python/pull/1/files#diff-12cb812e3528867ff119f3f7bd0ab5874ae9f1e164fd99769b28bb2127c91d51R44 |
| Please reload this page | https://github.com/SamRemis/smithy-python/pull/1 |
| ...ws/core/src/main/java/software/amazon/smithy/python/aws/codegen/AwsUserAgentIntegration.java | https://github.com/SamRemis/smithy-python/pull/1/files/203193392b4f21891e6a6194f81c66ca7b0e0a54#diff-12cb812e3528867ff119f3f7bd0ab5874ae9f1e164fd99769b28bb2127c91d51 |
| SamRemis | https://github.com/SamRemis |
| Feb 26, 2025 | https://github.com/SamRemis/smithy-python/pull/1#discussion_r1971722290 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/SamRemis/smithy-python/pull/1 |
| ...ws/core/src/main/java/software/amazon/smithy/python/aws/codegen/AwsUserAgentIntegration.java | https://github.com/SamRemis/smithy-python/pull/1/files/203193392b4f21891e6a6194f81c66ca7b0e0a54#diff-12cb812e3528867ff119f3f7bd0ab5874ae9f1e164fd99769b28bb2127c91d51 |
| SamRemis | https://github.com/SamRemis |
| Feb 26, 2025 | https://github.com/SamRemis/smithy-python/pull/1#discussion_r1971723879 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/SamRemis/smithy-python/pull/1 |
| ...ws/core/src/main/java/software/amazon/smithy/python/aws/codegen/AwsUserAgentIntegration.java | https://github.com/SamRemis/smithy-python/pull/1/files/203193392b4f21891e6a6194f81c66ca7b0e0a54#diff-12cb812e3528867ff119f3f7bd0ab5874ae9f1e164fd99769b28bb2127c91d51 |
| SamRemis | https://github.com/SamRemis |
| Feb 26, 2025 | https://github.com/SamRemis/smithy-python/pull/1#discussion_r1971729843 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| service provider interfaces | https://en.wikipedia.org/wiki/Service_provider_interface |
| referenced later in the META-INF file below | https://github.com/SamRemis/smithy-python/pull/1/files#diff-5ee91aae5fd907b079c1a59b45ff74b8e16033ddf8b37b1badff84c7279a12a3R8 |
| Please reload this page | https://github.com/SamRemis/smithy-python/pull/1 |
| ...ws/core/src/main/java/software/amazon/smithy/python/aws/codegen/AwsUserAgentIntegration.java | https://github.com/SamRemis/smithy-python/pull/1/files/203193392b4f21891e6a6194f81c66ca7b0e0a54#diff-12cb812e3528867ff119f3f7bd0ab5874ae9f1e164fd99769b28bb2127c91d51 |
| SamRemis | https://github.com/SamRemis |
| Feb 26, 2025 | https://github.com/SamRemis/smithy-python/pull/1#discussion_r1971735437 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| inside of smithy-python | https://github.com/smithy-lang/smithy-python/blob/095e1b92dee9821ed5356fdfb228b85cf59867f0/codegen/core/src/main/java/software/amazon/smithy/python/codegen/generators/ConfigGenerator.java#L37 |
| Please reload this page | https://github.com/SamRemis/smithy-python/pull/1 |
| ...ws/core/src/main/java/software/amazon/smithy/python/aws/codegen/AwsUserAgentIntegration.java | https://github.com/SamRemis/smithy-python/pull/1/files/203193392b4f21891e6a6194f81c66ca7b0e0a54#diff-12cb812e3528867ff119f3f7bd0ab5874ae9f1e164fd99769b28bb2127c91d51 |
| SamRemis | https://github.com/SamRemis |
| Feb 26, 2025 | https://github.com/SamRemis/smithy-python/pull/1#discussion_r1971737117 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| this new method | https://github.com/SamRemis/smithy-python/pull/1/files#diff-5d36dc2090f3a7077c4ab0801cbe73a6ebf2b6264f1a0306eb3fc2c3f5149191R10 |
| Please reload this page | https://github.com/SamRemis/smithy-python/pull/1 |
| https://github.com/SamRemis |
| SamRemis | https://github.com/SamRemis |
| force-pushed | https://github.com/SamRemis/smithy-python/compare/edec67be4ba17d101c63a1aa5e5f8b36d0d28a20..b42329f0e9c7ba6822ce32545fa71def1d0ded6c |
| edec67b | https://github.com/SamRemis/smithy-python/commit/edec67be4ba17d101c63a1aa5e5f8b36d0d28a20 |
| b42329f | https://github.com/SamRemis/smithy-python/commit/b42329f0e9c7ba6822ce32545fa71def1d0ded6c |
|
Compare
| https://github.com/SamRemis/smithy-python/compare/edec67be4ba17d101c63a1aa5e5f8b36d0d28a20..b42329f0e9c7ba6822ce32545fa71def1d0ded6c |
| April 9, 2025 15:09 | https://github.com/SamRemis/smithy-python/pull/1#event-17191467594 |
| https://github.co/hiddenchars |
| https://github.com/SamRemis/smithy-python/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FSamRemis%2Fsmithy-python%2Fpull%2F1 |
| Please reload this page | https://github.com/SamRemis/smithy-python/pull/1 |
| Please reload this page | https://github.com/SamRemis/smithy-python/pull/1 |
|
| https://github.com/SamRemis |
|
| https://github.com/alextwoods |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |