René's URL Explorer Experiment

Title: feat: skip state-sync for the `format` command by j-hartshorn · Pull Request #5804 · SQLMesh/sqlmesh · GitHub

Open Graph Title: feat: skip state-sync for the `format` command by j-hartshorn · Pull Request #5804 · SQLMesh/sqlmesh

X Title: feat: skip state-sync for the `format` command by j-hartshorn · Pull Request #5804 · SQLMesh/sqlmesh

Description: Description sqlmesh format previously required a reachable state-sync backend on every invocation, because Context.load() unconditionally merges remote-prod state into the local model registry whenever a config declares a project: name. That made the command unrunnable in CI jobs that have no credentials or network access to the state backend, even though formatting is a pure local operation - it parses each local file and re-prints the AST, never resolving references. This PR adds a load_state: bool = True parameter to GenericContext that gates the two if any(self._projects): state-merge blocks in Context.load(), and adds a LOCAL_ONLY_COMMANDS = ("format",) tuple in sqlmesh/cli/main.py that flips it to False for that subcommand. The default behaviour for every other command (plan, run, lint, diff, etc.) is unchanged. Scope note: this PR originally covered lint as well, but was narrowed after review (see discussion below). In multi-repo projects, lint results depend on models merged from prod state at load time - models owned by other repos aren't on disk, and skipping the merge flipped lint from pass to fail even with state credentials available (reproduced with examples/multi, where repo_2's silver.c selects from repo_1's bronze.a). lint therefore still loads state, locked in by a guard test, and the lint case in #5182 remains open. Verified end-to-end with a real config.yaml declaring a Postgres state connection via {{ env_var() }} with no env vars set: pre-PR, sqlmesh format exits 1 with psycopg2.OperationalError: could not translate host name. Post-PR, exit 0. One known caveat: Snowflake state connections under default authentication validate user/password at config-load time via SnowflakeConnectionConfig._validate_authenticator (sqlmesh/core/config/connection.py:633-638), which runs before this PR's gate. That pre-existing validator means a Snowflake-default-auth state config still requires placeholder user/password values to be set. Postgres, MySQL, MSSQL, and the other backends pass validation with placeholder values. Test Plan Seven tests across two files: tests/core/test_format.py::test_format_without_state_load (fast) - context.format(check=True) with load_state=False and a patched EngineAdapterStateSync.get_versions that raises. Asserts the patched method is never called. tests/cli/test_cli.py::test_format_runs_without_state (slow) - end-to-end via the CLI runner. tests/cli/test_cli.py::test_local_only_commands_skip_state_multiple_paths (slow) - same, invoked with two --paths, locking in that the gate applies regardless of invocation shape. tests/cli/test_cli.py::test_format_runs_without_state_multi_repo_partial (slow) - formats one repo of examples/multi whose upstream models live only in prod state; the shape that motivated narrowing the PR. tests/cli/test_cli.py::test_lint_still_loads_state (slow) - guard-rail for the narrowing. Spies on Context.__init__, asserts load_state=True is explicitly passed for lint, and asserts state sync is actually reached. tests/cli/test_cli.py::test_plan_still_loads_state (slow) - same guard for plan. Both verified non-vacuous by regression modes (deleting the kwarg from cli/main.py, and re-adding the command to LOCAL_ONLY_COMMANDS). tests/cli/test_cli.py::test_format_does_not_open_state_connection (slow) - most realistic CI scenario: a config.yaml declaring a Postgres state connection via {{ env_var() }} with all env vars unset. Verifies the gate prevents the connection. Commands run: make py-style - clean (ruff, ruff-format, mypy, valid migrations). Full test selection above - all passing.

Open Graph Description: Description sqlmesh format previously required a reachable state-sync backend on every invocation, because Context.load() unconditionally merges remote-prod state into the local model registry when...

X Description: Description sqlmesh format previously required a reachable state-sync backend on every invocation, because Context.load() unconditionally merges remote-prod state into the local model registry when...

Opengraph URL: https://github.com/SQLMesh/sqlmesh/pull/5804

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width