René's URL Explorer Experiment


Title: Fix: Make the janitor best effort by themisvaltinos · Pull Request #5802 · SQLMesh/sqlmesh · GitHub

Open Graph Title: Fix: Make the janitor best effort by themisvaltinos · Pull Request #5802 · SQLMesh/sqlmesh

X Title: Fix: Make the janitor best effort by themisvaltinos · Pull Request #5802 · SQLMesh/sqlmesh

Description: Scalable and efficient data transformation framework - backwards compatible with dbt. - Fix: Make the janitor best effort by themisvaltinos · Pull Request #5802 · SQLMesh/sqlmesh

Open Graph Description: This updates the janitor instead of stopping on the first drop failure, to attempt every cleanup operation and aggregates all failures into a single error raised at the end. The warn_on_delete_fail...

X Description: This updates the janitor instead of stopping on the first drop failure, to attempt every cleanup operation and aggregates all failures into a single error raised at the end. The warn_on_delete_fail...

Opengraph URL: https://github.com/SQLMesh/sqlmesh/pull/5802

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:28c0e297-176d-93a4-c1f3-7078ccfdac44
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8B82:2F704B:B6CD6B:FA8C96:6A4DC358
html-safe-nonceefc444bcc00a78aef914fd4507220e2d49262f739ae9fa06b209c17575463221
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjgyOjJGNzA0QjpCNkNENkI6RkE4Qzk2OjZBNERDMzU4IiwidmlzaXRvcl9pZCI6IjQ3NDk2NTExMjg2NTE0NjU1NjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb89d3aff57f8151bbb6ff1d94a1b42c26dc60cfa45b09617eb0d6f1c398290c3
hovercard-subject-tagpull_request:3722839119
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/SQLMesh/sqlmesh/5802/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9c61a9f5e43a313e535c6cf6e4904316fb400ee7cba07e1bc5cbac2228d39fe4/SQLMesh/sqlmesh/pull/5802
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9c61a9f5e43a313e535c6cf6e4904316fb400ee7cba07e1bc5cbac2228d39fe4/SQLMesh/sqlmesh/pull/5802
og:image:altThis updates the janitor instead of stopping on the first drop failure, to attempt every cleanup operation and aggregates all failures into a single error raised at the end. The warn_on_delete_fail...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamethemisvaltinos
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/SQLMesh/sqlmesh git https://github.com/SQLMesh/sqlmesh.git
octolytics-dimension-user_id265658263
octolytics-dimension-user_loginSQLMesh
octolytics-dimension-repository_id540527604
octolytics-dimension-repository_nwoSQLMesh/sqlmesh
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id540527604
octolytics-dimension-repository_network_root_nwoSQLMesh/sqlmesh
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/SQLMesh/sqlmesh/pull/5802#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FSQLMesh%2Fsqlmesh%2Fpull%2F5802
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FSQLMesh%2Fsqlmesh%2Fpull%2F5802
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=SQLMesh%2Fsqlmesh
Reloadhttps://github.com/SQLMesh/sqlmesh/pull/5802
Reloadhttps://github.com/SQLMesh/sqlmesh/pull/5802
Reloadhttps://github.com/SQLMesh/sqlmesh/pull/5802
Please reload this pagehttps://github.com/SQLMesh/sqlmesh/pull/5802
SQLMesh https://github.com/SQLMesh
sqlmeshhttps://github.com/SQLMesh/sqlmesh
Notifications https://github.com/login?return_to=%2FSQLMesh%2Fsqlmesh
Fork 414 https://github.com/login?return_to=%2FSQLMesh%2Fsqlmesh
Star 3.2k https://github.com/login?return_to=%2FSQLMesh%2Fsqlmesh
Code https://github.com/SQLMesh/sqlmesh
Issues 218 https://github.com/SQLMesh/sqlmesh/issues
Pull requests 46 https://github.com/SQLMesh/sqlmesh/pulls
Discussions https://github.com/SQLMesh/sqlmesh/discussions
Actions https://github.com/SQLMesh/sqlmesh/actions
Projects https://github.com/SQLMesh/sqlmesh/projects
Security and quality 0 https://github.com/SQLMesh/sqlmesh/security
Insights https://github.com/SQLMesh/sqlmesh/pulse
Code https://github.com/SQLMesh/sqlmesh
Issues https://github.com/SQLMesh/sqlmesh/issues
Pull requests https://github.com/SQLMesh/sqlmesh/pulls
Discussions https://github.com/SQLMesh/sqlmesh/discussions
Actions https://github.com/SQLMesh/sqlmesh/actions
Projects https://github.com/SQLMesh/sqlmesh/projects
Security and quality https://github.com/SQLMesh/sqlmesh/security
Insights https://github.com/SQLMesh/sqlmesh/pulse
themisvaltinoshttps://github.com/themisvaltinos
mainhttps://github.com/SQLMesh/sqlmesh/tree/main
themis/janitorcleanuphttps://github.com/SQLMesh/sqlmesh/tree/themis/janitorcleanup
Conversationhttps://github.com/SQLMesh/sqlmesh/pull/5802
Commits3 (3)https://github.com/SQLMesh/sqlmesh/pull/5802/commits
Checkshttps://github.com/SQLMesh/sqlmesh/pull/5802/checks
Files changedhttps://github.com/SQLMesh/sqlmesh/pull/5802/files
Fix: Make the janitor best efforthttps://github.com/SQLMesh/sqlmesh/pull/5802#top
themisvaltinoshttps://github.com/themisvaltinos
mainhttps://github.com/SQLMesh/sqlmesh/tree/main
themis/janitorcleanuphttps://github.com/SQLMesh/sqlmesh/tree/themis/janitorcleanup
https://github.com/themisvaltinos
themisvaltinoshttps://github.com/themisvaltinos
May 21, 2026https://github.com/SQLMesh/sqlmesh/pull/5802#issue-4493866690
Please reload this pagehttps://github.com/SQLMesh/sqlmesh/pull/5802
Please reload this pagehttps://github.com/SQLMesh/sqlmesh/pull/5802
https://github.com/themisvaltinos
Fix: Make the janitor best efforthttps://github.com/SQLMesh/sqlmesh/pull/5802/commits/96bf873b1bacc1541462a60e84dee218461f0d29
96bf873https://github.com/SQLMesh/sqlmesh/pull/5802/commits/96bf873b1bacc1541462a60e84dee218461f0d29
https://github.com/themisvaltinos
themisvaltinoshttps://github.com/themisvaltinos
izeigermanhttps://github.com/izeigerman
vchanhttps://github.com/vchan
May 21, 2026 11:23https://github.com/SQLMesh/sqlmesh/pull/5802#event-25801713130
https://github.com/georgesittas
georgesittashttps://github.com/georgesittas
May 21, 2026 https://github.com/SQLMesh/sqlmesh/pull/5802#pullrequestreview-4337562868
View reviewed changes https://github.com/SQLMesh/sqlmesh/pull/5802/files/96bf873b1bacc1541462a60e84dee218461f0d29
sqlmesh/core/janitor.pyhttps://github.com/SQLMesh/sqlmesh/pull/5802/files/96bf873b1bacc1541462a60e84dee218461f0d29#diff-6d29973d52b074f72891ebd386ddca44d1cdc07cf9bc9cc52e55255a3cc54afb
Please reload this pagehttps://github.com/SQLMesh/sqlmesh/pull/5802
sqlmesh/core/janitor.pyhttps://github.com/SQLMesh/sqlmesh/pull/5802/files/96bf873b1bacc1541462a60e84dee218461f0d29#diff-6d29973d52b074f72891ebd386ddca44d1cdc07cf9bc9cc52e55255a3cc54afb
georgesittashttps://github.com/georgesittas
May 21, 2026https://github.com/SQLMesh/sqlmesh/pull/5802#discussion_r3281729955
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/SQLMesh/sqlmesh/pull/5802
https://github.com/tobymao
tobymaohttps://github.com/tobymao
May 21, 2026 https://github.com/SQLMesh/sqlmesh/pull/5802#pullrequestreview-4337598795
View reviewed changes https://github.com/SQLMesh/sqlmesh/pull/5802/files/96bf873b1bacc1541462a60e84dee218461f0d29
https://github.com/crericha
crerichahttps://github.com/crericha
May 21, 2026 https://github.com/SQLMesh/sqlmesh/pull/5802#pullrequestreview-4337878103
View reviewed changes https://github.com/SQLMesh/sqlmesh/pull/5802/files/96bf873b1bacc1541462a60e84dee218461f0d29
sqlmesh/core/context.pyhttps://github.com/SQLMesh/sqlmesh/pull/5802/files/96bf873b1bacc1541462a60e84dee218461f0d29#diff-02c2689e9e8516b4f905e12fa4dac9b0fff86efae7964c29fb9337055f6f3d94
crerichahttps://github.com/crericha
May 21, 2026https://github.com/SQLMesh/sqlmesh/pull/5802#discussion_r3281998298
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/SQLMesh/sqlmesh/pull/5802
themisvaltinoshttps://github.com/themisvaltinos
May 21, 2026https://github.com/SQLMesh/sqlmesh/pull/5802#discussion_r3282500640
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/SQLMesh/sqlmesh/pull/5802
themisvaltinoshttps://github.com/themisvaltinos
May 21, 2026 22:59https://github.com/SQLMesh/sqlmesh/pull/5802#commits-pushed-cc82ab0
https://github.com/themisvaltinos
add force-delete flag to delete from state even on failureshttps://github.com/SQLMesh/sqlmesh/pull/5802/commits/cc82ab0f4ef5285d64089742bb0ac7fb9abcfbb3
cc82ab0https://github.com/SQLMesh/sqlmesh/pull/5802/commits/cc82ab0f4ef5285d64089742bb0ac7fb9abcfbb3
https://github.com/themisvaltinos
adapt testhttps://github.com/SQLMesh/sqlmesh/pull/5802/commits/c6f8eb47277ed3aec51da69241ceb2bf6c08381b
c6f8eb4https://github.com/SQLMesh/sqlmesh/pull/5802/commits/c6f8eb47277ed3aec51da69241ceb2bf6c08381b
https://github.com/vchan
vchanhttps://github.com/vchan
May 21, 2026 https://github.com/SQLMesh/sqlmesh/pull/5802#pullrequestreview-4341039282
View reviewed changes https://github.com/SQLMesh/sqlmesh/pull/5802/files/c6f8eb47277ed3aec51da69241ceb2bf6c08381b
https://github.com/vchan
vchanhttps://github.com/vchan
Copilothttps://github.com/apps/copilot-pull-request-reviewer
May 21, 2026 22:00https://github.com/SQLMesh/sqlmesh/pull/5802#event-25826276170
started reviewinghttps://github.com/SQLMesh/sqlmesh/sessions/0045df0f-193e-4d99-8fba-cb27b604bd31
vchanhttps://github.com/vchan
May 21, 2026 22:00https://github.com/SQLMesh/sqlmesh/pull/5802#event-25826280464
View session https://github.com/SQLMesh/sqlmesh/sessions/0045df0f-193e-4d99-8fba-cb27b604bd31
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
May 21, 2026 https://github.com/SQLMesh/sqlmesh/pull/5802#pullrequestreview-4341059129
View reviewed changes https://github.com/SQLMesh/sqlmesh/pull/5802/files/c6f8eb47277ed3aec51da69241ceb2bf6c08381b
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/SQLMesh/sqlmesh/pull/5802#pullrequestreview-4341059129
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Add Copilot custom instructionshttps://github.com/SQLMesh/sqlmesh/new/main?filename=.github/instructions/*.instructions.md
Learn how to get startedhttps://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot
Please reload this pagehttps://github.com/SQLMesh/sqlmesh/pull/5802
sqlmesh/core/context.pyhttps://github.com/SQLMesh/sqlmesh/pull/5802/files/c6f8eb47277ed3aec51da69241ceb2bf6c08381b#diff-02c2689e9e8516b4f905e12fa4dac9b0fff86efae7964c29fb9337055f6f3d94
sqlmesh/core/snapshot/evaluator.pyhttps://github.com/SQLMesh/sqlmesh/pull/5802/files/c6f8eb47277ed3aec51da69241ceb2bf6c08381b#diff-9112c1d87cfc89a10e62a210d1c88414ce406ee2eb42be336acc3e84a0104a21
sqlmesh/core/janitor.pyhttps://github.com/SQLMesh/sqlmesh/pull/5802/files/c6f8eb47277ed3aec51da69241ceb2bf6c08381b#diff-6d29973d52b074f72891ebd386ddca44d1cdc07cf9bc9cc52e55255a3cc54afb
sqlmesh/core/janitor.pyhttps://github.com/SQLMesh/sqlmesh/pull/5802/files/c6f8eb47277ed3aec51da69241ceb2bf6c08381b#diff-6d29973d52b074f72891ebd386ddca44d1cdc07cf9bc9cc52e55255a3cc54afb
sqlmesh/core/janitor.pyhttps://github.com/SQLMesh/sqlmesh/pull/5802/files/c6f8eb47277ed3aec51da69241ceb2bf6c08381b#diff-6d29973d52b074f72891ebd386ddca44d1cdc07cf9bc9cc52e55255a3cc54afb
https://github.com/themisvaltinos
themisvaltinoshttps://github.com/themisvaltinos
c5dbce5https://github.com/SQLMesh/sqlmesh/commit/c5dbce52d31725f2d6d8dcb11f4debcb3c70d84f
May 21, 2026https://github.com/SQLMesh/sqlmesh/pull/5802#event-25827237860
Please reload this pagehttps://github.com/SQLMesh/sqlmesh/pull/5802
https://github.com/themisvaltinos
themisvaltinoshttps://github.com/themisvaltinos
May 21, 2026 22:36https://github.com/SQLMesh/sqlmesh/pull/5802#event-25827238756
fresioAShttps://github.com/fresioAS
May 31, 2026 https://github.com/SQLMesh/sqlmesh/pull/5802#ref-commit-71a03d4
https://github.com/themisvaltinos
https://github.com/fresioAS
Fix: Make the janitor best effort and introduce force-delete option (https://github.com/fresioAS/sqlmesh/commit/71a03d4880c59099986c5aa78027340961e061d9
S…https://github.com/SQLMesh/sqlmesh/pull/5802
71a03d4https://github.com/fresioAS/sqlmesh/commit/71a03d4880c59099986c5aa78027340961e061d9
…QLMesh#5802https://github.com/SQLMesh/sqlmesh/pull/5802
https://github.co/hiddenchars
https://github.com/SQLMesh/sqlmesh/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FSQLMesh%2Fsqlmesh%2Fpull%2F5802
https://github.com/georgesittas
georgesittas https://github.com/georgesittas
https://github.com/SQLMesh/sqlmesh/pull/5802/files/96bf873b1bacc1541462a60e84dee218461f0d29
https://github.com/crericha
crericha https://github.com/crericha
https://github.com/SQLMesh/sqlmesh/pull/5802/files/96bf873b1bacc1541462a60e84dee218461f0d29
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
https://github.com/SQLMesh/sqlmesh/pull/5802/files/c6f8eb47277ed3aec51da69241ceb2bf6c08381b
https://github.com/vchan
vchan https://github.com/vchan
https://github.com/SQLMesh/sqlmesh/pull/5802/files/c6f8eb47277ed3aec51da69241ceb2bf6c08381b
https://github.com/tobymao
tobymao https://github.com/tobymao
https://github.com/SQLMesh/sqlmesh/pull/5802/files/96bf873b1bacc1541462a60e84dee218461f0d29
https://github.com/izeigerman
izeigerman https://github.com/izeigerman
Please reload this pagehttps://github.com/SQLMesh/sqlmesh/pull/5802
https://github.com/themisvaltinos
https://github.com/vchan
https://github.com/tobymao
https://github.com/georgesittas
https://github.com/crericha
https://github.com/apps/copilot-pull-request-reviewer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.