René's URL Explorer Experiment


Title: R23-T053: Add input validation to ciphers/porta_cipher.py by code-paul-creator · Pull Request #63 · S-AI-Projects/TheAlgorithms-Python · GitHub

Open Graph Title: R23-T053: Add input validation to ciphers/porta_cipher.py by code-paul-creator · Pull Request #63 · S-AI-Projects/TheAlgorithms-Python

X Title: R23-T053: Add input validation to ciphers/porta_cipher.py by code-paul-creator · Pull Request #63 · S-AI-Projects/TheAlgorithms-Python

Description: Description ciphers/porta_cipher.py had no input validation: bad keys or text crashed with confusing errors (IndexError, KeyError, AttributeError) and one case (ß as a key) silently gave a wrong result. This PR adds clear TypeError/ValueError messages, documents the input contract, and adds a doctest for every new error path. Related Issue Fixes: #53 Type of Change Bug Fix New Feature UI/UX Improvement Performance Improvement Tests Documentation Refactoring / Maintenance CI/CD Changes Made Added validate_letters(name, value, allow_empty=False): TypeError for non-str, ValueError for empty or non-ASCII-letter input, naming the offending character. generate_table validates the key; encrypt validates the text (decrypt inherits both). Documented the input contract in the docstrings (non-empty ASCII-letter key, ASCII-letter text, case-insensitive, empty text returns ''). Added doctests for every new error path (original 5 doctests unchanged; 27 doctests total). Added work/R23-T053/PROBE.md (18 bad inputs, before vs after) and probe_bad_inputs.py. Screenshots / Recordings Not applicable (no UI changes). Testing python -m pytest --doctest-modules ciphers/porta_cipher.py -> passed (27 doctests) python -m doctest -v ciphers/porta_cipher.py -> 27 passed, 0 failed ruff check ciphers/porta_cipher.py -> all checks passed python work/R23-T053/probe_bad_inputs.py -> every bad input now raises a clear error Checklist I have tested my changes locally. I have added or updated tests, if needed. I have updated documentation, if needed. I have followed the project's coding guidelines. I have run the relevant tests and checks. I have addressed previous review feedback, if applicable. Additional Notes Findings (before -> after): empty key IndexError -> ValueError; digit/space/non-ASCII key KeyError -> ValueError; None/int/bytes key AttributeError/KeyError -> TypeError; text with space/digit "substring not found" -> ValueError naming the character; ß key silently accepted (upper() gives 'SS') -> ValueError. Full table in work/R23-T053/PROBE.md.

Open Graph Description: Description ciphers/porta_cipher.py had no input validation: bad keys or text crashed with confusing errors (IndexError, KeyError, AttributeError) and one case (ß as a key) silently gave a wrong re...

X Description: Description ciphers/porta_cipher.py had no input validation: bad keys or text crashed with confusing errors (IndexError, KeyError, AttributeError) and one case (ß as a key) silently gave a wrong re...

Opengraph URL: https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0bf09c51-9119-cfca-d1f7-4be6d53bc77e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC98A:3CDA3E:1072EC:170A1C:6AFDF11C
html-safe-nonce0a279a0a694391f0e4b6e2367d0f8e5cee8fee1b6d3868819151ca4c37a6e556
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOThBOjNDREEzRToxMDcyRUM6MTcwQTFDOjZBRkRGMTFDIiwidmlzaXRvcl9pZCI6IjU0ODIzMjU2Njg3Njc5NTE2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9a6c2e0966a205e14ef26edef2ae7085dc0ac1b628bc210eefc8fa1ded3d1176
hovercard-subject-tagpull_request:5253986240
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files
twitter:imagehttps://avatars.githubusercontent.com/u/260575160?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/260575160?s=400&v=4
og:image:altDescription ciphers/porta_cipher.py had no input validation: bad keys or text crashed with confusing errors (IndexError, KeyError, AttributeError) and one case (ß as a key) silently gave a wrong re...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonedd812ec581ecac95855f5ec917ef9827506c39a9da1443f43ddb4179a46471eb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/S-AI-Projects/TheAlgorithms-Python git https://github.com/S-AI-Projects/TheAlgorithms-Python.git
octolytics-dimension-user_id351892385
octolytics-dimension-user_loginS-AI-Projects
octolytics-dimension-repository_id1444141022
octolytics-dimension-repository_nwoS-AI-Projects/TheAlgorithms-Python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id63476337
octolytics-dimension-repository_parent_nwoTheAlgorithms/Python
octolytics-dimension-repository_network_root_id63476337
octolytics-dimension-repository_network_root_nwoTheAlgorithms/Python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release32ac708bac264dafdc28e10ff49b4d137f0c34a7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FS-AI-Projects%2FTheAlgorithms-Python%2Fpull%2F63%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FS-AI-Projects%2FTheAlgorithms-Python%2Fpull%2F63%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=S-AI-Projects%2FTheAlgorithms-Python
Reloadhttps://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files
Reloadhttps://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files
Reloadhttps://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files
S-AI-Projectshttps://github.com/S-AI-Projects
TheAlgorithms-Pythonhttps://github.com/S-AI-Projects/TheAlgorithms-Python
Codehttps://github.com/S-AI-Projects/TheAlgorithms-Python
Issues60 (60)https://github.com/S-AI-Projects/TheAlgorithms-Python/issues
Pull requests39 (39)https://github.com/S-AI-Projects/TheAlgorithms-Python/pulls
Actionshttps://github.com/S-AI-Projects/TheAlgorithms-Python/actions
Projectshttps://github.com/S-AI-Projects/TheAlgorithms-Python/projects
Security and qualityhttps://github.com/S-AI-Projects/TheAlgorithms-Python/security
Insightshttps://github.com/S-AI-Projects/TheAlgorithms-Python/insights
Sign up for GitHub https://github.com/signup?return_to=%2FS-AI-Projects%2FTheAlgorithms-Python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FS-AI-Projects%2FTheAlgorithms-Python%2Fissues%2Fnew%2Fchoose
code-paul-creatorhttps://github.com/code-paul-creator
S-AI-Projects:masterhttps://github.com/S-AI-Projects/TheAlgorithms-Python/tree/master
code-paul-creator:R23-T053https://github.com/code-paul-creator/TheAlgorithms-Python/tree/R23-T053
Conversation 0 https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63
Commits 1 https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/commits
Checks 0 https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/checks
Files changed https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files
Please reload this pagehttps://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files
R23-T053: Add input validation to ciphers/porta_cipher.py https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files#top
Show all changes 1 commit https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files
dc9a514 R23-T053: validate key and text in porta_cipher, with doctests code-paul-creator Nov 11, 2026 https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/commits/dc9a514ec70145f70e4161a69928a08a996bfd69
Clear filters https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files
Please reload this pagehttps://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files
Please reload this pagehttps://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files
porta_cipher.py https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files#diff-d1dc2c2d574e454fd369fc233a23b3de37ddcbe0bb121600e5959b0f9b855169
PROBE.md https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files#diff-95b8d34617b430e270e16aaaf72cadda4f3943e5d82db9026101e87d580cf2e4
probe_bad_inputs.py https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files#diff-89f2091764b81c312a86eb50706afc9490afd3d5c7608cfc6087c693df50a758
ciphers/porta_cipher.pyhttps://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files#diff-d1dc2c2d574e454fd369fc233a23b3de37ddcbe0bb121600e5959b0f9b855169
View file https://github.com/S-AI-Projects/TheAlgorithms-Python/blob/dc9a514ec70145f70e4161a69928a08a996bfd69/ciphers/porta_cipher.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/{{ revealButtonHref }}
https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files#diff-d1dc2c2d574e454fd369fc233a23b3de37ddcbe0bb121600e5959b0f9b855169
https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files#diff-d1dc2c2d574e454fd369fc233a23b3de37ddcbe0bb121600e5959b0f9b855169
https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files#diff-d1dc2c2d574e454fd369fc233a23b3de37ddcbe0bb121600e5959b0f9b855169
work/R23-T053/PROBE.mdhttps://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files#diff-95b8d34617b430e270e16aaaf72cadda4f3943e5d82db9026101e87d580cf2e4
View file https://github.com/S-AI-Projects/TheAlgorithms-Python/blob/dc9a514ec70145f70e4161a69928a08a996bfd69/work/R23-T053/PROBE.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/{{ revealButtonHref }}
work/R23-T053/probe_bad_inputs.pyhttps://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/files#diff-89f2091764b81c312a86eb50706afc9490afd3d5c7608cfc6087c693df50a758
View file https://github.com/S-AI-Projects/TheAlgorithms-Python/blob/dc9a514ec70145f70e4161a69928a08a996bfd69/work/R23-T053/probe_bad_inputs.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/S-AI-Projects/TheAlgorithms-Python/pull/63/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.