Title: Raj Manoj Patil — R23-T038: Review geometry/braik_mac_construction.py against every Ruff rule · Issue #40 · S-AI-Projects/TheAlgorithms-Python · GitHub
Open Graph Title: Raj Manoj Patil — R23-T038: Review geometry/braik_mac_construction.py against every Ruff rule · Issue #40 · S-AI-Projects/TheAlgorithms-Python
X Title: Raj Manoj Patil — R23-T038: Review geometry/braik_mac_construction.py against every Ruff rule · Issue #40 · S-AI-Projects/TheAlgorithms-Python
Description: Student: Raj Manoj Patil Task: R23-T038 · 8 of 10 Repository: https://github.com/S-AI-Projects/TheAlgorithms-Python Assigned working branch: student/e26b07f0759 Goal The repo's Ruff config already passes for this file. Go further: run al...
Open Graph Description: Student: Raj Manoj Patil Task: R23-T038 · 8 of 10 Repository: https://github.com/S-AI-Projects/TheAlgorithms-Python Assigned working branch: student/e26b07f0759 Goal The repo's Ruff config already ...
X Description: Student: Raj Manoj Patil Task: R23-T038 · 8 of 10 Repository: https://github.com/S-AI-Projects/TheAlgorithms-Python Assigned working branch: student/e26b07f0759 Goal The repo's Ruff config alre...
Opengraph URL: https://github.com/S-AI-Projects/TheAlgorithms-Python/issues/40
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Raj Manoj Patil — R23-T038: Review geometry/braik_mac_construction.py against every Ruff rule","articleBody":"\u003c!-- sai-task-v1:R23-T038 -->\n\n## Student: Raj Manoj Patil\n\n**Task:** R23-T038 · 8 of 10\n**Repository:** https://github.com/S-AI-Projects/TheAlgorithms-Python\n**Assigned working branch:** `student/e26b07f0759`\n\n## Goal\n\nThe repo's Ruff config already passes for this file. Go further: run all of Ruff's rules, decide which findings are worth fixing, and justify the rest. A numpy geometry file with 4 raises – check exception message style (Ruff EM/TRY rules) and naming.\n\n## Steps\n\n1. Run `uvx ruff check geometry/braik_mac_construction.py` (repo config – should be clean) and `uvx ruff check --select ALL geometry/braik_mac_construction.py`.\n2. Group the extra findings by rule code and look each up at docs.astral.sh/ruff/rules.\n3. Fix the findings that improve clarity or safety and match CONTRIBUTING.md; list the others with a reason in REVIEW.md.\n4. Run the doctests and the repo-config Ruff check again.\n5. Make the code change in the repository: geometry/braik_mac_construction.py: fixes for the strict Ruff findings you chose to apply (e.g. exception message style). Re-run the automated check and the repo's own tests afterwards.\n6. Prepare the PR: on branch R23-T038, commit the code change plus your work/R23-T038/ evidence, put your findings in the PR description and open the PR against the org fork. For a later upstream PR, create a second branch containing only the code change (no work/ folder).\n\n## Done when\n\n☐ REVIEW.md lists the `--select ALL` codes for geometry/braik_mac_construction.py; exception messages are moved to variables if EM rules apply.\n☐ At least 3 codes fixed; repo-config Ruff passes; the 4 raise paths and 7 doctests are unchanged in behaviour.\n\n\u003cdetails>\n\u003csummary>Additional task guidance\u003c/summary>\n\n\nAdditional curated task guidance\n\nItem:\n`geometry/braik_mac_construction.py` (160 lines; 7 doctests)\n\nTask type:\nStrict lint review\n\nCode change (goes into the PR):\ngeometry/braik_mac_construction.py: fixes for the strict Ruff findings you chose to apply (e.g. exception message style).\n\nAutomated check:\nuvx ruff check geometry/braik_mac_construction.py && uv run pytest geometry/braik_mac_construction.py\n\nPrerequisites:\nLinux/WSL2/Codespaces with uv (https://docs.astral.sh/uv/getting-started/installation/); run `uv sync --group=test` once – it installs the Python version CI uses (.python-version = 3.15t) and the test dependencies, about 1–2 GB\n\nUpstream PR rules:\nFollow CONTRIBUTING.md: type hints on every parameter/return, doctests for valid and erroneous input, snake_case file names, no duplicate of an existing implementation, no hand edits to DIRECTORY.md. CI (pytest with doctests, ruff) must pass – bots close PRs without tests or type hints. Keep work/ (benchmarks, notes, property tests) out of the upstream branch; put results in the PR description.\n\nSource (pinned):\nhttps://github.com/TheAlgorithms/Python/blob/574d100b7181956e9c8384552fd078165e4cc326/geometry/braik_mac_construction.py\n\nChange:\nNo change recorded\n\nPR destination:\nPreserved pilot guidance\n\n\n\u003c/details>\n\n## Submission checklist\n\n- [ ] Complete this task and its checks.\n- [ ] Add the required evidence and link your pull request here.\n- [ ] Select this **S-AI-Projects fork** as the PR base repository.\n- [ ] Request instructor review.\n\nKeep this PR focused on this task. Do not submit assignment PRs to the upstream repository.","author":{"url":"https://github.com/ankushbisht01","@type":"Person","name":"ankushbisht01"},"datePublished":"2026-11-03T18:43:41Z","url":"https://github.com/S-AI-Projects/TheAlgorithms-Python/issues/40"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:9a819d7e-33ed-8a56-1758-2f68b0ca158b |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E418:2E021D:16138F:2055A2:6AFDC0AF |
| html-safe-nonce | 2d1cbab661f63904d7b468d0cb4d3fb4814dafadc5856cf13d780bc2dc3a8e6d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDE4OjJFMDIxRDoxNjEzOEY6MjA1NUEyOjZBRkRDMEFGIiwidmlzaXRvcl9pZCI6IjE0ODQ2MjM0MTEyMTk5MDY3MzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4e56abbf5bcbb2b1cdc5f6149abaf68e953cccde8f7f2f3d32dbfed68cd08dda |
| hovercard-subject-tag | issue:6188980426 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/S-AI-Projects/TheAlgorithms-Python/40/issue_layout |
| twitter:image | https://opengraph.githubassets.com/a66cb2588f2ba37eb84a84654be0bff27074f16a37180a0ce81fca3c84df5c23/S-AI-Projects/TheAlgorithms-Python/issues/40 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a66cb2588f2ba37eb84a84654be0bff27074f16a37180a0ce81fca3c84df5c23/S-AI-Projects/TheAlgorithms-Python/issues/40 |
| og:image:alt | Student: Raj Manoj Patil Task: R23-T038 · 8 of 10 Repository: https://github.com/S-AI-Projects/TheAlgorithms-Python Assigned working branch: student/e26b07f0759 Goal The repo's Ruff config already ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ankushbisht01 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 35c6bf57da1370dc64866160540c0ee9f825f291935b3bf6ec5492b00e35f3a6 |
| turbo-cache-control | no-preview |
| go-import | github.com/S-AI-Projects/TheAlgorithms-Python git https://github.com/S-AI-Projects/TheAlgorithms-Python.git |
| octolytics-dimension-user_id | 351892385 |
| octolytics-dimension-user_login | S-AI-Projects |
| octolytics-dimension-repository_id | 1444141022 |
| octolytics-dimension-repository_nwo | S-AI-Projects/TheAlgorithms-Python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 63476337 |
| octolytics-dimension-repository_parent_nwo | TheAlgorithms/Python |
| octolytics-dimension-repository_network_root_id | 63476337 |
| octolytics-dimension-repository_network_root_nwo | TheAlgorithms/Python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ab48c73a2978548773f5f24717ed9e58508befdb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width