Title: Muqeet Shaikh — R23-T013: Make graphs/graphs_floyd_warshall.py fully typed · Issue #17 · S-AI-Projects/TheAlgorithms-Python · GitHub
Open Graph Title: Muqeet Shaikh — R23-T013: Make graphs/graphs_floyd_warshall.py fully typed · Issue #17 · S-AI-Projects/TheAlgorithms-Python
X Title: Muqeet Shaikh — R23-T013: Make graphs/graphs_floyd_warshall.py fully typed · Issue #17 · S-AI-Projects/TheAlgorithms-Python
Description: Student: Muqeet Shaikh Task: R23-T013 · 3 of 10 Repository: https://github.com/S-AI-Projects/TheAlgorithms-Python Assigned working branch: student/e26b07f0731 Goal Add accurate type hints so the type checker CI runs (ty) has nothing to r...
Open Graph Description: Student: Muqeet Shaikh Task: R23-T013 · 3 of 10 Repository: https://github.com/S-AI-Projects/TheAlgorithms-Python Assigned working branch: student/e26b07f0731 Goal Add accurate type hints so the ty...
X Description: Student: Muqeet Shaikh Task: R23-T013 · 3 of 10 Repository: https://github.com/S-AI-Projects/TheAlgorithms-Python Assigned working branch: student/e26b07f0731 Goal Add accurate type hints so the ty...
Opengraph URL: https://github.com/S-AI-Projects/TheAlgorithms-Python/issues/17
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Muqeet Shaikh — R23-T013: Make graphs/graphs_floyd_warshall.py fully typed","articleBody":"\u003c!-- sai-task-v1:R23-T013 -->\n\n## Student: Muqeet Shaikh\n\n**Task:** R23-T013 · 3 of 10\n**Repository:** https://github.com/S-AI-Projects/TheAlgorithms-Python\n**Assigned working branch:** `student/e26b07f0731`\n\n## Goal\n\nAdd accurate type hints so the type checker CI runs (ty) has nothing to report for this file. Functions missing hints: `_print_dist`, `floyd_warshall`. Two functions lack hints, and `_print_dist` prints a matrix – choose types for the distance matrix including infinity.\n\n## Steps\n\n1. Run `uv run --python 3.15 --with ty ty check graphs/graphs_floyd_warshall.py` (as in .github/workflows/ty.yml) and save the output.\n2. Add parameter and return types for every function; prefer precise types (e.g. `list[list[int]]`) over `Any`.\n3. Fix any real bug the checker exposes, and add a doctest for it.\n4. Run the doctests to confirm behaviour is unchanged.\n5. Make the code change in the repository: graphs/graphs_floyd_warshall.py: type hints for the 2 unhinted functions (distance matrix with float('inf')). Re-run the automated check and the repo's own tests afterwards.\n6. Prepare the PR: on branch R23-T013, commit the code change plus your work/R23-T013/ evidence, put your findings in the PR description and open the PR against the org fork. For a later upstream PR, create a second branch containing only the code change (no work/ folder).\n\n## Done when\n\n☐ graphs/graphs_floyd_warshall.py: _print_dist and floyd_warshall have full hints; the distance matrix type expresses float('inf') (e.g. `list[list[float]]`).\n☐ ty output before/after is in the PR, ending with no diagnostics for this file.\n☐ floyd_warshall's 4 doctests pass unchanged.\n\n\u003cdetails>\n\u003csummary>Additional task guidance\u003c/summary>\n\n\nAdditional curated task guidance\n\nItem:\n`graphs/graphs_floyd_warshall.py` (125 lines; 4 doctests)\n\nTask type:\nType hints & ty\n\nCode change (goes into the PR):\ngraphs/graphs_floyd_warshall.py: type hints for the 2 unhinted functions (distance matrix with float('inf')).\n\nAutomated check:\nuv run --python 3.15 --with ty ty check graphs/graphs_floyd_warshall.py && uv run pytest graphs/graphs_floyd_warshall.py\n\nPrerequisites:\nLinux/WSL2/Codespaces with uv (https://docs.astral.sh/uv/getting-started/installation/); run `uv sync --group=test` once – it installs the Python version CI uses (.python-version = 3.15t) and the test dependencies, about 1–2 GB\n\nUpstream PR rules:\nFollow CONTRIBUTING.md: type hints on every parameter/return, doctests for valid and erroneous input, snake_case file names, no duplicate of an existing implementation, no hand edits to DIRECTORY.md. CI (pytest with doctests, ruff) must pass – bots close PRs without tests or type hints. Keep work/ (benchmarks, notes, property tests) out of the upstream branch; put results in the PR description.\n\nSource (pinned):\nhttps://github.com/TheAlgorithms/Python/blob/574d100b7181956e9c8384552fd078165e4cc326/graphs/graphs_floyd_warshall.py\n\nChange:\nNo change recorded\n\nPR destination:\nPreserved pilot guidance\n\n\n\u003c/details>\n\n## Submission checklist\n\n- [ ] Complete this task and its checks.\n- [ ] Add the required evidence and link your pull request here.\n- [ ] Select this **S-AI-Projects fork** as the PR base repository.\n- [ ] Request instructor review.\n\nKeep this PR focused on this task. Do not submit assignment PRs to the upstream repository.","author":{"url":"https://github.com/ankushbisht01","@type":"Person","name":"ankushbisht01"},"datePublished":"2026-11-03T18:39:59Z","url":"https://github.com/S-AI-Projects/TheAlgorithms-Python/issues/17"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:555320f8-a5a8-ea59-7898-a25f0b14bfc5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C2D6:393F3E:18BEF6:23A9D5:6AFDCF9C |
| html-safe-nonce | e797ce269bdd64f72b1ad21c2004b191a27d8791aa9f48a4b7cd2fa6e812e4b9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkQ2OjM5M0YzRToxOEJFRjY6MjNBOUQ1OjZBRkRDRjlDIiwidmlzaXRvcl9pZCI6Ijg3Mjg5MDI4MzA1MDIzMDE1OTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 31c5f3cc2f74f289e88f04ff0cbc54d658e998ea364a908f6582bbb09c2f8f47 |
| hovercard-subject-tag | issue:6188924991 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/S-AI-Projects/TheAlgorithms-Python/17/issue_layout |
| twitter:image | https://opengraph.githubassets.com/0c799a9e6a3348ed2cf7356a41e8406fd45ae2f3ce9552c44dd044dc82dbaae6/S-AI-Projects/TheAlgorithms-Python/issues/17 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0c799a9e6a3348ed2cf7356a41e8406fd45ae2f3ce9552c44dd044dc82dbaae6/S-AI-Projects/TheAlgorithms-Python/issues/17 |
| og:image:alt | Student: Muqeet Shaikh Task: R23-T013 · 3 of 10 Repository: https://github.com/S-AI-Projects/TheAlgorithms-Python Assigned working branch: student/e26b07f0731 Goal Add accurate type hints so the ty... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ankushbisht01 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 26886a40b582b821a7a76351e0a2f42b6d6160854b6e2520db24f31fd7be5da7 |
| turbo-cache-control | no-preview |
| go-import | github.com/S-AI-Projects/TheAlgorithms-Python git https://github.com/S-AI-Projects/TheAlgorithms-Python.git |
| octolytics-dimension-user_id | 351892385 |
| octolytics-dimension-user_login | S-AI-Projects |
| octolytics-dimension-repository_id | 1444141022 |
| octolytics-dimension-repository_nwo | S-AI-Projects/TheAlgorithms-Python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 63476337 |
| octolytics-dimension-repository_parent_nwo | TheAlgorithms/Python |
| octolytics-dimension-repository_network_root_id | 63476337 |
| octolytics-dimension-repository_network_root_nwo | TheAlgorithms/Python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 68ebaa631a1d248d69ebde4b9c5defd3a19aeb2f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width