René's URL Explorer Experiment


Title: Match CPython eval and exec argument validation order by youknowdot · Pull Request #9981 · RustPython/RustPython · GitHub

Open Graph Title: Match CPython eval and exec argument validation order by youknowdot · Pull Request #9981 · RustPython/RustPython

X Title: Match CPython eval and exec argument validation order by youknowdot · Pull Request #9981 · RustPython/RustPython

Description: This PR follows the RustPython AI policy. Summary Match CPython 3.15.2's validation order for eval and exec: validate locals first for eval, globals first for exec, insert builtins before rejecting an invalid source, and distinguish code-object closure handling from non-code sources. Preserve the public signatures. Remove the two expected-failure directives for the existing Pdb.run and Pdb.runeval malformed-argument examples. Verification On Linux, 16 selected builtin tests and the 3 examples in the affected Pdb doctest passed on CPython 3.15.2 and on this RustPython branch. An additional direct CPython comparison covered source buffers and argument-validation/closure precedence. Relevant commit hooks passed. The full suite, other platforms, and release performance were not tested locally. Codex assisted with comparing the implementations, writing the Rust change and running the focused tests. Submitted as a draft at the project maintainer's request for their review. Summary by CodeRabbit Bug Fixes Improved validation for eval and exec scope arguments, with clearer errors for invalid globals, locals, and source values. eval and exec now accept bytes-like source inputs in addition to strings and code objects. When locals are omitted and globals are provided, the globals mapping is used for both.

Open Graph Description: This PR follows the RustPython AI policy. Summary Match CPython 3.15.2's validation order for eval and exec: validate locals first for eval, globals first for exec, insert builtins before reje...

X Description: This PR follows the RustPython AI policy. Summary Match CPython 3.15.2's validation order for eval and exec: validate locals first for eval, globals first for exec, insert builtins before ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9981

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9ff945ce-f2f6-665a-6320-80bd79bcaee8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8EBE:2DBB21:2D84F4E:3CC516D:6B01D803
html-safe-nonce330f70fbb2d573ee16281589e0fd5144ebbde3818ff54b6624c9d4835078065c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RUJFOjJEQkIyMToyRDg0RjRFOjNDQzUxNkQ6NkIwMUQ4MDMiLCJ2aXNpdG9yX2lkIjoiNzMyMzQ0NTg4NjA3MDE1MTE3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7c720d6b05589ffb1da69568b148834a7e2c4be8b43a816060af0f6551841291
hovercard-subject-tagpull_request:5429674778
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9981/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altThis PR follows the RustPython AI policy. Summary Match CPython 3.15.2's validation order for eval and exec: validate locals first for eval, globals first for exec, insert builtins before reje...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9981/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9981%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9981%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9981/files
Reloadhttps://github.com/RustPython/RustPython/pull/9981/files
Reloadhttps://github.com/RustPython/RustPython/pull/9981/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests132 (132)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowdothttps://github.com/youknowdot
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix-eval-exec-locals-source-precedencehttps://github.com/youknowdot/RustPython/tree/fix-eval-exec-locals-source-precedence
Conversation 2 https://github.com/RustPython/RustPython/pull/9981
Commits 1 https://github.com/RustPython/RustPython/pull/9981/commits
Checks 8 https://github.com/RustPython/RustPython/pull/9981/checks
Files changed 2 https://github.com/RustPython/RustPython/pull/9981/files
Match CPython eval and exec argument validation order https://github.com/RustPython/RustPython/pull/9981/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9981/files
6c22400 Match CPython eval and exec argument validation order youknowdot Nov 21, 2026 https://github.com/RustPython/RustPython/pull/9981/commits/6c224001aafd3bab119dd9a2078ad93570625e94
Clear filters https://github.com/RustPython/RustPython/pull/9981/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9981/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9981/files
test_pdb.py https://github.com/RustPython/RustPython/pull/9981/files#diff-62d496a5c437924e8e749b16d45e0b928917c424ba7deb45112f5a7a9450c6f5
builtins.rs https://github.com/RustPython/RustPython/pull/9981/files#diff-ce8bd80bb61ce870dbf04415913693df814ebda260d3fc784b689a657e694ca3
Lib/test/test_pdb.pyhttps://github.com/RustPython/RustPython/pull/9981/files#diff-62d496a5c437924e8e749b16d45e0b928917c424ba7deb45112f5a7a9450c6f5
View file https://github.com/RustPython/RustPython/blob/6c224001aafd3bab119dd9a2078ad93570625e94/Lib/test/test_pdb.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9981/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9981/files#diff-62d496a5c437924e8e749b16d45e0b928917c424ba7deb45112f5a7a9450c6f5
https://github.com/RustPython/RustPython/pull/9981/files#diff-62d496a5c437924e8e749b16d45e0b928917c424ba7deb45112f5a7a9450c6f5
crates/vm/src/stdlib/builtins.rshttps://github.com/RustPython/RustPython/pull/9981/files#diff-ce8bd80bb61ce870dbf04415913693df814ebda260d3fc784b689a657e694ca3
View file https://github.com/RustPython/RustPython/blob/6c224001aafd3bab119dd9a2078ad93570625e94/crates/vm/src/stdlib/builtins.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9981/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9981/files#diff-ce8bd80bb61ce870dbf04415913693df814ebda260d3fc784b689a657e694ca3
https://github.com/RustPython/RustPython/pull/9981/files#diff-ce8bd80bb61ce870dbf04415913693df814ebda260d3fc784b689a657e694ca3
https://github.com/RustPython/RustPython/pull/9981/files#diff-ce8bd80bb61ce870dbf04415913693df814ebda260d3fc784b689a657e694ca3
https://github.com/RustPython/RustPython/pull/9981/files#diff-ce8bd80bb61ce870dbf04415913693df814ebda260d3fc784b689a657e694ca3
https://github.com/RustPython/RustPython/pull/9981/files#diff-ce8bd80bb61ce870dbf04415913693df814ebda260d3fc784b689a657e694ca3
https://github.com/RustPython/RustPython/pull/9981/files#diff-ce8bd80bb61ce870dbf04415913693df814ebda260d3fc784b689a657e694ca3
https://github.com/RustPython/RustPython/pull/9981/files#diff-ce8bd80bb61ce870dbf04415913693df814ebda260d3fc784b689a657e694ca3
https://github.com/RustPython/RustPython/pull/9981/files#diff-ce8bd80bb61ce870dbf04415913693df814ebda260d3fc784b689a657e694ca3
https://github.com/RustPython/RustPython/pull/9981/files#diff-ce8bd80bb61ce870dbf04415913693df814ebda260d3fc784b689a657e694ca3
https://github.com/RustPython/RustPython/pull/9981/files#diff-ce8bd80bb61ce870dbf04415913693df814ebda260d3fc784b689a657e694ca3
https://github.com/RustPython/RustPython/pull/9981/files#diff-ce8bd80bb61ce870dbf04415913693df814ebda260d3fc784b689a657e694ca3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.