René's URL Explorer Experiment


Title: Resolve module-owned lazy imports before __getattr__ by youknowdot · Pull Request #9980 · RustPython/RustPython · GitHub

Open Graph Title: Resolve module-owned lazy imports before __getattr__ by youknowdot · Pull Request #9980 · RustPython/RustPython

X Title: Resolve module-owned lazy imports before __getattr__ by youknowdot · Pull Request #9980 · RustPython/RustPython

Description: This PR follows the RustPython AI policy. Summary Resolve a lazy-import placeholder already owned by a module before consulting its __getattr__, matching CPython's fix. Missing names still fall back to __getattr__. Pending-child handling and the existing direct-reentry guard are unchanged. Sync the exact CPython 3.15.2 regression test and its companion fixture. The test covers both lazy import forms and the missing-name fallback. Verification Linux: 35 focused tests and 17 adjacent tests passed on the exact branch commit 3ec936ff. The patch applies cleanly to upstream main c626010f. No fresh build against that main snapshot, full suite, or other-platform verification is claimed. Codex assisted with the implementation, upstream regression-test sync, and focused verification. Submitted as a draft at the project maintainer's request for review. Summary by CodeRabbit Bug Fixes Module attributes backed by lazy imports are now resolved before the module’s custom attribute fallback is checked. This improves access to lazily imported attributes in cases where a module also defines custom attribute handling. The existing fallback for attributes that are not present remains unchanged.

Open Graph Description: This PR follows the RustPython AI policy. Summary Resolve a lazy-import placeholder already owned by a module before consulting its __getattr__, matching CPython's fix. Missing names still fal...

X Description: This PR follows the RustPython AI policy. Summary Resolve a lazy-import placeholder already owned by a module before consulting its __getattr__, matching CPython's fix. Missing names still...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9980

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8332d506-7ad7-dfd6-b01f-6669897ee690
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC8E:E3C4F:31795FE:3F26379:6B01D7E9
html-safe-nonce621d4e4ca787da39aed923db92a3aac11280087862bad4710209bf26364410e7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzhFOkUzQzRGOjMxNzk1RkU6M0YyNjM3OTo2QjAxRDdFOSIsInZpc2l0b3JfaWQiOiI1MzIyNjkxNTE1MDQxMDQ0NDU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1f1e7d8d33305ce131cd703686d3f6f062779e783c53948f8ba38ced9a12837d
hovercard-subject-tagpull_request:5429662300
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9980/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altThis PR follows the RustPython AI policy. Summary Resolve a lazy-import placeholder already owned by a module before consulting its __getattr__, matching CPython's fix. Missing names still fal...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9980/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9980%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9980%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9980/files
Reloadhttps://github.com/RustPython/RustPython/pull/9980/files
Reloadhttps://github.com/RustPython/RustPython/pull/9980/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests132 (132)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowdothttps://github.com/youknowdot
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix-lazy-module-getattr-3152https://github.com/youknowdot/RustPython/tree/fix-lazy-module-getattr-3152
Conversation 2 https://github.com/RustPython/RustPython/pull/9980
Commits 1 https://github.com/RustPython/RustPython/pull/9980/commits
Checks 8 https://github.com/RustPython/RustPython/pull/9980/checks
Files changed 3 https://github.com/RustPython/RustPython/pull/9980/files
Resolve module-owned lazy imports before __getattr__ https://github.com/RustPython/RustPython/pull/9980/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9980/files
3ec936f Resolve module-owned lazy imports before __getattr__ youknowdot Nov 20, 2026 https://github.com/RustPython/RustPython/pull/9980/commits/3ec936ffb33cc2052f6cc763de17570d6e0ba86a
Clear filters https://github.com/RustPython/RustPython/pull/9980/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9980/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9980/files
__init__.py https://github.com/RustPython/RustPython/pull/9980/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
module_with_lazy_import_and_getattr.py https://github.com/RustPython/RustPython/pull/9980/files#diff-1ee9b15ed076cf80cb1f07e2ed9b463f8e3295e57be5f5cf8c673b85e9709b92
module.rs https://github.com/RustPython/RustPython/pull/9980/files#diff-1b1658fe8f1e6aa57ba5cb8b7f33a6c83dad6600554e0125c989aa083ea26a0e
Lib/test/test_lazy_import/__init__.pyhttps://github.com/RustPython/RustPython/pull/9980/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
View file https://github.com/RustPython/RustPython/blob/3ec936ffb33cc2052f6cc763de17570d6e0ba86a/Lib/test/test_lazy_import/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9980/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9980/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
https://github.com/RustPython/RustPython/pull/9980/files#diff-9c7ed57cb280bfcf280bf31daf9747c91ca26b50196a9f84c1a38f105d83b31e
Lib/test/test_lazy_import/data/module_with_lazy_import_and_getattr.pyhttps://github.com/RustPython/RustPython/pull/9980/files#diff-1ee9b15ed076cf80cb1f07e2ed9b463f8e3295e57be5f5cf8c673b85e9709b92
View file https://github.com/RustPython/RustPython/blob/3ec936ffb33cc2052f6cc763de17570d6e0ba86a/Lib/test/test_lazy_import/data/module_with_lazy_import_and_getattr.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9980/{{ revealButtonHref }}
crates/vm/src/builtins/module.rshttps://github.com/RustPython/RustPython/pull/9980/files#diff-1b1658fe8f1e6aa57ba5cb8b7f33a6c83dad6600554e0125c989aa083ea26a0e
View file https://github.com/RustPython/RustPython/blob/3ec936ffb33cc2052f6cc763de17570d6e0ba86a/crates/vm/src/builtins/module.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9980/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9980/files#diff-1b1658fe8f1e6aa57ba5cb8b7f33a6c83dad6600554e0125c989aa083ea26a0e
https://github.com/RustPython/RustPython/pull/9980/files#diff-1b1658fe8f1e6aa57ba5cb8b7f33a6c83dad6600554e0125c989aa083ea26a0e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.