René's URL Explorer Experiment


Title: Replace `BlockIdx::NULL` with `Option` by ShaharNaveh · Pull Request #9941 · RustPython/RustPython · GitHub

Open Graph Title: Replace `BlockIdx::NULL` with `Option` by ShaharNaveh · Pull Request #9941 · RustPython/RustPython

X Title: Replace `BlockIdx::NULL` with `Option` by ShaharNaveh · Pull Request #9941 · RustPython/RustPython

Description: Closes #7221 One of checkbox below must be checked. I did not use AI to write the code of this patch. This PR follows our AI policy Summary BlockIdx::NULL was a u32::MAX sentinel standing in for "no block". This replaces it with Option so a missing block is explicit in the type. InstructionInfo.target, Block.next, Block.allocation_next, the except-stack handler slots, and the instruction-sequence label-to-block maps are now Option. Block-list traversals use while let Some(block) = cursor { ...; cursor = self[block].next; }. Places that require a block (e.g. a jump's target) use .expect(...) instead of debug_assert!(x != BlockIdx::NULL). CfgBuilder.entry / current stay plain BlockIdx, since they are always set once the builder exists. init_cfg_builder is folded into cfg_builder_new. Adds BlockIdx::MIN for the entry block, replacing BlockIdx(0). No bytecode output changes: the codegen snapshot tests pass unchanged. Summary by CodeRabbit Bug Fixes Improved handling of control-flow targets in compiled code, including asynchronous loops and comprehensions. Improved recognition of equivalent tuple, slice, and frozenset constants during compilation. Frozenset comparison now ignores element order and duplicates, while constants containing NaN remain distinct.

Open Graph Description: Closes #7221 One of checkbox below must be checked. I did not use AI to write the code of this patch. This PR follows our AI policy Summary BlockIdx::NULL was a u32::MAX sentinel standing in...

X Description: Closes #7221 One of checkbox below must be checked. I did not use AI to write the code of this patch. This PR follows our AI policy Summary BlockIdx::NULL was a u32::MAX sentinel standing in...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9941

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:26807111-fcbb-4343-e17b-be1dbf7ceb6f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC5E2:299992:F6ED5D:146C6E3:6B01D7E7
html-safe-nonceb3b801b04eb5089b3e88a221a93d64031a6b4a0a614cf484c90f241583ac07c7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNUUyOjI5OTk5MjpGNkVENUQ6MTQ2QzZFMzo2QjAxRDdFNyIsInZpc2l0b3JfaWQiOiI4NTI3MzQ4MjcwMjI4NDI4Nzc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8bc1d563ae2a5f103ec5c7e47fb0f5398437adc9bdf3aac31be168a7c84fad43
hovercard-subject-tagpull_request:5375056962
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9941/files
twitter:imagehttps://avatars.githubusercontent.com/u/50263213?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/50263213?s=400&v=4
og:image:altCloses #7221 One of checkbox below must be checked. I did not use AI to write the code of this patch. This PR follows our AI policy Summary BlockIdx::NULL was a u32::MAX sentinel standing in...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9941/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9941%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9941%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9941/files
Reloadhttps://github.com/RustPython/RustPython/pull/9941/files
Reloadhttps://github.com/RustPython/RustPython/pull/9941/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests132 (132)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
ShaharNavehhttps://github.com/ShaharNaveh
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
ShaharNaveh:ir-blockidx-nullhttps://github.com/ShaharNaveh/RustPython/tree/ir-blockidx-null
Conversation 7 https://github.com/RustPython/RustPython/pull/9941
Commits 4 https://github.com/RustPython/RustPython/pull/9941/commits
Checks 27 https://github.com/RustPython/RustPython/pull/9941/checks
Files changed 2 https://github.com/RustPython/RustPython/pull/9941/files
Replace BlockIdx::NULL with Option https://github.com/RustPython/RustPython/pull/9941/files#top
Show all changes 4 commits https://github.com/RustPython/RustPython/pull/9941/files
35d7133 Replace BlockIdx::NULL with Option ShaharNaveh Nov 18, 2026 https://github.com/RustPython/RustPython/pull/9941/commits/35d7133bdb3c1301aea57f238056d65ea0beba37
338254a add derives ShaharNaveh Nov 18, 2026 https://github.com/RustPython/RustPython/pull/9941/commits/338254abca380a08d9a4889da65e39d8d0116efc
636b27f Use assert_eq with None for empty BlockIdx checks ShaharNaveh Nov 18, 2026 https://github.com/RustPython/RustPython/pull/9941/commits/636b27fd594dd588bd615cb2cb453100974c1215
9c282e2 Add BlockIdx::MIN for the entry block ShaharNaveh Nov 18, 2026 https://github.com/RustPython/RustPython/pull/9941/commits/9c282e22905e2086d225df9b5d6ee835be134711
Clear filters https://github.com/RustPython/RustPython/pull/9941/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9941/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9941/files
compile.rs https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
ir.rs https://github.com/RustPython/RustPython/pull/9941/files#diff-d8c69d86dba0a1bbfb21c9d93371294ea2861a4083565b20e622a7bec7da1ecc
crates/codegen/src/compile.rshttps://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
View file https://github.com/RustPython/RustPython/blob/9c282e22905e2086d225df9b5d6ee835be134711/crates/codegen/src/compile.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9941/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
https://github.com/RustPython/RustPython/pull/9941/files#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9941/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9941/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.