René's URL Explorer Experiment


Title: Fix strict tokenizer lexical error propagation by youknowone · Pull Request #9935 · RustPython/RustPython · GitHub

Open Graph Title: Fix strict tokenizer lexical error propagation by youknowone · Pull Request #9935 · RustPython/RustPython

X Title: Fix strict tokenizer lexical error propagation by youknowone · Pull Request #9935 · RustPython/RustPython

Description: Summary Propagate lexical tokenizer errors without treating parser grammar recovery as a lexical failure. Preserve extra-token tolerance, diagnostic arguments/positions, and token/error ordering for malformed numbers, brackets, strings, interpolations, and NUL input. Remove the existing test_invalid_syntax expectedFailure marker. No new repository tests or changes to canonical assertions. Verification Linux x86_64, Rust 1.100.0, CPython 3.15.2 reference; main bf68333 baseline. test_tokenize passes (132 tests run). 85 private differential inputs in both modes: all 170 complete records match, including token tuples and exception class/arguments/text/start/end positions. Workspace all-targets Clippy passes, excluding wasm, venvlauncher, and CAPI. Mandatory commit hooks pass; prettier skipped because no applicable files. Full non-CAPI Rust workspace tests and doctests pass: 1,619 passed, 21 ignored, 0 failed. The ignored cases are two existing process-isolation tests and 19 doctests. CAPI remains deferred per the maintainer's instruction; Windows/WASI and CI are not yet verified. Quiet alternating baseline/candidate debug microbenchmarks over four rounds showed median changes of −3.4% for many-line source, −4.6% for long-line source, and −8.1% for f-strings. These local regression checks are not release-performance guarantees. Remaining limits This is not complete tokenizer parity. Ruff splits invalid Unicode identifiers such as a€b, so strict mode may emit the valid prefix before the correct diagnostic, and extra-token boundaries differ. A private lexer workaround is deliberately not added. A continuation ending in bare CR still has an EOF line/offset difference; LF/CRLF probes match. Existing eager readline/callback ordering and numeric-keyword SyntaxWarning/filter behavior remain outside this change. AI assistance Implementation, differential probes, and independent review used OpenAI Codex. The runtime does not expose an exact model version, so the commit records Assisted-by: Codex:model-unspecified rather than inventing one.

Open Graph Description: Summary Propagate lexical tokenizer errors without treating parser grammar recovery as a lexical failure. Preserve extra-token tolerance, diagnostic arguments/positions, and token/error ordering f...

X Description: Summary Propagate lexical tokenizer errors without treating parser grammar recovery as a lexical failure. Preserve extra-token tolerance, diagnostic arguments/positions, and token/error ordering f...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9935

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:89076d2b-e690-e11e-51fa-a472c516c62d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB4AA:CE438:C2A6CC:104E1B8:6B01D7E9
html-safe-nonce275721c1919eed46ad66087fdaa7c1f69598fba7a00521c28d3d01ef03d96aac
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEFBOkNFNDM4OkMyQTZDQzoxMDRFMUI4OjZCMDFEN0U5IiwidmlzaXRvcl9pZCI6Ijc3NDAxNzEyMDcyNzA2MjUwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8ca34c125db55b446f5d6f218a7261c185dcac25358419dd614bd9bfc7ed6aad
hovercard-subject-tagpull_request:5369280790
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9935/files
twitter:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
og:image:altSummary Propagate lexical tokenizer errors without treating parser grammar recovery as a lexical failure. Preserve extra-token tolerance, diagnostic arguments/positions, and token/error ordering f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9935/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9935%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9935%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9935/files
Reloadhttps://github.com/RustPython/RustPython/pull/9935/files
Reloadhttps://github.com/RustPython/RustPython/pull/9935/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests132 (132)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
mainhttps://github.com/RustPython/RustPython/tree/main
dot/tokenizer-strict-ed04420https://github.com/RustPython/RustPython/tree/dot/tokenizer-strict-ed04420
Conversation 3 https://github.com/RustPython/RustPython/pull/9935
Commits 2 https://github.com/RustPython/RustPython/pull/9935/commits
Checks 24 https://github.com/RustPython/RustPython/pull/9935/checks
Files changed https://github.com/RustPython/RustPython/pull/9935/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9935/files
Fix strict tokenizer lexical error propagation https://github.com/RustPython/RustPython/pull/9935/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/9935/files
fdd327a Fix strict tokenizer lexical diagnostics youknowone Nov 18, 2026 https://github.com/RustPython/RustPython/pull/9935/commits/fdd327a6853fe0f04eee235d64bb784deddd562a
26ae61c Ignore parser-recovery brace errors during tokenization youknowone Nov 18, 2026 https://github.com/RustPython/RustPython/pull/9935/commits/26ae61c85fe61898a2250bd905c3b64a0c25ced0
Clear filters https://github.com/RustPython/RustPython/pull/9935/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9935/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9935/files
test_tokenize.py https://github.com/RustPython/RustPython/pull/9935/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
_tokenize.rs https://github.com/RustPython/RustPython/pull/9935/files#diff-bb99b022abbf800768ecd8f4beaaeb241591d22a3469d939370de235e0b68c37
Lib/test/test_tokenize.pyhttps://github.com/RustPython/RustPython/pull/9935/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
View file https://github.com/RustPython/RustPython/blob/26ae61c85fe61898a2250bd905c3b64a0c25ced0/Lib/test/test_tokenize.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9935/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9935/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
https://github.com/RustPython/RustPython/pull/9935/files#diff-b07c4f10c75a22e102f114227a0a9b7b763ddda7a330109994e69b29540ea9bb
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9935/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9935/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.