Title: Refresh profile state after eval-breaker callbacks by youknowdot · Pull Request #9931 · RustPython/RustPython · GitHub
Open Graph Title: Refresh profile state after eval-breaker callbacks by youknowdot · Pull Request #9931 · RustPython/RustPython
X Title: Refresh profile state after eval-breaker callbacks by youknowdot · Pull Request #9931 · RustPython/RustPython
Description: Follow-up to #9912: refresh profile state after callbacks #9912 was merged at 43479875f before its later review correction reached main. This independent PR applies that correction on main e634ec61. A signal handler or scheduled GC callback can change sys.setprofile during eval-breaker work. Refresh the cached tracing flag after that work, before dispatching the current instruction. The refresh runs only when the eval breaker is tripped; it does not add an unconditional load to the normal hot path. Preserve the generator-preparation guard and existing exception unwind. Addresses the independently reproduced finding in #9912 (comment) . No workflow, skip, dependency, monitoring architecture or bytecode changes. Validation scope The same correction was tested as 128a3eccb on #9912's pre-merge feature branch, before this transplant onto current main: Matched Rust 1.100 thin-LTO release build passed. Targeted warmed positional list.append signal deliveries: pre-fix 100/100 missed the profile pair; corrected 100/100 emitted it. General delivery probes matched actual append count to C calls, both in corrected RustPython and CPython 3.15.2 (100 cases each). GC callback profiling on/off and signal-handler exception unwind probes passed in corrected RustPython and CPython 3.15.2. Canonical test_profile, test_sys_setprofile, test_sys_settrace, test_monitoring: 582 tests, 82 existing skips, all passed. Original warmed native-call regression group passed. Same-machine, CPU-pinned alternating 11-sample CPU-time measurements were noisy; they are limited local evidence, not a statistically established no-regression claim or a matched current-main benchmark. Detailed results will be added after verification. Exact transplanted-head validation so far: focused normal hooks/Rustfmt/whitespace checks passed. Current main also contains newly merged signature changes, so the preceding runtime results must not be represented as exact-current-main execution. Fresh CI and current-main validation are pending. Keep draft; no automatic merge. The signal probes are external timing-sensitive diagnostics rather than flaky mandatory tests. Non-POSIX signal behavior was not tested locally. Existing profile callback error swallowing is out of scope; this does not claim complete profiling parity. AI assistance: OpenAI Codex assisted implementation, independent review and validation. Exact model version is unavailable and not guessed. Exact transplanted head c1f08ba Fresh Rust 1.100 release build on current base e634ec61 passed. Its runtime passed: General POSIX signal delivery accounting: 100 cases, every executed append matched a C call. Targeted warmed append signal deliveries: 100/100 correct C call/return pairs. GC callback profile enable/disable, signal-handler exception unwind, and the native descriptor/warmed-call regression probe. Canonical test_profile, test_sys_setprofile, test_sys_settrace, test_monitoring: 582 tests, 82 existing skips, all passed. The identical correction before transplant (128a3eccb) additionally passed the full workspace Rust tests/doctests (1597 passed, 21 ignored), separate C-API tests (153 passed, 2 ignored), and both workspace/all-target and C-API/all-target strict Clippy. Those aggregate checks were not rerun after transplant; current-main runtime results above are separate. Final pre-transplant matched CPU-time benchmark medians (11 alternating CPU-pinned samples): loop -1.05%, Python calls +1.19%, native calls -1.58%, generator -1.13%. This is noisy local evidence, not a statistically proven performance result or current-main matched benchmark. Fresh hosted CI remains required. No automatic merge.
Open Graph Description: Follow-up to #9912: refresh profile state after callbacks #9912 was merged at 43479875f before its later review correction reached main. This independent PR applies that correction on main e634ec61...
X Description: Follow-up to #9912: refresh profile state after callbacks #9912 was merged at 43479875f before its later review correction reached main. This independent PR applies that correction on main e634ec61...
Opengraph URL: https://github.com/RustPython/RustPython/pull/9931
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:2841574b-13ab-2658-7824-eb03cbc924f6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B416:21AC3F:40EEE48:52297B6:6B01FE4F |
| html-safe-nonce | 63d5e3aa9059629078255af68de77aa0ce98299aeb6c08b4b3b555d8caeec2bb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDE2OjIxQUMzRjo0MEVFRTQ4OjUyMjk3QjY6NkIwMUZFNEYiLCJ2aXNpdG9yX2lkIjoiMTA3NjIxNjY1MDM3NTc1NzM5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | db0c12ae4410e29311cc2dc24a8f8844f0f61d1c10eccda4feba3f2ca352a875 |
| hovercard-subject-tag | pull_request:5361725274 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9931/files |
| twitter:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/336763669?s=400&v=4 |
| og:image:alt | Follow-up to #9912: refresh profile state after callbacks #9912 was merged at 43479875f before its later review correction reached main. This independent PR applies that correction on main e634ec61... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width