René's URL Explorer Experiment


Title: Refresh profile state after eval-breaker callbacks by youknowdot · Pull Request #9931 · RustPython/RustPython · GitHub

Open Graph Title: Refresh profile state after eval-breaker callbacks by youknowdot · Pull Request #9931 · RustPython/RustPython

X Title: Refresh profile state after eval-breaker callbacks by youknowdot · Pull Request #9931 · RustPython/RustPython

Description: Follow-up to #9912: refresh profile state after callbacks #9912 was merged at 43479875f before its later review correction reached main. This independent PR applies that correction on main e634ec61. A signal handler or scheduled GC callback can change sys.setprofile during eval-breaker work. Refresh the cached tracing flag after that work, before dispatching the current instruction. The refresh runs only when the eval breaker is tripped; it does not add an unconditional load to the normal hot path. Preserve the generator-preparation guard and existing exception unwind. Addresses the independently reproduced finding in #9912 (comment) . No workflow, skip, dependency, monitoring architecture or bytecode changes. Validation scope The same correction was tested as 128a3eccb on #9912's pre-merge feature branch, before this transplant onto current main: Matched Rust 1.100 thin-LTO release build passed. Targeted warmed positional list.append signal deliveries: pre-fix 100/100 missed the profile pair; corrected 100/100 emitted it. General delivery probes matched actual append count to C calls, both in corrected RustPython and CPython 3.15.2 (100 cases each). GC callback profiling on/off and signal-handler exception unwind probes passed in corrected RustPython and CPython 3.15.2. Canonical test_profile, test_sys_setprofile, test_sys_settrace, test_monitoring: 582 tests, 82 existing skips, all passed. Original warmed native-call regression group passed. Same-machine, CPU-pinned alternating 11-sample CPU-time measurements were noisy; they are limited local evidence, not a statistically established no-regression claim or a matched current-main benchmark. Detailed results will be added after verification. Exact transplanted-head validation so far: focused normal hooks/Rustfmt/whitespace checks passed. Current main also contains newly merged signature changes, so the preceding runtime results must not be represented as exact-current-main execution. Fresh CI and current-main validation are pending. Keep draft; no automatic merge. The signal probes are external timing-sensitive diagnostics rather than flaky mandatory tests. Non-POSIX signal behavior was not tested locally. Existing profile callback error swallowing is out of scope; this does not claim complete profiling parity. AI assistance: OpenAI Codex assisted implementation, independent review and validation. Exact model version is unavailable and not guessed. Exact transplanted head c1f08ba Fresh Rust 1.100 release build on current base e634ec61 passed. Its runtime passed: General POSIX signal delivery accounting: 100 cases, every executed append matched a C call. Targeted warmed append signal deliveries: 100/100 correct C call/return pairs. GC callback profile enable/disable, signal-handler exception unwind, and the native descriptor/warmed-call regression probe. Canonical test_profile, test_sys_setprofile, test_sys_settrace, test_monitoring: 582 tests, 82 existing skips, all passed. The identical correction before transplant (128a3eccb) additionally passed the full workspace Rust tests/doctests (1597 passed, 21 ignored), separate C-API tests (153 passed, 2 ignored), and both workspace/all-target and C-API/all-target strict Clippy. Those aggregate checks were not rerun after transplant; current-main runtime results above are separate. Final pre-transplant matched CPU-time benchmark medians (11 alternating CPU-pinned samples): loop -1.05%, Python calls +1.19%, native calls -1.58%, generator -1.13%. This is noisy local evidence, not a statistically proven performance result or current-main matched benchmark. Fresh hosted CI remains required. No automatic merge.

Open Graph Description: Follow-up to #9912: refresh profile state after callbacks #9912 was merged at 43479875f before its later review correction reached main. This independent PR applies that correction on main e634ec61...

X Description: Follow-up to #9912: refresh profile state after callbacks #9912 was merged at 43479875f before its later review correction reached main. This independent PR applies that correction on main e634ec61...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9931

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2841574b-13ab-2658-7824-eb03cbc924f6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB416:21AC3F:40EEE48:52297B6:6B01FE4F
html-safe-nonce63d5e3aa9059629078255af68de77aa0ce98299aeb6c08b4b3b555d8caeec2bb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDE2OjIxQUMzRjo0MEVFRTQ4OjUyMjk3QjY6NkIwMUZFNEYiLCJ2aXNpdG9yX2lkIjoiMTA3NjIxNjY1MDM3NTc1NzM5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdb0c12ae4410e29311cc2dc24a8f8844f0f61d1c10eccda4feba3f2ca352a875
hovercard-subject-tagpull_request:5361725274
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9931/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altFollow-up to #9912: refresh profile state after callbacks #9912 was merged at 43479875f before its later review correction reached main. This independent PR applies that correction on main e634ec61...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9931/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9931%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9931%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9931/files
Reloadhttps://github.com/RustPython/RustPython/pull/9931/files
Reloadhttps://github.com/RustPython/RustPython/pull/9931/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/profile-after-eval-breaker-20261117https://github.com/youknowdot/RustPython/tree/fix/profile-after-eval-breaker-20261117
Conversation 3 https://github.com/RustPython/RustPython/pull/9931
Commits 1 https://github.com/RustPython/RustPython/pull/9931/commits
Checks 20 https://github.com/RustPython/RustPython/pull/9931/checks
Files changed https://github.com/RustPython/RustPython/pull/9931/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9931/files
Refresh profile state after eval-breaker callbacks https://github.com/RustPython/RustPython/pull/9931/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9931/files
c1f08ba Refresh profiling state after eval-breaker callbacks youknowdot Nov 17, 2026 https://github.com/RustPython/RustPython/pull/9931/commits/c1f08ba183e583f6fb27382f87287f82009cbabd
Clear filters https://github.com/RustPython/RustPython/pull/9931/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9931/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9931/files
crates/vm/src/frame.rshttps://github.com/RustPython/RustPython/pull/9931/files#diff-03f2741d7d424014f3d2f0c82226be52fa58134aab34bf0780714ee67a248deb
View file https://github.com/youknowdot/RustPython/blob/c1f08ba183e583f6fb27382f87287f82009cbabd/crates/vm/src/frame.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9931/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9931/files#diff-03f2741d7d424014f3d2f0c82226be52fa58134aab34bf0780714ee67a248deb
https://github.com/RustPython/RustPython/pull/9931/files#diff-03f2741d7d424014f3d2f0c82226be52fa58134aab34bf0780714ee67a248deb
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9931/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.