René's URL Explorer Experiment


Title: Report a bad `struct` format before converting the other arguments by jseop-lim · Pull Request #9928 · RustPython/RustPython · GitHub

Open Graph Title: Report a bad `struct` format before converting the other arguments by jseop-lim · Pull Request #9928 · RustPython/RustPython

X Title: Report a bad `struct` format before converting the other arguments by jseop-lim · Pull Request #9928 · RustPython/RustPython

Description: Part of #9913 (item 5) This PR follows our AI policy Summary The module-level struct functions, such as pack_into, bind every argument first and parse the format in the function body, so a buffer or offset that fails to convert hides the struct.error for a bad format. CPython's argument clinic runs cache_struct_converter on the format before it converts the arguments after it. AS-IS >>> import struct >>> struct.pack_into("Z", bytearray(4), 10**100) OverflowError: Python int too large to convert to Rust isize >>> struct.unpack_from("Z", b"", 10**100) OverflowError: Python int too large to convert to Rust isize >>> struct.unpack("Z", 5) TypeError: a bytes-like object is required, not 'int' TO-BE >>> struct.pack_into("Z", bytearray(4), 10**100) struct.error: bad char in struct format >>> struct.unpack_from("Z", b"", 10**100) struct.error: bad char in struct format >>> struct.unpack("Z", 5) struct.error: bad char in struct format (matching CPython) Changes In crates/stdlib/src/pystruct.rs, add CachedFormatSpec, which parses the format through the cache while the argument is bound, and bind the format of pack, pack_into, unpack, unpack_from, iter_unpack and calcsize as it. Extend extra_tests/snippets/stdlib_struct.py with a bad format next to an offset that does not fit and next to a buffer that is not bytes-like. Test plan Built and run on macOS aarch64 against upstream/main 7abccf0, using the CI feature set --no-default-features --features stdlib,importlib,stdio,encodings,sqlite,ssl-rustls-aws-lc,host_env,doc,ucd_3_2_0, plus threading, compared with CPython 3.15.2. The extended extra_tests/snippets/stdlib_struct.py fails on an unpatched build of that commit (at struct.pack_into("Z", bytearray(4), 10**100)) and passes with the patch and under CPython 3.15.2. A probe of 14 calls over pack_into, unpack_from, unpack and iter_unpack, mixing a bad format, a non-buffer and an offset that does not fit, gives the same exception class as CPython 3.15.2 for all 14. Eight of them differ on the unpatched build. rustpython -m test test_struct test_memoryview test_array test_buffer: 1,415 run, 161 skipped, all pass, as on the unpatched build. cargo fmt --check clean, cargo clippy -p rustpython-vm -p rustpython-stdlib --all-targets reports nothing in the changed files (one warning in _ctypes/base.rs that the unpatched tree also has), and the pre-commit hooks other than cspell and prettier pass on both changed files. I used Claude Code (claude-fable-5-2) to draft the analysis, the patch and this description; Claude Code ran the commands above; I reviewed the diff and their output. Summary by CodeRabbit Bug Fixes Invalid struct formats are checked across packing and unpacking operations, including cases with extreme offsets or incompatible input. These cases raise struct.error.

Open Graph Description: Part of #9913 (item 5) This PR follows our AI policy Summary The module-level struct functions, such as pack_into, bind every argument first and parse the format in the function body, so a buffer...

X Description: Part of #9913 (item 5) This PR follows our AI policy Summary The module-level struct functions, such as pack_into, bind every argument first and parse the format in the function body, so a buffer...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9928

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:27adbb1e-9860-c728-383c-4d915c86d2aa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB816:FC5BE:2E8D76C:3DDF094:6B01D7EE
html-safe-noncef59572c01b6b59ca3c603d53f98d3c25dd897467c76b73098cc7df94600ce854
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODE2OkZDNUJFOjJFOEQ3NkM6M0RERjA5NDo2QjAxRDdFRSIsInZpc2l0b3JfaWQiOiI1NjMwODkxMzI0NDU1NjM5MDIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac95edb9277a8f495829739454667a90e6d572cd49c46f6518e15a7f8d9b4d3265
hovercard-subject-tagpull_request:5361514554
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9928/files
twitter:imagehttps://avatars.githubusercontent.com/u/86508420?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/86508420?s=400&v=4
og:image:altPart of #9913 (item 5) This PR follows our AI policy Summary The module-level struct functions, such as pack_into, bind every argument first and parse the format in the function body, so a buffer...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9928/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9928%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9928%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9928/files
Reloadhttps://github.com/RustPython/RustPython/pull/9928/files
Reloadhttps://github.com/RustPython/RustPython/pull/9928/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests132 (132)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
jseop-limhttps://github.com/jseop-lim
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
jseop-lim:fix/struct-format-before-argshttps://github.com/jseop-lim/RustPython/tree/fix/struct-format-before-args
Conversation 4 https://github.com/RustPython/RustPython/pull/9928
Commits 1 https://github.com/RustPython/RustPython/pull/9928/commits
Checks 20 https://github.com/RustPython/RustPython/pull/9928/checks
Files changed 2 https://github.com/RustPython/RustPython/pull/9928/files
Report a bad struct format before converting the other arguments https://github.com/RustPython/RustPython/pull/9928/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9928/files
d4cde2d Report a bad `struct` format before converting the other arguments jseop-lim Nov 17, 2026 https://github.com/RustPython/RustPython/pull/9928/commits/d4cde2dbd5000dc1dece317ed834b5f88b0443e8
Clear filters https://github.com/RustPython/RustPython/pull/9928/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9928/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9928/files
pystruct.rs https://github.com/RustPython/RustPython/pull/9928/files#diff-399bd78b8c0a565ea9cd285a9b663037b08439722ecbfdf8011fedc30f7c1d66
stdlib_struct.py https://github.com/RustPython/RustPython/pull/9928/files#diff-5db26d3f32fdd6c8bd6d2a6e64cb004449f022c7cc31364f1f24db5b947d6d2f
crates/stdlib/src/pystruct.rshttps://github.com/RustPython/RustPython/pull/9928/files#diff-399bd78b8c0a565ea9cd285a9b663037b08439722ecbfdf8011fedc30f7c1d66
View file https://github.com/RustPython/RustPython/blob/d4cde2dbd5000dc1dece317ed834b5f88b0443e8/crates/stdlib/src/pystruct.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9928/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9928/files#diff-399bd78b8c0a565ea9cd285a9b663037b08439722ecbfdf8011fedc30f7c1d66
youknowonehttps://github.com/youknowone
Nov 18, 2026https://github.com/RustPython/RustPython/pull/9928/files#r4607936450
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9928/files
https://github.com/RustPython/RustPython/pull/9928/files#diff-399bd78b8c0a565ea9cd285a9b663037b08439722ecbfdf8011fedc30f7c1d66
https://github.com/RustPython/RustPython/pull/9928/files#diff-399bd78b8c0a565ea9cd285a9b663037b08439722ecbfdf8011fedc30f7c1d66
https://github.com/RustPython/RustPython/pull/9928/files#diff-399bd78b8c0a565ea9cd285a9b663037b08439722ecbfdf8011fedc30f7c1d66
https://github.com/RustPython/RustPython/pull/9928/files#diff-399bd78b8c0a565ea9cd285a9b663037b08439722ecbfdf8011fedc30f7c1d66
https://github.com/RustPython/RustPython/pull/9928/files#diff-399bd78b8c0a565ea9cd285a9b663037b08439722ecbfdf8011fedc30f7c1d66
https://github.com/RustPython/RustPython/pull/9928/files#diff-399bd78b8c0a565ea9cd285a9b663037b08439722ecbfdf8011fedc30f7c1d66
extra_tests/snippets/stdlib_struct.pyhttps://github.com/RustPython/RustPython/pull/9928/files#diff-5db26d3f32fdd6c8bd6d2a6e64cb004449f022c7cc31364f1f24db5b947d6d2f
View file https://github.com/RustPython/RustPython/blob/d4cde2dbd5000dc1dece317ed834b5f88b0443e8/extra_tests/snippets/stdlib_struct.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9928/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9928/files#diff-5db26d3f32fdd6c8bd6d2a6e64cb004449f022c7cc31364f1f24db5b947d6d2f
https://github.com/RustPython/RustPython/pull/9928/files#diff-5db26d3f32fdd6c8bd6d2a6e64cb004449f022c7cc31364f1f24db5b947d6d2f
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9928/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.