René's URL Explorer Experiment


Title: Hash a `str` subclass attribute name through its own `__hash__` by jseop-lim · Pull Request #9921 · RustPython/RustPython · GitHub

Open Graph Title: Hash a `str` subclass attribute name through its own `__hash__` by jseop-lim · Pull Request #9921 · RustPython/RustPython

X Title: Hash a `str` subclass attribute name through its own `__hash__` by jseop-lim · Pull Request #9921 · RustPython/RustPython

Description: Part of #9913 (item 15) This PR follows our AI policy Summary generic_getattr_opt and generic_setattr look the name up in the instance __dict__ as a Py key, which hashes the string data. A str subclass's __hash__ is never called, so an exception it raises is lost and getattr returns its default. CPython's _PyObject_GenericGetAttrWithDict passes the name object to PyDict_GetItemRef, which hashes it with PyObject_Hash. AS-IS >>> class RaisingHashName(str): ... def __hash__(self): raise ZeroDivisionError ... >>> class K: pass ... >>> getattr(K(), RaisingHashName("x"), 0) 0 >>> hasattr(K(), RaisingHashName("x")) False >>> setattr(K(), RaisingHashName("x"), 0) TO-BE >>> getattr(K(), RaisingHashName("x"), 0) ZeroDivisionError >>> hasattr(K(), RaisingHashName("x")) ZeroDivisionError >>> setattr(K(), RaisingHashName("x"), 0) ZeroDivisionError (matching CPython 3.15.2) Changes In crates/vm/src/protocol/object.rs, generic_getattr_opt and generic_setattr use the name object as the __dict__ key when it is not an exact str. An exact str keeps the Py key. A lookup skips an empty __dict__ unless the type has a managed dict and no item size, which keeps getattr(lambda: 0, RaisingHashName("x"), 0) returning 0 as it does in CPython, where a function has no __dict__ until one is needed. Extend extra_tests/snippets/builtin_object.py with getattr, hasattr and setattr given such a name on an instance, and getattr on object(). Not changed, all as before this PR: delattr still raises AttributeError before hashing the name. A name that matches a data descriptor on the type is still found by its string data. An object whose __dict__ exists but is empty and is not a managed dict still skips the hash where CPython calls it: a function or exception after its __dict__ was read or emptied, types.SimpleNamespace() and threading.local(). setattr on a threading.local() skips it too. Test plan Built and run on macOS aarch64 against upstream/main 7abccf0, using the CI feature set --no-default-features --features stdlib,importlib,stdio,encodings,sqlite,ssl-rustls-aws-lc,host_env,doc,ucd_3_2_0, plus threading, compared with CPython 3.15.2. The extended extra_tests/snippets/builtin_object.py fails on an unpatched build of that commit (AssertionError: ZeroDivisionError was not raised) and passes with the patch and under CPython 3.15.2. A probe of 12 attribute operations with 5 kinds of name on 73 kinds of object (4,380 lines) differs from CPython in 1,385 lines on the unpatched build and in 662 with the patch, and in no line that matched before. rustpython -m test test_builtin test_class test_descr test_dict test_str test_module test_funcattrs test_types test_inspect test_functools test_dataclasses test_enum: 2,955 run, 114 skipped, 3 failures, the same three on the unpatched build (test_inspect's TestModuleCLI.test_details_option_*). cargo fmt --check clean, cargo clippy -p rustpython-vm -p rustpython-stdlib --all-targets adds no warning, and the pre-commit hooks other than cspell and prettier pass on both changed files. I used Claude Code (claude-fable-5-2) to draft the analysis, the patch and this description; Claude Code ran the commands above; I reviewed the diff and their output. Summary by CodeRabbit Bug Fixes Corrected attribute lookup and assignment behavior when attribute names are str subclasses. Custom hashing errors now propagate for user-defined objects, while built-in objects continue to return the expected default for missing attributes.

Open Graph Description: Part of #9913 (item 15) This PR follows our AI policy Summary generic_getattr_opt and generic_setattr look the name up in the instance __dict__ as a Py<PyStr> key, which hashes the string d...

X Description: Part of #9913 (item 15) This PR follows our AI policy Summary generic_getattr_opt and generic_setattr look the name up in the instance __dict__ as a Py&lt;PyStr&gt; key, which hashes the ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9921

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d3bdb220-c5ab-0569-35c1-8c4d41641133
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8158:3F8AB1:37FB3A5:47202EF:6B01D807
html-safe-nonce09033cb1a5fb9a1564d0bebb905823a7b92e1db4f914dfb58f1734f70b8569d3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTU4OjNGOEFCMTozN0ZCM0E1OjQ3MjAyRUY6NkIwMUQ4MDciLCJ2aXNpdG9yX2lkIjoiNjI4ODI0NzcwODQ2OTgxMTIwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc77c52560076aac3caf6858949c4d51d226cd69f91e903558e51e6b862fa3f4d
hovercard-subject-tagpull_request:5361505838
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9921/files
twitter:imagehttps://avatars.githubusercontent.com/u/86508420?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/86508420?s=400&v=4
og:image:altPart of #9913 (item 15) This PR follows our AI policy Summary generic_getattr_opt and generic_setattr look the name up in the instance __dict__ as a Py<PyStr> key, which hashes the string d...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9921/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9921%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9921%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9921/files
Reloadhttps://github.com/RustPython/RustPython/pull/9921/files
Reloadhttps://github.com/RustPython/RustPython/pull/9921/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests132 (132)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
jseop-limhttps://github.com/jseop-lim
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
jseop-lim:fix/getattr-str-subclass-hashhttps://github.com/jseop-lim/RustPython/tree/fix/getattr-str-subclass-hash
Conversation 9 https://github.com/RustPython/RustPython/pull/9921
Commits 1 https://github.com/RustPython/RustPython/pull/9921/commits
Checks 19 https://github.com/RustPython/RustPython/pull/9921/checks
Files changed 2 https://github.com/RustPython/RustPython/pull/9921/files
Hash a str subclass attribute name through its own __hash__ https://github.com/RustPython/RustPython/pull/9921/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9921/files
073c085 Hash a `str` subclass attribute name through its own `__hash__` jseop-lim Nov 17, 2026 https://github.com/RustPython/RustPython/pull/9921/commits/073c085bdf7a3438febfa1fb394e8148552006c6
Clear filters https://github.com/RustPython/RustPython/pull/9921/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9921/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9921/files
object.rs https://github.com/RustPython/RustPython/pull/9921/files#diff-e15b9e7d637d4c91a7e282e6a4d8fa79bd36b67b3453ada8136d66895a3ee75d
builtin_object.py https://github.com/RustPython/RustPython/pull/9921/files#diff-edf28ac9db89942fd4e725257fe461bc136a3c44e594d03264cde9d7b74791e2
crates/vm/src/protocol/object.rshttps://github.com/RustPython/RustPython/pull/9921/files#diff-e15b9e7d637d4c91a7e282e6a4d8fa79bd36b67b3453ada8136d66895a3ee75d
View file https://github.com/RustPython/RustPython/blob/073c085bdf7a3438febfa1fb394e8148552006c6/crates/vm/src/protocol/object.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9921/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9921/files#diff-e15b9e7d637d4c91a7e282e6a4d8fa79bd36b67b3453ada8136d66895a3ee75d
https://github.com/RustPython/RustPython/pull/9921/files#diff-e15b9e7d637d4c91a7e282e6a4d8fa79bd36b67b3453ada8136d66895a3ee75d
https://github.com/RustPython/RustPython/pull/9921/files#diff-e15b9e7d637d4c91a7e282e6a4d8fa79bd36b67b3453ada8136d66895a3ee75d
chatgpt-codex-connectorhttps://github.com/apps/chatgpt-codex-connector
Nov 18, 2026https://github.com/RustPython/RustPython/pull/9921/files#r4612894071
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://camo.githubusercontent.com/0854bfc38139c0d2b58a9d5d71f5ad92840cf0c17144621e462b474041793354/68747470733a2f2f696d672e736869656c64732e696f2f62616467652f50322d79656c6c6f773f7374796c653d666c6174
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9921/files
coderabbitaihttps://github.com/apps/coderabbitai
Nov 18, 2026https://github.com/RustPython/RustPython/pull/9921/files#r4612902391
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
raw.githubusercontent.comhttps://raw.githubusercontent.com/RustPython/RustPython/073c085bdf7a3438febfa1fb394e8148552006c6/crates/vm/src/protocol/object.rs
raw.githubusercontent.comhttps://raw.githubusercontent.com/RustPython/RustPython/073c085bdf7a3438febfa1fb394e8148552006c6/crates/vm/src/builtins/dict.rs
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9921/files
youknowonehttps://github.com/youknowone
Nov 18, 2026https://github.com/RustPython/RustPython/pull/9921/files#r4607914788
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9921/files
https://github.com/RustPython/RustPython/pull/9921/files#diff-e15b9e7d637d4c91a7e282e6a4d8fa79bd36b67b3453ada8136d66895a3ee75d
https://github.com/RustPython/RustPython/pull/9921/files#diff-e15b9e7d637d4c91a7e282e6a4d8fa79bd36b67b3453ada8136d66895a3ee75d
coderabbitaihttps://github.com/apps/coderabbitai
Nov 18, 2026https://github.com/RustPython/RustPython/pull/9921/files#r4612902406
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
raw.githubusercontent.comhttps://raw.githubusercontent.com/RustPython/RustPython/073c085bdf7a3438febfa1fb394e8148552006c6/crates/vm/src/builtins/function.rs
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9921/files
coderabbitaihttps://github.com/apps/coderabbitai
Nov 18, 2026https://github.com/RustPython/RustPython/pull/9921/files#r4612902416
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
raw.githubusercontent.comhttps://raw.githubusercontent.com/RustPython/RustPython/073c085bdf7a3438febfa1fb394e8148552006c6/crates/vm/src/protocol/object.rs
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9921/files
https://github.com/RustPython/RustPython/pull/9921/files#diff-e15b9e7d637d4c91a7e282e6a4d8fa79bd36b67b3453ada8136d66895a3ee75d
extra_tests/snippets/builtin_object.pyhttps://github.com/RustPython/RustPython/pull/9921/files#diff-edf28ac9db89942fd4e725257fe461bc136a3c44e594d03264cde9d7b74791e2
View file https://github.com/RustPython/RustPython/blob/073c085bdf7a3438febfa1fb394e8148552006c6/extra_tests/snippets/builtin_object.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9921/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9921/files#diff-edf28ac9db89942fd4e725257fe461bc136a3c44e594d03264cde9d7b74791e2
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9921/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.