René's URL Explorer Experiment


Title: Hash a `str` subclass name in the `csv` dialect registry by jseop-lim · Pull Request #9918 · RustPython/RustPython · GitHub

Open Graph Title: Hash a `str` subclass name in the `csv` dialect registry by jseop-lim · Pull Request #9918 · RustPython/RustPython

X Title: Hash a `str` subclass name in the `csv` dialect registry by jseop-lim · Pull Request #9918 · RustPython/RustPython

Description: Part of #9913 (item 11) This PR follows our AI policy Summary register_dialect, get_dialect and unregister_dialect key the registry on the text of a str name and hash only a name that is not a str (#9514), so a str subclass that overrides __hash__ is never hashed. CPython keeps the registry in a dict and passes the name object to PyDict_SetItem, PyDict_GetItemRef and PyDict_Pop, which call its __hash__. AS-IS >>> import csv >>> class BadHash(str): ... def __hash__(self): raise ValueError ... >>> csv.register_dialect(BadHash("x")) >>> csv.get_dialect(BadHash("excel")) <_csv.Dialect object at 0xa91be8180> >>> csv.unregister_dialect(BadHash("excel")) TO-BE >>> csv.register_dialect(BadHash("x")) ValueError >>> csv.get_dialect(BadHash("excel")) ValueError >>> csv.unregister_dialect(BadHash("excel")) ValueError (matching CPython 3.15.2) A __hash__ that returns a non-integer raises TypeError in both; CPython 3.15 words it as cannot use 'StrHash' as a dict key (__hash__ method should return an integer). Changes In crates/stdlib/src/csv.rs, registry_key() hashes every name before checking that it is a str, and register_dialect() hashes the name once the dialect is validated, where CPython inserts it. Extend test_dialect_name_hashing in extra_tests/snippets/stdlib_csv.py with a str subclass whose __hash__ raises, passed to all three functions, and with an invalid dialect, which is still reported first. Test plan Built and run on macOS aarch64 against upstream/main 7abccf0, using the CI feature set --no-default-features --features stdlib,importlib,stdio,encodings,sqlite,ssl-rustls-aws-lc,host_env,doc,ucd_3_2_0, plus threading, compared with CPython 3.15.2. The extended extra_tests/snippets/stdlib_csv.py fails on an unpatched build of that commit (at csv.register_dialect(UnhashableStr("excel"))) and passes with the patch. rustpython -m test test_csv: 140 run, 6 skipped, all pass, as on the unpatched build. cargo fmt --check clean, cargo clippy -p rustpython-vm -p rustpython-stdlib --all-targets reports nothing in the changed files, and the pre-commit hooks other than cspell and prettier pass on the changed files. I used Claude Code (claude-fable-5-2) to draft the analysis, the patch and this description; Claude Code ran the commands above; I reviewed the diff and their output.

Open Graph Description: Part of #9913 (item 11) This PR follows our AI policy Summary register_dialect, get_dialect and unregister_dialect key the registry on the text of a str name and hash only a name that is not a st...

X Description: Part of #9913 (item 11) This PR follows our AI policy Summary register_dialect, get_dialect and unregister_dialect key the registry on the text of a str name and hash only a name that is not a st...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9918

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4d3b5e7d-a462-8978-2261-d570ee671afa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB21E:14700E:35E1A95:446EF22:6B01E403
html-safe-noncec0e8809d1ee53e7157c64e085aca1b8453f3a6733da2b00267e071e7d915c4cf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjFFOjE0NzAwRTozNUUxQTk1OjQ0NkVGMjI6NkIwMUU0MDMiLCJ2aXNpdG9yX2lkIjoiNzQxMDAxMDQwMjE2NTIyMDM1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc2d5832f46f7d9ab07b6cfd8239ba6052eac1ded15ab743e69e98ff071ca0dad
hovercard-subject-tagpull_request:5361502525
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9918/files
twitter:imagehttps://avatars.githubusercontent.com/u/86508420?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/86508420?s=400&v=4
og:image:altPart of #9913 (item 11) This PR follows our AI policy Summary register_dialect, get_dialect and unregister_dialect key the registry on the text of a str name and hash only a name that is not a st...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9918/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9918%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9918%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9918/files
Reloadhttps://github.com/RustPython/RustPython/pull/9918/files
Reloadhttps://github.com/RustPython/RustPython/pull/9918/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
jseop-lim:fix/csv-dialect-name-hashhttps://github.com/jseop-lim/RustPython/tree/fix/csv-dialect-name-hash
Conversation 2 https://github.com/RustPython/RustPython/pull/9918
Commits 1 https://github.com/RustPython/RustPython/pull/9918/commits
Checks 19 https://github.com/RustPython/RustPython/pull/9918/checks
Files changed https://github.com/RustPython/RustPython/pull/9918/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9918/files
Hash a str subclass name in the csv dialect registry https://github.com/RustPython/RustPython/pull/9918/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9918/files
6f9cd45 Hash a str subclass name in the csv dialect registry jseop-lim Nov 17, 2026 https://github.com/RustPython/RustPython/pull/9918/commits/6f9cd454d6db81aef6994e6ea3485df3159ef05a
Clear filters https://github.com/RustPython/RustPython/pull/9918/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9918/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9918/files
csv.rs https://github.com/RustPython/RustPython/pull/9918/files#diff-acf098d7e921238a0873aca66fb246b2f9e424ac9fac0419462c7cbad68c95a8
stdlib_csv.py https://github.com/RustPython/RustPython/pull/9918/files#diff-3d834bd9b008124d1d115c12c5a34a5b18603e108f9ea2ea03f9d506bd9161bd
crates/stdlib/src/csv.rshttps://github.com/RustPython/RustPython/pull/9918/files#diff-acf098d7e921238a0873aca66fb246b2f9e424ac9fac0419462c7cbad68c95a8
View file https://github.com/jseop-lim/RustPython/blob/6f9cd454d6db81aef6994e6ea3485df3159ef05a/crates/stdlib/src/csv.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9918/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9918/files#diff-acf098d7e921238a0873aca66fb246b2f9e424ac9fac0419462c7cbad68c95a8
https://github.com/RustPython/RustPython/pull/9918/files#diff-acf098d7e921238a0873aca66fb246b2f9e424ac9fac0419462c7cbad68c95a8
extra_tests/snippets/stdlib_csv.pyhttps://github.com/RustPython/RustPython/pull/9918/files#diff-3d834bd9b008124d1d115c12c5a34a5b18603e108f9ea2ea03f9d506bd9161bd
View file https://github.com/jseop-lim/RustPython/blob/6f9cd454d6db81aef6994e6ea3485df3159ef05a/extra_tests/snippets/stdlib_csv.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9918/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9918/files#diff-3d834bd9b008124d1d115c12c5a34a5b18603e108f9ea2ea03f9d506bd9161bd
https://github.com/RustPython/RustPython/pull/9918/files#diff-3d834bd9b008124d1d115c12c5a34a5b18603e108f9ea2ea03f9d506bd9161bd
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9918/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.