René's URL Explorer Experiment


Title: Restore repeat and mark state when the regex engine backtracks by luantaraschi · Pull Request #9896 · RustPython/RustPython · GitHub

Open Graph Title: Restore repeat and mark state when the regex engine backtracks by luantaraschi · Pull Request #9896 · RustPython/RustPython

X Title: Restore repeat and mark state when the regex engine backtracks by luantaraschi · Pull Request #9896 · RustPython/RustPython

Description: This PR follows our AI policy Summary sre_engine left some state behind when the matcher backtracked, so re gave answers CPython doesn't: >>> re.match(r"(?:a*|b){2}x", "bbx") None # CPython: span=(0, 3) >>> re.fullmatch(r"(?:x(?:ab)*?){2,3}?", "xabxab") None # CPython: span=(0, 6) >>> re.match(r"(a)?(?>> re.match(r"(?:a*)+?b", "a") # allocates until it runs out of memory; CPython: None There are three causes, and each fix follows Modules/_sre/sre_lib.h: MIN_UNTIL set the repeat's last_position before trying one more iteration and never put it back, so the empty match guard compared against a stale position. CPython saves and restores last_ptr around that iteration (LAST_PTR_PUSH/LAST_PTR_POP), and the new Jump::MinUntil2 does the same. MIN_UNTIL also took the repeat from repeat_stack.last_mut() instead of ctx.repeat_ctx_id, which is the inner repeat when two lazy repeats are nested. MAX_UNTIL increments the count before deciding what to do. CPython keeps the new count in a local and only stores it on the paths that iterate, but here the path that goes straight to the tail kept it, so when the tail failed and the matcher went back into the body it saw one iteration too many. BRANCH, REPEAT_ONE, MIN_REPEAT_ONE, MIN_UNTIL and ASSERT_NOT push a copy of the marks and kept it on success, where CPython does MARK_POP_DISCARD. Inside a lookaround that copy outlives the lookaround, and the next failing alternative outside restores it instead of its own, which is how group 1 above ends up set. Restoring the right snapshot made (\w+)(?

Open Graph Description: This PR follows our AI policy Summary sre_engine left some state behind when the matcher backtracked, so re gave answers CPython doesn't: >>> re.match(r"(?:a*|b){2}x", "...

X Description: This PR follows our AI policy Summary sre_engine left some state behind when the matcher backtracked, so re gave answers CPython doesn't: >>> re.match(r"(?:a*...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9896

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1359d105-10a0-d1c7-be3d-ab2b3ca23828
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id882A:3DCD28:11E7C3D:17C75D6:6B01E8A7
html-safe-noncecec37fdb603efc8e5925052c72dba968b0cfbdd18296e9a4c04a64bb3eb68f41
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODJBOjNEQ0QyODoxMUU3QzNEOjE3Qzc1RDY6NkIwMUU4QTciLCJ2aXNpdG9yX2lkIjoiNTE0NTkxMzUwMDExMTA3MTM5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0ae3c9d426e4a3808ec7d9d62f577df14ad42c99a9f6ccc457394091d65b445b
hovercard-subject-tagpull_request:5348277327
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9896/files
twitter:imagehttps://avatars.githubusercontent.com/u/130802253?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/130802253?s=400&v=4
og:image:altThis PR follows our AI policy Summary sre_engine left some state behind when the matcher backtracked, so re gave answers CPython doesn't: >>> re.match(r"(?:a*|b){2}x", "...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9896/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9896%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9896%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9896/files
Reloadhttps://github.com/RustPython/RustPython/pull/9896/files
Reloadhttps://github.com/RustPython/RustPython/pull/9896/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
luantaraschi:sre-restore-repeat-statehttps://github.com/luantaraschi/RustPython/tree/sre-restore-repeat-state
Conversation 3 https://github.com/RustPython/RustPython/pull/9896
Commits 1 https://github.com/RustPython/RustPython/pull/9896/commits
Checks 19 https://github.com/RustPython/RustPython/pull/9896/checks
Files changed https://github.com/RustPython/RustPython/pull/9896/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9896/files
Restore repeat and mark state when the regex engine backtracks https://github.com/RustPython/RustPython/pull/9896/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/9896/files
37fa696 sre_engine: restore repeat and mark state when backtracking luantaraschi Nov 16, 2026 https://github.com/RustPython/RustPython/pull/9896/commits/37fa6961954acd96c52deb03dcb3c6e927872f0f
Clear filters https://github.com/RustPython/RustPython/pull/9896/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9896/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9896/files
engine.rs https://github.com/RustPython/RustPython/pull/9896/files#diff-6d936413d5960b33aca7fe5bcb3cf4bf21c50ad7232e4e47daae86010dc843ff
stdlib_re.py https://github.com/RustPython/RustPython/pull/9896/files#diff-516ae05455c2584ebca0fbf07ee77b992fe8f68f8fc7c621221e8442ced0d6af
crates/sre_engine/src/engine.rshttps://github.com/RustPython/RustPython/pull/9896/files#diff-6d936413d5960b33aca7fe5bcb3cf4bf21c50ad7232e4e47daae86010dc843ff
View file https://github.com/luantaraschi/RustPython/blob/37fa6961954acd96c52deb03dcb3c6e927872f0f/crates/sre_engine/src/engine.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9896/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9896/files#diff-6d936413d5960b33aca7fe5bcb3cf4bf21c50ad7232e4e47daae86010dc843ff
https://github.com/RustPython/RustPython/pull/9896/files#diff-6d936413d5960b33aca7fe5bcb3cf4bf21c50ad7232e4e47daae86010dc843ff
https://github.com/RustPython/RustPython/pull/9896/files#diff-6d936413d5960b33aca7fe5bcb3cf4bf21c50ad7232e4e47daae86010dc843ff
https://github.com/RustPython/RustPython/pull/9896/files#diff-6d936413d5960b33aca7fe5bcb3cf4bf21c50ad7232e4e47daae86010dc843ff
https://github.com/RustPython/RustPython/pull/9896/files#diff-6d936413d5960b33aca7fe5bcb3cf4bf21c50ad7232e4e47daae86010dc843ff
https://github.com/RustPython/RustPython/pull/9896/files#diff-6d936413d5960b33aca7fe5bcb3cf4bf21c50ad7232e4e47daae86010dc843ff
https://github.com/RustPython/RustPython/pull/9896/files#diff-6d936413d5960b33aca7fe5bcb3cf4bf21c50ad7232e4e47daae86010dc843ff
https://github.com/RustPython/RustPython/pull/9896/files#diff-6d936413d5960b33aca7fe5bcb3cf4bf21c50ad7232e4e47daae86010dc843ff
https://github.com/RustPython/RustPython/pull/9896/files#diff-6d936413d5960b33aca7fe5bcb3cf4bf21c50ad7232e4e47daae86010dc843ff
https://github.com/RustPython/RustPython/pull/9896/files#diff-6d936413d5960b33aca7fe5bcb3cf4bf21c50ad7232e4e47daae86010dc843ff
https://github.com/RustPython/RustPython/pull/9896/files#diff-6d936413d5960b33aca7fe5bcb3cf4bf21c50ad7232e4e47daae86010dc843ff
https://github.com/RustPython/RustPython/pull/9896/files#diff-6d936413d5960b33aca7fe5bcb3cf4bf21c50ad7232e4e47daae86010dc843ff
https://github.com/RustPython/RustPython/pull/9896/files#diff-6d936413d5960b33aca7fe5bcb3cf4bf21c50ad7232e4e47daae86010dc843ff
https://github.com/RustPython/RustPython/pull/9896/files#diff-6d936413d5960b33aca7fe5bcb3cf4bf21c50ad7232e4e47daae86010dc843ff
https://github.com/RustPython/RustPython/pull/9896/files#diff-6d936413d5960b33aca7fe5bcb3cf4bf21c50ad7232e4e47daae86010dc843ff
extra_tests/snippets/stdlib_re.pyhttps://github.com/RustPython/RustPython/pull/9896/files#diff-516ae05455c2584ebca0fbf07ee77b992fe8f68f8fc7c621221e8442ced0d6af
View file https://github.com/luantaraschi/RustPython/blob/37fa6961954acd96c52deb03dcb3c6e927872f0f/extra_tests/snippets/stdlib_re.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9896/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9896/files#diff-516ae05455c2584ebca0fbf07ee77b992fe8f68f8fc7c621221e8442ced0d6af
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9896/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.