René's URL Explorer Experiment


Title: DO NOT MERGE: restore function GC traversal edges by youknowdot · Pull Request #9894 · RustPython/RustPython · GitHub

Open Graph Title: DO NOT MERGE: restore function GC traversal edges by youknowdot · Pull Request #9894 · RustPython/RustPython

X Title: DO NOT MERGE: restore function GC traversal edges by youknowdot · Pull Request #9894 · RustPython/RustPython

Description: DO NOT MERGE: new-head CI and cross-platform validation pending Restore the omitted code and builtins-dictionary edges in PyFunction::traverse, matching CPython 3.15.2. This fixes trace class-qualified method discovery and collection of a builtins-only function cycle. update_lib auto-mark removed the two passing trace markers; the existing GC snippet covers the nonduplicative cycle case. The initial draft exposed test_gc.test_function collecting four objects rather than the permitted two or three. The follow-up resolves this by untracking exact tuples containing only objects which cannot have GC edges, during collection. It does not alter the canonical assertion, omit a true reference, or special-case the count. Atomic tuples are pinned while generation lists are scanned. Read locks are released before untracking, with the world still stopped; pins drop after restart. Subclasses/structseq remain tracked. Marshal initialization and successful CAPI tuple mutation retrack before inserting references, including mutation after collection. Tuple allocation does not acquire an element scan. Verified locally Independent source review of traversal ownership, untracking, lock order and mutation boundaries. Canonical test_gc, test_trace, test_funcattrs, test_tuple, test_marshal: 247 tests, 38 skipped, successful in both dev and release candidates. The release baseline reproduces the original count failure. Existing tuple/GC/marshal/threading-GC snippets, generational/subclass/recursive-marshal boundaries, and four-thread stress pass. Workspace Rust tests/doctests: 1,594 passed, 21 ignored, with standard WASM/venvlauncher/CAPI exclusions. Separate CAPI suite: 154 passed, 2 ignored, including New/Pack/FromArray mutation after collection. This validates the required mutation boundary, not wider CAPI expansion. Workspace and separate CAPI all-target Clippy pass; the existing wasi-host manifest lints-inheritance warning remains. Rustfmt, diff check and commit hooks pass. Performance and limits The rejected allocation-time scan had an 11–14% scalar-tuple regression and is not included. Some dev-profile probes also showed regressions, including +9.5% for calls; these did not reproduce in the same-path/toolchain/features release comparison with warmup, CPU affinity and paired CPU-time measurements. Release candidate/baseline geometric means across four pairs: calls +0.55%, cyclic containers +0.56%, compile +0.83%, generators +0.05%, nested tuples −1.82%. Baseline-only controls fluctuated too, and confidence intervals are wide. This is limited evidence, not proof of universal no-regression or exclusion of smaller/build-specific regressions. Windows, 32-bit, Miri, full snippet pytest and the new head's hosted CI remain unverified. The existing unattached-VM stop-the-world fallback still relies on caller exclusivity. Keep this draft until those limitations and the new CI results are reviewed. AI-assisted implementation, investigation and validation: Codex (model version unavailable).

Open Graph Description: DO NOT MERGE: new-head CI and cross-platform validation pending Restore the omitted code and builtins-dictionary edges in PyFunction::traverse, matching CPython 3.15.2. This fixes trace class-quali...

X Description: DO NOT MERGE: new-head CI and cross-platform validation pending Restore the omitted code and builtins-dictionary edges in PyFunction::traverse, matching CPython 3.15.2. This fixes trace class-quali...

Opengraph URL: https://github.com/RustPython/RustPython/pull/9894

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:724ba2e9-c1bc-131c-fd46-073b89e35732
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB728:19F84C:3726CED:461D0EB:6B01D7FD
html-safe-nonce3489b8fa62b384b91601b5c7d1a33b46994f5a708cfb2f657548a611ec108d3d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzI4OjE5Rjg0QzozNzI2Q0VEOjQ2MUQwRUI6NkIwMUQ3RkQiLCJ2aXNpdG9yX2lkIjoiMzk2MTA1NTQ2ODA3MjM2NjA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac663ac0ee2b11c6de6a97eba3f8b475c847ef92785f9cefce51fc202e832516bc
hovercard-subject-tagpull_request:5344217159
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/9894/files
twitter:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/336763669?s=400&v=4
og:image:altDO NOT MERGE: new-head CI and cross-platform validation pending Restore the omitted code and builtins-dictionary edges in PyFunction::traverse, matching CPython 3.15.2. This fixes trace class-quali...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/9894/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9894%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F9894%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/9894/files
Reloadhttps://github.com/RustPython/RustPython/pull/9894/files
Reloadhttps://github.com/RustPython/RustPython/pull/9894/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests132 (132)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowdothttps://github.com/youknowdot
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowdot:fix/function-gc-edges-20261116https://github.com/youknowdot/RustPython/tree/fix/function-gc-edges-20261116
Conversation 3 https://github.com/RustPython/RustPython/pull/9894
Commits 3 https://github.com/RustPython/RustPython/pull/9894/commits
Checks 28 https://github.com/RustPython/RustPython/pull/9894/checks
Files changed https://github.com/RustPython/RustPython/pull/9894/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9894/files
DO NOT MERGE: restore function GC traversal edges https://github.com/RustPython/RustPython/pull/9894/files#top
Show all changes 3 commits https://github.com/RustPython/RustPython/pull/9894/files
b6f9651 Visit function code and builtins during GC traversal youknowdot Nov 16, 2026 https://github.com/RustPython/RustPython/pull/9894/commits/b6f9651abdcaf4fe7318c72c072d87685f0b3f26
b0f7a4c Untrack exact atomic tuples during cycle collection youknowdot Nov 16, 2026 https://github.com/RustPython/RustPython/pull/9894/commits/b0f7a4c4526d9d263943878fd634576c3871986f
e3bad0b Isolate tuple GC reclamation regression from concurrent CAPI tests codex Nov 17, 2026 https://github.com/RustPython/RustPython/pull/9894/commits/e3bad0bea4772a1a6e5b1c6b083acbe54e426dac
Clear filters https://github.com/RustPython/RustPython/pull/9894/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9894/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9894/files
test_trace.py https://github.com/RustPython/RustPython/pull/9894/files#diff-897468a2ed95b93e1b3d5189c7ae0331da155594c17da9f2d48c20ee0063885f
tupleobject.rs https://github.com/RustPython/RustPython/pull/9894/files#diff-0e09222bc515c711cd0be3973de2757da85a3cbddf4f629c8ecd497658dbaa38
function.rs https://github.com/RustPython/RustPython/pull/9894/files#diff-42d321490bc76e3b57deebb41ff9815e8bbb7c976bb1b57a076d01f7bc347698
tuple.rs https://github.com/RustPython/RustPython/pull/9894/files#diff-606274a9a62c77c00f802fbc298be35b47e2932cf90cc413748b4d8fc69d7c7e
gc_state.rs https://github.com/RustPython/RustPython/pull/9894/files#diff-c57353cf1043101bf94270e6f2f16d54fd87c360dc58d08574149f294135fcae
marshal.rs https://github.com/RustPython/RustPython/pull/9894/files#diff-2d7ffaf41f1d27993109e208019bcd69e1b16a4002ced52a5da53c02c64c9258
stdlib_gc.py https://github.com/RustPython/RustPython/pull/9894/files#diff-e54098275c3565937d99c42d94c72e652a88427bb3a1f2ad0aad71c08f908acc
Lib/test/test_trace.pyhttps://github.com/RustPython/RustPython/pull/9894/files#diff-897468a2ed95b93e1b3d5189c7ae0331da155594c17da9f2d48c20ee0063885f
View file https://github.com/RustPython/RustPython/blob/e3bad0bea4772a1a6e5b1c6b083acbe54e426dac/Lib/test/test_trace.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9894/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9894/files#diff-897468a2ed95b93e1b3d5189c7ae0331da155594c17da9f2d48c20ee0063885f
https://github.com/RustPython/RustPython/pull/9894/files#diff-897468a2ed95b93e1b3d5189c7ae0331da155594c17da9f2d48c20ee0063885f
https://github.com/RustPython/RustPython/pull/9894/files#diff-897468a2ed95b93e1b3d5189c7ae0331da155594c17da9f2d48c20ee0063885f
https://github.com/RustPython/RustPython/pull/9894/files#diff-897468a2ed95b93e1b3d5189c7ae0331da155594c17da9f2d48c20ee0063885f
crates/capi/src/tupleobject.rshttps://github.com/RustPython/RustPython/pull/9894/files#diff-0e09222bc515c711cd0be3973de2757da85a3cbddf4f629c8ecd497658dbaa38
View file https://github.com/RustPython/RustPython/blob/e3bad0bea4772a1a6e5b1c6b083acbe54e426dac/crates/capi/src/tupleobject.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9894/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9894/files#diff-0e09222bc515c711cd0be3973de2757da85a3cbddf4f629c8ecd497658dbaa38
https://github.com/RustPython/RustPython/pull/9894/files#diff-0e09222bc515c711cd0be3973de2757da85a3cbddf4f629c8ecd497658dbaa38
https://github.com/RustPython/RustPython/pull/9894/files#diff-0e09222bc515c711cd0be3973de2757da85a3cbddf4f629c8ecd497658dbaa38
https://github.com/RustPython/RustPython/pull/9894/files#diff-0e09222bc515c711cd0be3973de2757da85a3cbddf4f629c8ecd497658dbaa38
crates/vm/src/builtins/function.rshttps://github.com/RustPython/RustPython/pull/9894/files#diff-42d321490bc76e3b57deebb41ff9815e8bbb7c976bb1b57a076d01f7bc347698
View file https://github.com/RustPython/RustPython/blob/e3bad0bea4772a1a6e5b1c6b083acbe54e426dac/crates/vm/src/builtins/function.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9894/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9894/files#diff-42d321490bc76e3b57deebb41ff9815e8bbb7c976bb1b57a076d01f7bc347698
https://github.com/RustPython/RustPython/pull/9894/files#diff-42d321490bc76e3b57deebb41ff9815e8bbb7c976bb1b57a076d01f7bc347698
crates/vm/src/builtins/tuple.rshttps://github.com/RustPython/RustPython/pull/9894/files#diff-606274a9a62c77c00f802fbc298be35b47e2932cf90cc413748b4d8fc69d7c7e
View file https://github.com/RustPython/RustPython/blob/e3bad0bea4772a1a6e5b1c6b083acbe54e426dac/crates/vm/src/builtins/tuple.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9894/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9894/files#diff-606274a9a62c77c00f802fbc298be35b47e2932cf90cc413748b4d8fc69d7c7e
https://github.com/RustPython/RustPython/pull/9894/files#diff-606274a9a62c77c00f802fbc298be35b47e2932cf90cc413748b4d8fc69d7c7e
crates/vm/src/gc_state.rshttps://github.com/RustPython/RustPython/pull/9894/files#diff-c57353cf1043101bf94270e6f2f16d54fd87c360dc58d08574149f294135fcae
View file https://github.com/RustPython/RustPython/blob/e3bad0bea4772a1a6e5b1c6b083acbe54e426dac/crates/vm/src/gc_state.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9894/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9894/files#diff-c57353cf1043101bf94270e6f2f16d54fd87c360dc58d08574149f294135fcae
https://github.com/RustPython/RustPython/pull/9894/files#diff-c57353cf1043101bf94270e6f2f16d54fd87c360dc58d08574149f294135fcae
https://github.com/RustPython/RustPython/pull/9894/files#diff-c57353cf1043101bf94270e6f2f16d54fd87c360dc58d08574149f294135fcae
https://github.com/RustPython/RustPython/pull/9894/files#diff-c57353cf1043101bf94270e6f2f16d54fd87c360dc58d08574149f294135fcae
https://github.com/RustPython/RustPython/pull/9894/files#diff-c57353cf1043101bf94270e6f2f16d54fd87c360dc58d08574149f294135fcae
https://github.com/RustPython/RustPython/pull/9894/files#diff-c57353cf1043101bf94270e6f2f16d54fd87c360dc58d08574149f294135fcae
https://github.com/RustPython/RustPython/pull/9894/files#diff-c57353cf1043101bf94270e6f2f16d54fd87c360dc58d08574149f294135fcae
https://github.com/RustPython/RustPython/pull/9894/files#diff-c57353cf1043101bf94270e6f2f16d54fd87c360dc58d08574149f294135fcae
crates/vm/src/stdlib/marshal.rshttps://github.com/RustPython/RustPython/pull/9894/files#diff-2d7ffaf41f1d27993109e208019bcd69e1b16a4002ced52a5da53c02c64c9258
View file https://github.com/RustPython/RustPython/blob/e3bad0bea4772a1a6e5b1c6b083acbe54e426dac/crates/vm/src/stdlib/marshal.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9894/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9894/files#diff-2d7ffaf41f1d27993109e208019bcd69e1b16a4002ced52a5da53c02c64c9258
https://github.com/RustPython/RustPython/pull/9894/files#diff-2d7ffaf41f1d27993109e208019bcd69e1b16a4002ced52a5da53c02c64c9258
extra_tests/snippets/stdlib_gc.pyhttps://github.com/RustPython/RustPython/pull/9894/files#diff-e54098275c3565937d99c42d94c72e652a88427bb3a1f2ad0aad71c08f908acc
View file https://github.com/RustPython/RustPython/blob/e3bad0bea4772a1a6e5b1c6b083acbe54e426dac/extra_tests/snippets/stdlib_gc.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/9894/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/9894/files#diff-e54098275c3565937d99c42d94c72e652a88427bb3a1f2ad0aad71c08f908acc
Please reload this pagehttps://github.com/RustPython/RustPython/pull/9894/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.